Re: gzip: add "--keep" option to keep original files unchanged

2013-02-12 Thread Rodrigo Campos
On Mon, Feb 11, 2013 at 06:49:15AM -0700, Eric Blake wrote: > On 02/10/2013 05:59 PM, Paul Eggert wrote: > > On 02/10/2013 07:41 AM, Rodrigo Campos wrote: > >> Is this use case valid enough to accept > >> the patch ? > > > > I'm sort of on the fence on this one. > > Comments from others welcome. >

Re: gzip: add "--keep" option to keep original files unchanged

2013-02-12 Thread Paul Eggert
On 02/12/13 12:22, Rodrigo Campos wrote: > What do you think ? I think it's fine to put a change like that in. The documentation needs to be improved, and if you're doing the change it's probably complex enough that we'll need to have papers signed -- is that something you can do?

Re: gzip: add "--keep" option to keep original files unchanged

2013-02-12 Thread Rodrigo Campos
On Tue, Feb 12, 2013 at 02:07:54PM -0800, Paul Eggert wrote: > On 02/12/13 12:22, Rodrigo Campos wrote: > > What do you think ? > > I think it's fine to put a change like that in. Great! Do you prefer the short option to be "-k" or "-K" ? Eric suggested "-k", similar to what bzip2 and friends us

Re: gzip: add "--keep" option to keep original files unchanged

2013-02-12 Thread Bob Proulx
Rodrigo Campos wrote: > Great! Do you prefer the short option to be "-k" or "-K" ? > > Eric suggested "-k", similar to what bzip2 and friends use. I have > used "-K" to avoid overlapping with pkzip (currently not being > used). But I have no problem using "-k" or "-K". I would vote with Eric and

Re: gzip: add "--keep" option to keep original files unchanged

2013-02-12 Thread Rodrigo Campos
On Tue, Feb 12, 2013 at 05:51:49PM -0700, Bob Proulx wrote: > Rodrigo Campos wrote: > > Great! Do you prefer the short option to be "-k" or "-K" ? > > > > Eric suggested "-k", similar to what bzip2 and friends use. I have > > used "-K" to avoid overlapping with pkzip (currently not being > > used)

[PATCH v2] gzip: add "--keep" option to keep (don't delete) input files

2013-02-12 Thread Rodrigo Campos
By default it is disabled to keep everything working as before. And as a short option "-k" is used to be consistent with xz and bzip2. Also, this patch changes "--stdout" which "Write output on standard output; keep original files unchanged" to imply "-k" --- gzip.1 |9 ++--- gzip.c | 1

[PATCH v3] gzip: add "--keep" option to keep (don't delete) input files

2013-02-12 Thread Rodrigo Campos
By default it is disabled to keep everything working as before. And as a short option "-k" is used to be consistent with xz and bzip2. Also, this patch changes "--stdout" which "Write output on standard output; keep original files unchanged" to imply "-k" --- changes since v2: added doc of "--kee