bug#56398: (guix git) fails to check out repos with nested submodules

Hi André, André Batista skribis: > qui 24 nov 2022 às 12:17:19 (1669303039), nan...@riseup.net enviou: >> Upstream issue #6433 > > Fixed on upstream commit 936b184e7494158c20e522981f4a324cac6ffa47 Excellent. Let’s close this bug once we’ve updated the ‘libgit2’ package to a version that includ

bug#56398: (guix git) fails to check out repos with nested submodules

qui 24 nov 2022 às 12:17:19 (1669303039), nan...@riseup.net enviou: > Upstream issue #6433 Fixed on upstream commit 936b184e7494158c20e522981f4a324cac6ffa47

bug#56398: (guix git) fails to check out repos with nested submodules

Hi, On +2022-11-24 12:17:01 -0300, André Batista wrote: > Hi! > > qui 04 ago 2022 às 13:59:20 (1659632360), ludovic.cour...@inria.fr enviou: > > I think we should instead report it upstream. Do you feel like doing > > it? I guess we’d need to give them the C version of the three-line > > snippe

bug#56398: (guix git) fails to check out repos with nested submodules

Hi! qui 04 ago 2022 às 13:59:20 (1659632360), ludovic.cour...@inria.fr enviou: > I think we should instead report it upstream. Do you feel like doing > it? I guess we’d need to give them the C version of the three-line > snippet I gave earlier. Upstream issue #6433[1] Apparently, GIT_SUBMODULE

bug#56398: (guix git) fails to check out repos with nested submodules

sex 05 ago 2022 às 17:10:50 (1659730250), nan...@riseup.net enviou: > Does it though? I'm trying to wrap my head over this, but I'm somewhat > unsure that this isn't the intended - expected? - behaviour on this > case: > (...) > So, I'm inclined to think that this is not a bug on libgit2, but a >

bug#56398: (guix git) fails to check out repos with nested submodules

qui 04 ago 2022 às 13:59:20 (1659632360), ludovic.cour...@inria.fr enviou: > But you got a wrong hash I presume, because submodule weren’t actually > checked out, right? The submodule was not checked out, sure, but is it the wrong hash considering it's also not present on the remote repo? > The p

bug#56398: (guix git) fails to check out repos with nested submodules

Hello, André Batista skribis: > Well, I guess ENOENT != GIT_ENOTFOUND and, in that case, I think we > are better off gracefully failing to update it than trying to "branch" > our local repo. The patch below tests for the directory's existence > before proceding with the update. With this patch a

bug#56398: (guix git) fails to check out repos with nested submodules

Hi Bengt! sex 08 jul 2022 às 12:17:59 (1657293479), b...@bokr.com enviou: > Have you seen this[1] re nested git tricks? > > [1]: No, I had missed that, thanks for pointing that out! > i.e., are you sure not to be used by some such attack? However I think

bug#56398: (guix git) fails to check out repos with nested submodules

Hi and I'm sorry for the delay.. sex 08 jul 2022 às 10:26:40 (1657286800), ludovic.cour...@inria.fr enviou: > If we do this: > > --8<---cut here---start->8--- > scheme@(guix git)> (define r (repository-open > "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5ov

bug#56398: (guix git) fails to check out repos with nested submodules

Hi, On +2022-07-07 23:45:35 -0300, André Batista wrote: > qui 07 jul 2022 às 18:35:42 (1657229742), nan...@riseup.net enviou: > > I think this may be actually a bug upstream. (...) > > I mean, we could change the submodule-update fetch-options to allow > for repository initialization when it's ab

bug#56398: (guix git) fails to check out repos with nested submodules

Hi! André Batista skribis: > Hi! > > ter 05 jul 2022 às 17:02:31 (1657051351), ludovic.cour...@inria.fr enviou: >> It seems that ‘update-cached-checkout’ fails to handle nested Git >> submodules, when a submodule itself has submodules: > > I think this may be actually a bug upstream. When refres

bug#56398: (guix git) fails to check out repos with nested submodules

qui 07 jul 2022 às 18:35:42 (1657229742), nan...@riseup.net enviou: > I think this may be actually a bug upstream. (...) I mean, we could change the submodule-update fetch-options to allow for repository initialization when it's absent, but does it make sense considering we would just remove it wh

bug#56398: (guix git) fails to check out repos with nested submodules

Hi! ter 05 jul 2022 às 17:02:31 (1657051351), ludovic.cour...@inria.fr enviou: > It seems that ‘update-cached-checkout’ fails to handle nested Git > submodules, when a submodule itself has submodules: I think this may be actually a bug upstream. When refreshing, guix is able to recursively upgrad

bug#56398: (guix git) fails to check out repos with nested submodules

Hello, It seems that ‘update-cached-checkout’ fails to handle nested Git submodules, when a submodule itself has submodules: --8<---cut here---start->8--- $ ./pre-inst-env guix refresh python-pytorch gnu/packages/machine-learning.scm:2872:13: python-pytorch wou