Mark H Weaver writes:
> Earlier, I wrote:
>> In contrast, a call to 'substitute*' will silently start doing nothing,
>> and may easily be forgotten. To make matters worse, a future version of
>> jack-2 might add another 'for' loop in that file, matching the same
>> pattern but where it is impo
Mark H Weaver writes:
> Efraim Flashner writes:
>
>> On Mon, Sep 14, 2020 at 09:25:25PM -0700, Mike Rosset wrote:
>>> * gnu/packages/audio.scm (jack-2): Update to 1.9.14.
>>> [arguments]: new 'declare-for-int phase after unpack that declares 'i in the
&
Andreas Enge writes:
> On Tue, Sep 15, 2020 at 01:37:05AM -0700, Mike Rosset wrote:
>> Apologies, I just wanted to keep a series for posterity which normally
>> I'm terrible at. I should have mentioned you could just squash them.
>
> No problem, it is just less wor
Andreas Enge writes:
> Hello Mike,
>
> On Tue, Sep 15, 2020 at 12:48:02AM -0700, Mike Rosset wrote:
>> * gnu/packages/audio.scm (jack2): remove 'declare-for-int phase.
>> [arguements]: phases 'declare-for-int has been removed. since package now
>> builds.
* gnu/packages/audio.scm (jack-2): Update to 1.9.14.
[arguments]: 'set-linkflags phase now adds -lstdc++ to the LDFLAGS
environment variable.
This fixes an issue that where the linker would fail with "undefined reference
to symbol '__gxx_personality_v0@@CXXABI_1.3" on aarch64-linux system.
---
gn
* gnu/packages/audio.scm (jack2): remove 'declare-for-int phase.
[arguements]: phases 'declare-for-int has been removed. since package now
builds.
---
gnu/packages/audio.scm | 6 --
1 file changed, 6 deletions(-)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 83c08b718e..f
Efraim Flashner writes:
> On Mon, Sep 14, 2020 at 09:25:25PM -0700, Mike Rosset wrote:
>> (modify-phases %standard-phases
>> + (add-after 'unpack 'declare-for-int
>> + (lambda _
>> + ;; Declare the for loop i incr
* gnu/packages/audio.scm (jack-2): Update to 1.9.14.
[arguments]: new 'declare-for-int phase after unpack that declares 'i in the
for initialize statement. Add -lstdc++ to LDFLAGS 'set-linkflags phase
ensures -lstdc++ is at the tail.
This fixes issues that cause jack-2 to not build on system aarh
Andreas Enge writes:
> The error message is:
> [228/274] Compiling example-clients/simdtests.cpp
> ...
> [243/274] Linking build/example-clients/jack_simdtests
> ...
> ld: example-clients/simdtests.cpp.28.o: undefined reference to symbol
> '__gxx_personality_v0@@CXXABI_1.3'
> ld:
> /gnu/store
Andreas Enge writes:
> Hello,
>
> On Sat, Sep 05, 2020 at 04:18:47PM +0100, Pierre Langlois wrote:
>> That sounds familiar, I think I hit this issue a few weeks
>> back. But at the moment, it seems the CI has successfully built php for
>> aarch64 https://ci.guix.gnu.org/build/3166798/details
>
Pierre Neidhardt writes:
> Thank you, I've merged!
> qtwebengine is finally in, hooray!
>
> Thank you to you all, and big thanks to Mike for driving this effort!
>
> I committed a few changes to your commits:
>
> - I squashed the comment fixing commits.
> - Edited some more typos.
> - Removed "b
* gnu/packages/qt.scm (python-pyqtwebengine): New variable.
---
gnu/packages/qt.scm | 86 +
1 file changed, 86 insertions(+)
diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 9f289aa6df..fcb297e99c 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/p
Pierre Neidhardt writes:
> Mike Rosset writes:
>
>>> Please apply the above pyqt change to a separate commit.
>>
>> I missed this comment with my new series. If this really needs to be
>> done, I'll have to redo all of the commits and resend the seri
* gnu/packages/web-browsers.scm (qutebrowser)[comments]: Improve the comment
describing why qtwebengine is used as an input. Added punctuation to FIXME
for test phase.
---
gnu/packages/web-browsers.scm | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/gnu/packages
* gnu/packages/qt.scm (python-pyqt)[phases]: When building
python-pyqtwebengine qprinter.h can not be found. This substitutes the full
path of qprinter.h in the qprinter sip specification file.
---
gnu/packages/qt.scm | 11 +++
1 file changed, 11 insertions(+)
diff --git a/gnu/packag
* gnu/packages/qt.scm (python-pyqt)[comments]: And python-pyqtwebengine now
uses mkdir-p instead of a system call.
---
gnu/packages/qt.scm | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index fcb297e99c..611c38a443 100644
* gnu/packages/web-browsers.scm (qutebrowser): Update to 1.9.0.
qutebrowser no longer uses qtwebkit by default. It now defaults to qtwebengine.
---
gnu/packages/web-browsers.scm | 40 ---
1 file changed, 28 insertions(+), 12 deletions(-)
diff --git a/gnu/packages/
Pierre Neidhardt writes:
> Mike Rosset writes:
>
>>> Please apply the above pyqt change to a separate commit.
>>
>> I missed this comment with my new series. If this really needs to be
>> done, I'll have to redo all of the commits and resend the seri
>> + ;; store.
>> + (add-before 'configure 'substitute-source
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (let* ((qtbase (assoc-ref inputs "qtbase"))
>> +(qtprinter.h (string-append "\"" qtbase
>> "/include/qt5/QtPrintSupport/qp
* gnu/packages/qt.scm (python-pyqt)[comments]: And python-pyqtwebengine now
uses mkdir-p instead of a system call.
---
gnu/packages/qt.scm | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index fcb297e99c..611c38a443 100644
* gnu/packages/web-browsers.scm (qutebrowser)[comments]: Improve the comment
describing why qtwebengine is used as an input. Added punctuation to FIXME
for test phase.
---
gnu/packages/web-browsers.scm | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/gnu/packages
Pierre Neidhardt writes:
>
> Why are you removing this?
>
> Other than those few nits, looks good to me!
>
Thanks for looking at this Pierre. I will makes these changes you have
suggested ASAP.
I removed the man page generation because it is already distributed with
the tarball and it caused
Hello Florian
With the addition of QtWebengine into Guix. I've created some patches to
upgrade qutebrowser to 1.9.0 and to use QtWebengine by default.
And Guix is now using Qt 5.12.6 which is not to bad.
I hope this leads to less error reports for you. Once this gets merged
in.
Regards,
Mike
* gnu/packages/web-browsers.scm (qutebrowser): Update to 1.9.0.
qutebrowser no longer uses qtwebkit by default. It now defaults to qtwebengine.
---
gnu/packages/web-browsers.scm | 40 ---
1 file changed, 28 insertions(+), 12 deletions(-)
diff --git a/gnu/packages/
* gnu/packages/qt.scm (python-pyqtwebengine): New variable.
---
gnu/packages/qt.scm | 97 +
1 file changed, 97 insertions(+)
diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 514577678e..fcb297e99c 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/p
25 matches
Mail list logo
