bug#38263: Bug in srfi-11 (?)

2019-11-18 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
Hi, I was tinkering with srfi-11 and was wondering whether the following is correct: > scheme@(guile-user)> ,expand (let-values (((a b c) (values 1 2 3)) > ((d . e) (values 4 5))) > (list a b c d e)) > $26 = ((@@ (srfi srfi-11) call-with-values)

bug#38263: Bug in srfi-11

2019-11-19 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
Hi, I had a look today into the srfi-11 specificiation. It requires that the variables are bound to fresh locations so let me rephrase the bug: > (let ((a 1) > (b (let-values (((a . b) (values 2 3)) >(c (begin (set! a 9) 4))) >(list a b c > (cons a b

bug#38396: internal fds leak across exec

2019-11-26 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
Where Guile opens a file in order to read code from it, that file descriptor ought to be private to Guile, in the sense that it should not be passed on to another program across exec. But it is so leaked, as can be seen especially clearly using Linux's /proc/*/fd feature: $ cat /tmp/t0 (system

bug#38398: non-obvious SCM_EOF_VAL rationale

2019-11-26 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
The part of the Guile manual on the representation of immediate objects says: # -- Macro: SCM SCM_EOF_VAL # The Scheme end-of-file value. It has no standard written # representation, for obvious reasons. I disagree with the manual: the reasons for the EOF value having no s-expression rep

bug#38398: non-obvious SCM_EOF_VAL rationale

2019-11-27 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
John Cowan wrote: >On the contrary: the EOF object is not a character, but it *can* be >returned by read-char . Bother. Of course I meant "can't be returned by read-char in a non-EOF situation". I was alluding precisely to it being distinguishable from characters for the purposes of that return

bug#38263: Bug in srfi-11

2019-12-03 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
Hello again, the attached patch also adds a unit test. I am not into how Guile is organized: Is there anything keeping us from adding the change? Tim. >From 99d8fb795932eb92b7d5fb09115b6691f4bfe66d Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Tue, 3 Dec 2019 18:50:37 +0100 Subject: [PATC

bug#39118: Segfault while building on 64-bit Cygwin

2020-01-20 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
On Mon, Jan 20, 2020 at 11:38:35AM -0500, John Cowan wrote: > Yes, gladly, but I don't know how to get one in this context. Do I need to > add some flags to the Makefile, and if so, where? (It's a twisty maze of > passages, all different.) . Note that this *is* a build with JIT enabled; > when I

bug#39314: program-bindings is documented but missing

2020-01-27 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
Hi, Guiles reference manual mentions a procedure program-bindings in (system vm programs) in the "Compiled Procedures" node. It is missing however on guile-3.0 and a quick grep over Guiles sources shows no result apart from the documentation. The documentation should probably be removed unless I mi

bug#39420: guile-dbi

2020-02-04 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
Hi, The link on page https://www.gnu.org/software/guile/libraries/ that redirect to  http://home.gna.org/guile-dbi/guile-dbi.html doesn't work

bug#39421: Keywords section in the Guile manual

2020-02-04 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
The link on page https://guix.gnu.org/blog/2018/a-packaging-tutorial-for-guix/  that redirects to  https://www.gnu.org/software/guile/manual/en/html_node/Keywords.html doesn't work

bug#39118: Segfault while building on 64-bit Cygwin

2020-02-16 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
On Fri, Feb 14, 2020 at 09:46:04AM -0800, Charles Stanhope wrote: > Andy, I don't know if you'd want to continue this here or on > lightening's gitlab page, but I looked into this a little bit a few > minutes here and there this past weeek. The x86 "fast-call" calling > convention used on Windows x

bug#39266: Finalization thread hits wrong-type-arg on weak vector (AArch64)

2020-02-29 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
Seconding what Brian said, I would also be happy with this solution. Right now, guix users on aarch64 simply aren't using guile 3 because they can't pull, so this one bug probably acts as a blocker to encountering other potential bugs. So even though it's not satisfactory, getting aarch64 worki

bug#40681: srfi-18 mutex-unlock! breaks mutex on timeout

2020-04-17 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
hi, when mutex-unlock! is called (master: module/srfi/srfi-18.scm +306) with a condition and a timeout, it first resets the owner and then waits for the condition. If the timeout is reached (threads:wait-condition-variable returns #f) the cond's else condition returns #f. Now the owner is #f, whic

bug#40847: compile errors and missing dependencies when building in mingw32 on windows

2020-04-25 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
I'm trying to compile guile 3.0.2 on a windows 32bit machine using Mingw32. I was able to successfully run the configure script with no errors. FYI I had to compile the following libraries from source in order for the configure script to finish because for some reason the libraries installed by p

bug#40954: Guile 3.0.2 Fails to compile on macOS Catalina

2020-04-29 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
The following line in: libguile Makefile target: install-data-hook during a “make install” call results in a "sed -e file not found" error and stops installation. $(INSTANTIATE) "$(DESTDIR)$(libdir)/$$libname-gdb.scm” When it is removed from the Makefile, Guile can be installed and “make chec

bug#39999: sed -i non-POSIX

2020-04-29 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
Greg, Good point. The BSD sed man page says: "The -E, -a and -i options are non-standard FreeBSD extensions and may not be available on other operating systems." So perhaps a better solution is to not use the -i option at all and be POSIX compliant? Informally looking through some of the cod

bug#19019: guile assumes long is the same size as pointers

2020-11-25 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
There appears to be a patch to fix this on guile 2.2 at https://gitlab.com/janneke/guile/-/commit/f0fade08173b97e2b4a68b79b654ad3d30a59286

bug#45595: recvfrom! optional start and end parameter invalid

2021-01-01 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
hi, the parameter validation for the optional "start" and "end" arguments to "recvfrom!" are off by one if "end" is passed. From libguile/socket.c (master commit 64c89458e6): ... if (SCM_UNBNDP (end)) cend = SCM_BYTEVECTOR_LENGTH (buf); else { cend = scm_to_size_t (end);

bug#45782: (web uri): URI hosts cannot be hexadecimal numbers

2021-01-11 Thread Bug reports for GUILE, GNU's Ubiquitous Extension Language
Dear guile developers, (use-modules (web uri)) (build-uri 'http #:host "g") (build-uri 'http #:host "a") The first operation works (#< scheme: http userinfo: #f host: "g" port: #f path: "" query: #f fragment: #f>), the second does not (Throw to key `uri-error' with args `("Expected valid host:

bug#45816: (ice-9 suspendable-ports):get-bytevector-some! is broken

2021-01-12 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
hi, (ice-9 suspendable-ports):get-bytevector-some! calls bytevector-copy! with transfer-size (which is a number) as third argument: ... (define (get-bytevector-some! port bv start count) (if (zero? count) 0 (call-with-values (lambda () (fill-input port 1 'binary))

bug#46014: (define (thunk) (lambda (x) x)) should be a compile error?

2021-01-20 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hello! Consider this bit of simple code: #+BEGIN_SRC scheme (define (thunk) (lambda (x) x)) (thunk) ;; works ok, I guess. (thunk "hello world!\n") ;; runtime error ;;; :1074:0: warning: possibly wrong number of arguments to `thunk' ice-9/boot-9.scm:1669:16: In procedure raise-exceptio

bug#46014: (define (thunk) (lambda (x) x)) should be a compile error?

2021-01-21 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Ricardo Wurmus writes: > Hi, > >> Consider this bit of simple code: >> >> #+BEGIN_SRC scheme >> >> (define (thunk) >>(lambda (x) >> x)) >> >> (thunk) ;; works ok, I guess. >> (thunk "hello world!\n") ;; runtime error >> >> ;;; :1074:0: warning: possibly wrong number of arguments to `thu

bug#46014: (define (thunk) (lambda (x) x)) should be a compile error?

2021-01-21 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Stefan Israelsson Tampe writes: > I will note that paying attention to those warnings is super heolpful in > programming in guile. I miss these warnings > alot when doing python programming.In a sense with these warnings you get > close to static typechecking programming > languages and scheme/

bug#46014: (define (thunk) (lambda (x) x)) should be a compile error?

2021-01-22 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Ricardo Wurmus writes: > Hi Joshua, > >> When I look at >> >> #+BEGIN_SRC scheme >> (define (thunk) >>(lambda (x) >> x)) >> #+END_SRC > > […] > >> My thought is, this is clearly a mistake. This person needs to change >> the above code. > > How is this clearly a mistake? The definition

bug#46014: closing the bug report...hopefully

2021-01-23 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
close 46014

bug#46014: (define (thunk) (lambda (x) x)) should be a compile error?

2021-01-23 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hey Ricardo! Thanks for taking the time to explain that thunk is a procedure with no arguments, and that the first x is not used in some of those procedures. Feel free to close this bug report. I don't believe I was able to demonstrate any examples of the compiler misbehaving. Thanks! -- Jos

bug#46273: Fix typo in lambda documentation

2021-02-03 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
In the part about lambda formals, change "arguments will converted into" to "arguments will BE converted into". --- Luis Felipe López Acevedo https://luis-felipe.gitlab.io/ From 16e5614682cad87aab26370f149d2c5a6b4f7362 Mon Sep 17 00:00:00 2001 From: Luis Felipe Date: Wed, 3 Feb 2021 13:23:00 -0

bug#47568: [PATCH] Fix typos in examples

2021-04-02 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* examples/box-dynamic-module/box.c * examples/box-dynamic/box.c * examples/box/box.c * examples/modules/README * examples/web/debug-sxml.scm --- examples/box-dynamic-module/box.c | 2 +- examples/box-dynamic/box.c| 2 +- examples/box/box.c| 4 ++-- examples/modules/README

bug#48150: breaking gmp

2021-05-01 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
With Guile 2.2.6: $ guile-2.2 -c '(ash 1 (ash 1 37))' gmp: overflow in mpz type zsh: abort guile-2.2 -c '(ash 1 (ash 1 37))' $ For shift distances of (ash 1 63) or greater Guile cleanly signals an exception indicating the overflow. The above treatment of a range of smaller (but still stupid

bug#45816: (ice-9 suspendable-ports):get-bytevector-some! is broken

2021-05-06 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hi, this was fixed by: commit f591ad28f1bcec67f17a123766f798d16bec5373 Author: Andrew Whatson Date: Fri Jan 22 20:10:10 2021 +1000 Fix suspendable implementation of 'get-bytevector-some!' * module/ice-9/suspendable-ports.scm (get-bytevector-some!): Fix incorrect arguments

bug#48816: guile: Add ARC support

2021-06-03 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hi, I'm trying to bootstrap Debian on ARC and need to add arc support in guile 2.x and 3.x. Patch attached. Thx, -Vineet From d7229d384e503d7a3893e13e71fe0ad16c2e8003 Mon Sep 17 00:00:00 2001 From: Vineet Gupta Date: Tue, 6 Apr 2021 15:03:07 -0700 Subject: [PATCH] add support for arc Signed-of

bug#49085: Handle more unicode characters in uri-decode

2021-06-18 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Dear guilers, uri-decode should accept unicode characters. This is difficult to implement so that different encodings can be used, but here is my solution. Best regards, Vivien From 7adb0e333624c617f7c95796053df60d0a504ec9 Fri Jun 18 11:57:13 2021 From: Vivien Kraus Date: Fri, 18 Jun 2021 11:57

bug#49085: Unicode in uri-decode: we’re parsing IRIs, so NFC (unicode normalization) applies.

2021-07-20 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
maximed in #guix pointed out that there should not be any non-ascii character in a URI, so what I was trying to do is simultaneously parse an IRI and convert it to an URI. For this to work, unicode normalization is required. From 39fd259ac1aa126ca311c687041baa5568cfdc09 Mon Sep 17 00:00:00 2001 Fro

bug#48816: Ping

2021-08-27 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hello, Just a gentle reminder. We need this package for bootstrapping Debian port for ARC. Hopefully already attached patch would help. -Alexey X-Debbugs-CC: linux-snps-...@lists.infradead.org,guil...@debian.org,hel...@subdivi.de

bug#50719: Cannot add a no-applicable-method implementation for a generic with no method

2021-09-21 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Dear guile, The following program should just return 'foo, but it enters an infinite loop: (use-modules (oop goops)) (define-class ()) (define-method (no-method (generic ) args) 'foo) (define-method (no-applicable-method (generic ) args) 'foo) (define hello (make #:name 'hello))

bug#50730: suspendable-ports.test: test case fails

2021-09-21 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
This bug was originally reported to bug-g...@gnu.org. Copying here. Guix bug report: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=50729 I suspect it may be a bug in my kernel if not a bug in guile itself. The test case fails on both master and v3.0.7 (git). ./build-aux/config.guess x86_64-pc-li

bug#51133: [PATCH 1/1] Tolerate http response line without reason phrase

2021-10-11 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* module/web/http.scm (read-response-line): Use the end of the string, in case a line doesn't have char-set:whitespace at the end. * test-suite/tests/web-http.test ("read-response-line"): Add test. --- module/web/http.scm| 6 -- test-suite/tests/web-http.test | 2 ++ 2 files change

bug#51133: [PATCH 1/1] Tolerate http response line without reason phrase

2021-10-12 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hi, I agree that it is not a complient http response, but unfortunately I came across with some http services (redfish, cimc from Cisco ), where they don't put a reason phrase. As you can see the difference is that response line doesn't have a space after the response code, that is why it raise an

bug#51133: [PATCH 1/1] Tolerate http response line without reason phrase

2021-10-12 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
jaku...@riseup.net writes: > You're right but you didn't address my second point. > The fact that with this patch > > (call-with-input-string "HTTP/1.1 \n" > (lambda (port) (read-response-line port))) I see, my bad, thanks! Please find a newly attached patch. I added a test for such a case, bu

bug#51445: (no subject)

2021-10-27 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
This is more of a feature request. Apologies if this is an annoying request. So I made a pretty noobie-like mistake a few days ago using (guix records). When one tries to create a , he invariably creates an infinite number of records. The guile compiler eventually runs out of memory and stops c

bug#52218: Unable to define more than one R7RS library per file

2021-12-01 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Guile is unable to handle more than one define-library per file. For example, this is "mylibs.sld", which contains two define-library: (define-library (example mylib) (import (scheme base)) (export f) (begin (define (f x) (+ x 1 (define-library (example main) (import (scheme

bug#52218: Unable to define more than one R7RS library per file

2021-12-01 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
On 2021-12-01 11:00 +0100, Linus Björnstam wrote: > This is in line with the limitations of guile's R6RS implementation. I > think this is a long standing, low priority bug. It has to do with the > expansion of library (or define-library in this case) not properly > resetting the current module. >

bug#52482: [PATCH] doc/ref/texinfo.texi: corrected typo generare->generate

2021-12-14 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Signed-off-by: Blake Shaw --- doc/ref/texinfo.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/ref/texinfo.texi b/doc/ref/texinfo.texi index 64a866b23..59df7f8e7 100644 --- a/doc/ref/texinfo.texi +++ b/doc/ref/texinfo.texi @@ -472,7 +472,7 @@ Serialize the stexi @var{t

bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly

2021-12-27 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hello, While working on the Guix installer (that needs to use system* quite a lot), I've noticed that output/error redirection doesn't behave as intended when combined with system*. Here's a test you can try at home: --8<---cut here---start->8--- (call-with-out

bug#52835: [PATCH 1/2] Fix child spawning closing standard fds prematurely

2021-12-27 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c (start_child): Close standard file descriptors only after all of them have been dup2'd. --- libguile/posix.c | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/libguile/posix.c b/libguile/posix.c index 3ab12b99e..148ebe

bug#52835: [PATCH 2/2] Remove unused renumber_file_descriptor

2021-12-27 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c (renumber_file_descriptor): Remove it. --- libguile/posix.c | 32 +--- 1 file changed, 1 insertion(+), 31 deletions(-) diff --git a/libguile/posix.c b/libguile/posix.c index 148ebeb3d..2624d07c2 100644 --- a/libguile/posix.c +++ b/libguile/posix.c @@

bug#52835: [PATCH v2 2/2] Remove unused renumber_file_descriptor

2021-12-27 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c (renumber_file_descriptor): Remove it. --- Sorry for the noise, but I just saw that this patch omitted a closing */, here is a fixed version. libguile/posix.c | 30 -- 1 file changed, 30 deletions(-) diff --git a/libguile/posix.c b/libguile/posix.c

bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly

2021-12-28 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hello Timothy, Timothy Sample writes: > One thing that ‘renumber_file_descriptor’ does that we seem to be losing > here is error checking. To my eye, the old code will try and warn the > user if they run out of file descriptors, but the new code will not. I may have been too hasty on that fron

bug#53201: string->uri-reference rejects domain names with final ‘.’

2022-01-11 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Guilers, What the subject says :-) Omitting the final dot is optional (and common), not mandatory. scheme@(guile-user)> (string->uri-reference "http://x.org";) $1 = #< … host: "x.org" …> scheme@(guile-user)> (string->uri-reference "http://x.org.";) $2 = #f ; wrong! This actually breaks

bug#53244: Guile 3.0.7.14-118ee re-export bug

2022-01-13 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
There's a difference in exports depending on if you use use-modules vs resolve-module. If a module re-exports a function and the module is imported using use-modules the re-export seems to work as one would expect as the documentation says, the cdr of the pair is the member of the public interf

bug#53408: guile site broken link

2022-01-21 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hi ! The link for Greg Badros' Scheme Lecture Notes on the page https://www.gnu.org/software/guile/learn/ is broken. Seems that there's just a / missing : https://courses.cs.washington.edu/courses/cse341/99su/lectures/scheme/ works. Cheers,

bug#52835: [PATCH v3] Fix child spawning closing standard fds prematurely

2022-02-07 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c (renumber_file_descriptor): Refactor it as dup_handle_error. (dup_handle_error, dup2_handle_error): New functions that wrap around dup and dup2 by retrying on EINTR or EBUSY, as well as erroring out on other errors. (start_child): Close standard file descriptors only after all of

bug#52230: 'guild compile' and C(++) extensions (in the context of LilyPond)

2022-02-19 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
On Sat, 19 Feb 2022, Jean Abou Samra wrote: I had similar problem with Jami. I added C++ primitives to Guile, but these were not load using the foreign function interface. Note, I'm using Guile 3.0.8, but I think the same could be done for Guile 2.0. Basically what I do is to add a `compile` c

bug#55344: ftw thinks readable directories are unreadable if "other" don't have read permission

2022-05-09 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
ftw incorrectly thinks that if other users don't have the read permission then the owner can't read it either. This also affects ntfw. Guile version: 3.0.8 Machine type: x86_64-pc-linux-gnu guile@3.0.8 from Guix To reproduce: Create 2 directories, one with rwxrwxrwx permissions and another wit

bug#55456: No Guile Version for Windows OS

2022-05-16 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hi, I read through your wishlist. I gather that GNU Guile is a replacement for Scheme. There isn't a 64-bit Windows version available. And GNU can easily create a VS Code plug-in for Guile. Regards, --- Andrew Goh

bug#55457: No Guile Version for Windows OS

2022-05-16 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Dear GNU Guile, The only Windows distribution of Scheme that is available on the Windows platform is "Scheme 48". Regards, --- Andrew Goh On Monday, 16 May 2022, 02:18:31 pm SGT, Andrew Goh wrote: Hi, I read through your wishlist. I gather that GNU Guile is a replacement for Scheme.

bug#52835: [PATCH v4 1/4] Fix child spawning closing standard fds prematurely.

2022-05-28 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c (renumber_file_descriptor): Refactor it as dup_handle_error. (dup_handle_error, dup2_handle_error): New functions that wrap around dup and dup2 by retrying on EINTR or EBUSY, as well as erroring out on other errors. (start_child): Close standard file descriptors only after all of

bug#52835: [PATCH v4 2/4] Avoid double closes in piped-process.

2022-05-28 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c (scm_piped_process): Avoid double closes. --- libguile/posix.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libguile/posix.c b/libguile/posix.c index e9f49fa27..155ad09b7 100644 --- a/libguile/posix.c +++ b/libguile/posix.c @@ -1475,12 +147

bug#52835: [PATCH v4 3/4] Remove useless closing code in start_child.

2022-05-28 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c (start_child): We're closing all fds anyway, no need to try to close some specific ones beforehand. --- libguile/posix.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libguile/posix.c b/libguile/posix.c index 155ad09b7..94a043cca 100644 --- a/libguile/posix.c +++ b/li

bug#52835: [PATCH v4 4/4] Make start_child propagate the child errno to the parent.

2022-05-28 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* configure.ac: Add AC_CHECK_FUNCS for pipe2. * libguile/posix.c (start_child): Use a pipe to transmit the child's errno to the parent, which can then use it to signal an error instead of writing to its error file descriptor. This also avoids the use of async-signal unsafe functions inside the chi

bug#52835: [PATCH v4 0/4] Improve safety of start_child and piped-process.

2022-05-28 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
retitle 52835 Improve safety of start_child and piped-process. thanks Hello everyone, This time, it's another Guix bug [1] that prompted me to have a closer look at piped-process and start_child, which don't seem to be very multi-thread safe. I've ended up with a couple of improvements that IMO

bug#56009: [PATCH] Clarify that patches are sent to the same email address as bug reports.

2022-06-15 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
--- website/apps/base/contribute-page.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/apps/base/contribute-page.scm b/website/apps/base/contribute-page.scm index 630f05c..2835b00 100644 --- a/website/apps/base/contribute-page.scm +++ b/website/apps/base/contribute-

bug#56632: [PATCH] srfi-19: fix 12AM in ~I and ~l

2022-07-18 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Fix 12AM showing up as 0. >From e9e084a8047ca9d189d8d751173196d906a1758f Mon Sep 17 00:00:00 2001 From: Nathan Borghese Date: Mon, 18 Jul 2022 00:01:08 -0400 Subject: [PATCH] srfi-19: fix ~I and ~l * module/srfi/srfi-19.scm (directives): fix 12AM in ~I and ~l --- module/srfi/srfi-19.scm | 17 +++

bug#57098: [PATCH] doc: Add car+cdr example

2022-08-09 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
--- doc/ref/srfi-modules.texi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/ref/srfi-modules.texi b/doc/ref/srfi-modules.texi index 7aeacd888..0ddd9a711 100644 --- a/doc/ref/srfi-modules.texi +++ b/doc/ref/srfi-modules.texi @@ -409,6 +409,13 @@ These are synonyms for @code{car}, @

bug#57145: [PATCH] Add xcons example

2022-08-11 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
--- doc/ref/srfi-modules.texi | 4 1 file changed, 4 insertions(+) diff --git a/doc/ref/srfi-modules.texi b/doc/ref/srfi-modules.texi index bce5b4eac..22a6f9844 100644 --- a/doc/ref/srfi-modules.texi +++ b/doc/ref/srfi-modules.texi @@ -262,6 +262,10 @@ Like @code{cons}, but with interchanged

bug#57145: [PATCH] Add xcons example

2022-08-12 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
On Fri, 12 Aug 2022 09:48:13 +0200 lloda wrote: > > Hi jgart, > > looks good, but could you do a patch for several of these at once? Sure, give me a few weeks and I'll send a bigger patch with more. Thanks for reviewing. BTW, I don't think the xcons example I sent is a good one. Do you happe

bug#52835: [PATCH v5 2/3] Add spawn*.

2022-09-04 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c: Include spawn.h from Gnulib. (scm_spawn_process): New function. (scm_init_popen): Define spawn*. --- libguile/posix.c | 71 1 file changed, 71 insertions(+) diff --git a/libguile/posix.c b/libguile/posix.c index f4ca72d3e..5d287

bug#52835: [PATCH v5 3/3] Move popen and posix procedures to spawn*.

2022-09-04 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c (renumber_file_descriptor, start_child, scm_piped_process): Remove functions. (scm_port_to_fd_with_default): New helper function. (scm_system_star): Rewrite using scm_spawn_process. (scm_init_popen): Remove the definition of piped-process. (scm_init_posix): Now make popen availab

bug#52835: [PATCH v5 0/3] Move spawning procedures to posix_spawn.

2022-09-04 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hi everyone, As was discussed on IRC, if we're going to rewrite a non-negligible part of posix.c, let's at least do it right and use posix_spawn to handle the process spawning side of things. This is quite complex to get right in general (highlighted by this very bug) and so people have already d

bug#57808: [PATCH] string-fun: Fix typo

2022-09-14 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
--- module/ice-9/string-fun.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/ice-9/string-fun.scm b/module/ice-9/string-fun.scm index 03e0238fa..592b49e20 100644 --- a/module/ice-9/string-fun.scm +++ b/module/ice-9/string-fun.scm @@ -30,7 +30,7 @@ ;;; -;;; Va

bug#35430: close

2022-09-21 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Was fixed January 2021 in 1b0da42672262426bca7bb58e70fb753c628ffc3

bug#55356: [PATCH] Always release thread data mutex in join-thread.

2022-10-16 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
From: Olivier Dion Currently the mutex is only unlocked when results are available. However, it is not unlocked when we get a timeout from the condition variable. * module/ice-9/threads.scm (join-thread): Use with-mutex to ensure that the thread data mutex is always unlocked. --- module/ice-9/t

bug#59055: [PATCH] Fix possible deadlock.

2022-11-05 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
If we got interrupted while waiting on our condition variable, we unlock the kernel mutex momentarily while executing asynchronous operations before putting us back into the waiting queue. However, we have to retry acquiring the mutex before getting back into the queue, otherwise it's possible tha

bug#59221: (file-exists? #f) raises an exception

2022-11-12 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hello you lovely guile people! This bug is so simple the subject line says it all! file-exists? is a predicate, but #+BEGIN_SRC scheme (file-exists? #f) ice-9/boot-9.scm:1685:16: In procedure raise-exception: In procedure stat: Wrong type argument in position 1 (expecting open file port): #f

bug#59221: (file-exists? #f) raises an exception

2022-11-12 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
November 12, 2022 12:58 PM, "Jean Abou Samra" wrote: >> Le 12 nov. 2022 à 18:50, Joshua Branson via Bug reports for GUILE, GNU's >> Ubiquitous Extension >> Language a écrit : >> >> Hello you lovely guile people! >> >> This bug is so si

bug#59221: (file-exists? #f) raises an exception

2022-11-16 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Jean Abou Samra writes: > Le 13/11/2022 à 07:44, to...@tuxteam.de a écrit : >> You both have a point. Checking for existing predicates with a >> longer tradition, though: >> >>scheme@(guile-user)> (exact? "mumble") >>ice-9/boot-9.scm:1685:16: In procedure raise-exception: >>In procedu

bug#59055: [PATCH] Fix possible deadlock.

2022-11-20 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
On Sun, 20 Nov 2022, Ludovic Courtès wrote: > Did you try to come up with a reproducer? That would be awesome but I > guess it’s hard because you need to trigger EINTR at the right point. With a stress test in guile-parallel. Very hard to reproduce indeed. You can also reproduce it with `ice-9

bug#59572: [PATCH] Fix minor typo.

2022-11-25 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hi, I'm new here.From efdb82fa7dc33c8b161a7783e11197c746a4959d Mon Sep 17 00:00:00 2001 From: Yuval Langer Date: Fri, 25 Nov 2022 13:04:28 +0200 Subject: [PATCH] Fix minor typo. --- doc/ref/api-data.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/ref/api-data.tex

bug#59646: [PATCH] Add short command for locals debug command.

2022-11-27 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
--- module/system/repl/command.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/system/repl/command.scm b/module/system/repl/command.scm index 0024fd165..4c4a667f3 100644 --- a/module/system/repl/command.scm +++ b/module/system/repl/command.scm @@ -61,7 +61,7 @@

bug#59646: [PATCH v2] Add short command for locals debug command.

2022-11-27 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
--- module/system/repl/command.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/system/repl/command.scm b/module/system/repl/command.scm index 0024fd165..d7257b5a1 100644 --- a/module/system/repl/command.scm +++ b/module/system/repl/command.scm @@ -61,7 +61,7 @@

bug#59647: [PATCH] Fix typos in docstrings.

2022-11-27 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/boolean.c (scm_not): Fix typo. (scm_boolean_p): Fix typo. --- libguile/boolean.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libguile/boolean.c b/libguile/boolean.c index e8370331f..930001a89 100644 --- a/libguile/boolean.c +++ b/libguile/boolean.c @@

bug#59874: Segfault from string-ref with negative 'k'

2022-12-07 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
hi, i noticed that if i, on my system, run "guile" from a shell and then type into the command prompt that appears, (string-ref "a string" -1) guile appears to hang for a few seconds or so, and then prints the message "Segmentation fault (core dumped)". i'm not really sure if this report is w

bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly

2022-12-11 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hi Ludo, Ludovic Courtès writes: > For top-level functions, please add a comment above explaining what it > does. Completely forgot about that. I will do it at some point, however we will need to settle on how to resolve the issue at the bottom first. > I would call this one ‘primitive-spawn

bug#52835: [PATCH v6 1/3] Add spawn*.

2022-12-22 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c: Include spawn.h from Gnulib. (do_spawn, scm_spawn_process): New functions. --- libguile/posix.c | 81 libguile/posix.h | 2 ++ 2 files changed, 83 insertions(+) diff --git a/libguile/posix.c b/libguile/posix.c index b5352c2c4..

bug#52835: [PATCH v6 3/3] Move popen and posix procedures to spawn*.

2022-12-22 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c (scm_piped_process, scm_init_popen): Remove functions. (scm_port_to_fd_with_default): New helper function. (scm_system_star): Rewrite using scm_spawn_process. (scm_init_popen): Remove the definition of piped-process. (scm_init_posix): Now make popen available unconditionally. *

bug#52835: [PATCH v6 2/3] Make system* and piped-process internally use spawn.

2022-12-22 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c (scm_system_star, scm_piped_process): Use do_spawn. (start_child): Remove function. --- libguile/posix.c | 181 ++- 1 file changed, 39 insertions(+), 142 deletions(-) diff --git a/libguile/posix.c b/libguile/posix.c index e92625483..f

bug#52835: [PATCH v6 0/3] Move spawning procedures to posix_spawn.

2022-12-22 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hello Ludo, Here is hopefully the last reroll of this patchset. First of all, I did not include the gnulib patch again because it still applies cleanly and it is extremely large, but it should be applied before those 3 patches. The first two patches should be applied on the current major release

bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly

2022-12-23 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hi Ludo, thanks for the quick review and fixes. > I pushed it to ‘wip-posix-spawn’ along with fixups I’m proposing, mostly > along the lines of what I suggested in > : Nice but also see below. > I also added Andrew Whatson’s patch from >

bug#52835: [PATCH v7 2/2] Make system* and piped-process internally use spawn.

2022-12-23 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c (scm_system_star, scm_piped_process): Use do_spawn. (start_child): Remove function. Co-authored-by: Ludovic Courtès --- libguile/posix.c | 233 --- 1 file changed, 78 insertions(+), 155 deletions(-) diff --git a/libguile/posix.c b/l

bug#52835: [PATCH v7 1/2] Add spawn* and spawn.

2022-12-23 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c: Include spawn.h from Gnulib. (do_spawn, scm_spawn_process): New functions. * module/ice-9/spawn.scm: New file (spawn): New procedure. --- libguile/posix.c | 82 ++ libguile/posix.h | 2 ++ module/ice-9/spawn.scm | 54

bug#52835: [PATCH v8 2/2] Make system* and piped-process internally use spawn.

2023-01-07 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c (scm_system_star, scm_piped_process): Use do_spawn. (start_child): Remove function. Co-authored-by: Ludovic Courtès --- libguile/posix.c | 231 --- 1 file changed, 77 insertions(+), 154 deletions(-) diff --git a/libguile/posix.c b/l

bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly

2023-01-07 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hi Ludo, Happy new year! Ludovic Courtès writes: > ‘spawn*’ is expressive enough, but a procedure with 6 positional > arguments cannot be exposed as-is IMO. > > One tiny thing that’s missing is a boolean to choose between > ‘posix_spawn’ and ‘posix_spawnp’. > > So we need either ‘spawn’ defined

bug#52835: [PATCH v8 1/2] Add spawn.

2023-01-07 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/posix.c: Include spawn.h from Gnulib. (do_spawn, scm_spawn_process): New functions. --- doc/ref/posix.texi | 34 -- libguile/posix.c | 162 - libguile/posix.h | 1 + 3 files changed, 192 insertions(+), 5 deletions(-) diff --git

bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly

2023-01-13 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hello Josselin & Ludo, Thanks for your work on this, posix_spawn is a nice improvement! My comments on the changes in the wip-posix-spawn branch follow. In doc/ref/posix.texi: @quotation Note If you are only looking to fork+exec with some pipes set up, using pipes or the more @code{spawn} p

bug#60928: [PATCH] bugfix/make_hash_table: fix segfault when arg< 0 for make-hash-table

2023-01-18 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
* libguile/hashtab.c (make_hash_table): FIX SEGMENTATION FAULT Currently on Guix if a user evokes (make-hash-table arg) where arg < 0, guile segfaults. This patch adds the most straight forward solution, checking if the value passed to make-hash-table is less than 0, and if so, throwing an error w

bug#60928: [PATCH] bugfix/make_hash_table: fix segfault when arg< 0 for make-hash-table

2023-01-19 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
lloda writes: > It seems this is the same bug as https://bugs.gnu.org/60488 and > https://bugs.gnu.org/58154, at least it doesn't segfault in main > anymore. oh sorry about the false patch then, I had searched my local repo for commits containing the word segfault and didn't find any mention,

bug#61058: [PATCH] Fix asymetric mutex locking when joining thread.

2023-01-25 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
From: Olivier Dion If `join-thread' timeout, the thread mutex is not unlocked, resulting in deadlock to the next call to it or deadlock of the thread itself when it terminates. Thus, always unlock the mutex. Fix: #55356 * module/ice-9/threads.scm (join-thread): Always unlock thread mutex. ---

bug#62053: Guile compiler is unable to compile tiny program

2023-03-08 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Guile compiler is unable to compile tiny program:   (define (fn l)     (define (ok l)    (or (and (pair? l) l)    (error "list is empty")))     (cons (reverse (car l)) (ok l)))   amaya@picasso:~/tmp/guile-3.0.9 $ ../prefix/bin/guile ~/tmp/guile-compiler-bug.scm ;;; note: auto-compilati

bug#62456: [PATCH] Fix typo.

2023-03-26 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
--- libguile/list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libguile/list.c b/libguile/list.c index 82aab8a5d..cd05e77b8 100644 --- a/libguile/list.c +++ b/libguile/list.c @@ -224,7 +224,7 @@ SCM_DEFINE (scm_length, "length", 1, 0, 0, SCM_DEFINE (scm_append, "append"

bug#61095: possible misuse of posix_spawn API on non-linux OSes

2023-03-28 Thread Bug reports for GUILE, GNU&#x27;s Ubiquitous Extension Language
Hi Ludo, Ludovic Courtès writes: > - posix_spawn_file_actions_addclose (actions, fd); > + /* Adding invalid file descriptors to an 'addclose' action leads > + to 'posix_spawn' failures on some operating systems: > + . Hence the extra check.

  1   2   >