[bug #63018] [PATCH] make glyphs in ZD font accessible via their Unicode spellings

2024-08-21 Thread Dave
Follow-up Comment #41, bug #63018 (group groff): [comment #39 comment #39:] > Here are the changes to "afmtodit.pl". Of the three calls to new subroutine whine(), two are invoked with the & prefix and one without. Is this intentional? ___

[bug #66079] [troff] uninitialized local `s` potentially used in `token::add_to_zero_width_node_list()`

2024-08-21 Thread Lukas Javorsky
Follow-up Comment #4, bug #66079 (group groff): Sorry, I attached the wrong .second patch. Now attaching the right one. (file #56372) ___ Additional Item Attachment: File name: 0005-Initialize-s-to-prevent-undefined-behavior.second.patch

[bug #66052] [troff] possible 1-byte stack overwrite, heap overread

2024-08-21 Thread Lukas Javorsky
Follow-up Comment #6, bug #66052 (group groff): Looking at the commit 568beeb2efed5299868585c9bf3c700413cf1a12, isn't there a typo where you made the change: - int num[WORD_MAX + 3]; + int num[WORD_MAX + 2 + 1]; Shouldn't it be: - int num[WORD_MAX + 3]; + int num

[bug #66079] [troff] uninitialized local `s` potentially used in `token::add_to_zero_width_node_list()`

2024-08-21 Thread G. Branden Robinson
Follow-up Comment #5, bug #66079 (group groff): [comment #4 comment #4:] > Sorry, I attached the wrong .second patch. Now attaching the right one. > > (file #56372) Thanks. I see. That's a separate issue; these are two unrelated local variables called `s`. From c19274b6ec048aa8c9d5e78bec2260

[bug #66079] [troff] uninitialized local `s` potentially used in `token::add_to_zero_width_node_list()`

2024-08-21 Thread G. Branden Robinson
Follow-up Comment #6, bug #66079 (group groff): Hi Lukas, In your second patch, there is no use of an uninitialized value; nothing ever dereferences `s`. This is true even though it is later written to. However, the variable needs to exist because the API demands a dead store here, so I'm chang

[bug #63018] [PATCH] make glyphs in ZD font accessible via their Unicode spellings

2024-08-21 Thread G. Branden Robinson
Follow-up Comment #42, bug #63018 (group groff): [comment #41 comment #41:] > [comment #39 comment #39:] > > Here are the changes to "afmtodit.pl". > > Of the three calls to new subroutine whine(), two are invoked with the & prefix and one without. Is this intentional? Nope. Fixed in my worki

[bug #63018] [PATCH] make glyphs in ZD font accessible via their Unicode spellings

2024-08-21 Thread G. Branden Robinson
Follow-up Comment #43, bug #63018 (group groff): commit 12c0f8a0b8df51085ce862d232ffc020ac7a5d26 Author: G. Branden Robinson Date: Tue Aug 20 10:17:25 2024 -0500 tmac/fallbacks.tmac: Define fallback for U+2717. * tmac/fallbacks.tmac: Define fallback character for U+2717 "BALLOT X

[bug #63018] [PATCH] make glyphs in ZD font accessible via their Unicode spellings

2024-08-21 Thread Deri James
Follow-up Comment #44, bug #63018 (group groff): [comment #39 comment #39:] > Hi Deri, > > The comment fields for the glyphs in the ZD font description file don't seem to be accurate. They don't look like correct Unicode correspondences to me. Or at least most don't. > Hi Dave, No, it does n

[bug #63018] [PATCH] make glyphs in ZD font accessible via their Unicode spellings

2024-08-21 Thread G. Branden Robinson
Follow-up Comment #45, bug #63018 (group groff): [comment #44 comment #44:] > > [comment #39 comment #39:] > > Hi Deri, > > > > The comment fields for the glyphs in the ZD font description file don't seem to be accurate. They don't look like correct Unicode correspondences to me. Or at least m

[bug #66114] [gropdf] support embedding bit-mapped image files into a PDF

2024-08-21 Thread Deri James
Follow-up Comment #10, bug #66114 (group groff): My comment concerning the lack of anything which exercises PDFPIC, was just to a nod that I should provide a test document which exercises various aspects of PDFPIC. Would you like me to create such a document? It would be a bit different to your t

[bug #66114] [gropdf] support embedding bit-mapped image files into a PDF

2024-08-21 Thread G. Branden Robinson
Follow-up Comment #11, bug #66114 (group groff): [comment #10 comment #10:] > My comment concerning the lack of anything which exercises PDFPIC, was just to a nod that I should provide a test document which exercises various aspects of PDFPIC. Would you like me to create such a document? Hi Deri,

[bug #66114] [gropdf] support embedding bit-mapped image files into a PDF

2024-08-21 Thread Deri James
Follow-up Comment #12, bug #66114 (group groff): The presence/absence of embedded images can be derived from capturing warnings during the run. This will inform if file/identify/pdfinfo (assuming some of them are accessible) has failed, but it is only through opening the pdf that you can be sure g

[bug #63018] [PATCH] make glyphs in ZD font accessible via their Unicode spellings

2024-08-21 Thread Dave
Follow-up Comment #46, bug #63018 (group groff): [comment #43 comment #43:] > *"before any mounted special fonts"* > > But what if we want an even-farther-fallback for when even > mounted special fonts come up dry? I have some homework to > understand why this was thought unnecessary. Or how to

[bug #63018] [PATCH] make glyphs in ZD font accessible via their Unicode spellings

2024-08-21 Thread Deri James
Update of bug #63018 (group groff): Status: Need Info => In Progress Assigned to:deri => gbranden ___ Follow-up Comment #47: Hi Branden, Yes, that

[bug #66079] [troff] uninitialized local `s` potentially used in `token::add_to_zero_width_node_list()`

2024-08-21 Thread G. Branden Robinson
Follow-up Comment #7, bug #66079 (group groff): commit 57965bfdc322ef244aaff84a1b20e1b1974d411a Author: G. Branden Robinson Date: Wed Aug 21 07:24:55 2024 -0500 src/roff/troff/env.cpp: Fix code style nit. * src/roff/troff/env.cpp (environment::add_char): Declare local variable

[bug #65697] Add info to comment headers of font description files groff tools generate

2024-08-21 Thread G. Branden Robinson
Update of bug #65697 (group groff): Status:None => In Progress Assigned to:None => gbranden ___ Follow-up Comment #1: commit 66df2be1a90c88e

[bug #63018] [PATCH] make glyphs in ZD font accessible via their Unicode spellings

2024-08-21 Thread G. Branden Robinson
Update of bug #63018 (group groff): Status: In Progress => Fixed Open/Closed:Open => Closed Planned Release:None => 1.24.0 __

[bug #63018] [PATCH] [devps] make glyphs in ZD font accessible via their Unicode spellings

2024-08-21 Thread G. Branden Robinson
Update of bug #63018 (group groff): Summary: [PATCH] make glyphs in ZD font accessible via their Unicode spellings => [PATCH] [devps] make glyphs in ZD font accessible via their Unicode spellings ___ Reply to this item at:

[bug #65762] configure check has erroneous code

2024-08-21 Thread G. Branden Robinson
Update of bug #65762 (group groff): Category:Core => General ___ Reply to this item at: ___ Message

[bug #65929] doc/groff.texi.in: .linetabs example input has vestigial line

2024-08-21 Thread G. Branden Robinson
Update of bug #65929 (group groff): Summary: groff.texi.in: .linetabs example input has vestigial line => doc/groff.texi.in: .linetabs example input has vestigial line ___ Reply to this item at:

[bug #64954] doc/groff.texi: spelling errors found by "codespell"

2024-08-21 Thread G. Branden Robinson
Update of bug #64954 (group groff): Summary: groff.texi: spelling errors found by "codespell" => doc/groff.texi: spelling errors found by "codespell" ___ Reply to this item at: __

[bug #64758] doc/groff.texi: accommodate old hyperlinks to groff Texinfo manual

2024-08-21 Thread G. Branden Robinson
Update of bug #64758 (group groff): Summary: accommodate old hyperlinks to groff Texinfo manual => doc/groff.texi: accommodate old hyperlinks to groff Texinfo manual ___ Reply to this item at:

[bug #65762] configure check has erroneous code

2024-08-21 Thread Eli Schwartz
Follow-up Comment #2, bug #65762 (group groff): Hmm, partially? :) There is another issue -- it uses exit() and needs to #include as one of the headers in the first argument to AC_LANG_PROGRAM, but does not. ___ Reply to this item at:

[bug #62776] [troff] want "style" warning category for self-deceptive inputs

2024-08-21 Thread G. Branden Robinson
Follow-up Comment #20, bug #62776 (group groff): * Warn when a numeric expression in a conditional is followed by something other than whitespace. $ echo '.if \na<3cm .tm more than 3 centimeters' | nroff -Wreg | cat -s m .tm more than 3 centimeters ___

[bug #65762] m4/groff.m4: GROFF_WCOREFLAG has erroneous code

2024-08-21 Thread G. Branden Robinson
Update of bug #65762 (group groff): Summary: configure check has erroneous code => m4/groff.m4: GROFF_WCOREFLAG has erroneous code ___ Follow-up Comment #3: [comment #2 comment #2:] > Hmm, partially? :) > > There is anot

[bug #62776] [troff] want "style" warning category for self-deceptive inputs

2024-08-21 Thread G. Branden Robinson
Follow-up Comment #21, bug #62776 (group groff): [comment #20 comment #20:] > $ echo '.if \na<3cm .tm more than 3 centimeters' | nroff -Wreg | cat -s > m .tm more than 3 centimeters s/more/less/g I R UH VERY GOOD PROGRAMMR ___ Reply t

[bug #65954] [troff] next-generation alignment and adjustment control

2024-08-21 Thread G. Branden Robinson
Update of bug #65954 (group groff): Status:None => In Progress Assigned to:None => gbranden ___ Reply to this item at: