Follow-up Comment #45, bug #63018 (group groff): [comment #44 comment #44:] > > [comment #39 comment #39:] > > Hi Deri, > > > > The comment fields for the glyphs in the ZD font description file don't seem to be accurate. They don't look like correct Unicode correspondences to me. Or at least most don't. > > > Hi Dave,
Comment #39 was me, too. :)
> No, it does not look correct, I suspect you did not use the dingbats.map
file attached to this bug.
Okay, that explains the pattern I've seen.
> In comment #43 Branden reports he is now seeing the BALLOT X glyph, so
either he is using the ZD font I provided, or he ran afmtodit with the new
dingbats.map.
Yes.
Here are the commits I have queued up in my working copy, in forward commit
order.
commit 366bbf358b11d9c2d4f7b1780f5aa8f6cf7c2db1
Author: G. Branden Robinson <g.branden.robin...@gmail.com>
Date: Wed Aug 21 08:52:58 2024 -0500
Revert "tmac/fallbacks.tmac: Define fallback for U+2717."
This reverts commit 12c0f8a0b8df51085ce862d232ffc020ac7a5d26.
`fchar` is not the right remedy for the scenario I had in mind. Oddly,
`schar` might not be, either.
commit 179e896e1f8f0de675d5943f6b0ed105efb0f654
Author: G. Branden Robinson <g.branden.robin...@gmail.com>
Date: Wed Aug 21 08:02:25 2024 -0500
src/utils/afmtodit/afmtodit.pl: Refactor (1/4).
* src/utils/afmtodit/afmtodit.pl: Define `prog` scalar as only the
"basename" of argv[0], making diagnostic and usage messages less
garrulous; see Savannah #65110.
commit 44b9700a0e892059ac4d6c6284468e845801cecf
Author: G. Branden Robinson <g.branden.robin...@gmail.com>
Date: Wed Aug 21 08:06:13 2024 -0500
src/utils/afmtodit/afmtodit.pl: Refactor (2/4).
* src/utils/afmtodit/afmtodit.pl: Add new `opt_w` scalar to separate it
from existing `space_width` scalar so that we can report the options
we were invoked with in a comment in the generated file.
commit 1141fe44a8dd95813745e6445baf59203d0bdd1a
Author: G. Branden Robinson <g.branden.robin...@gmail.com>
Date: Wed Aug 21 08:11:29 2024 -0500
src/utils/afmtodit/afmtodit.pl: Refactor (3/4).
* src/utils/afmtodit/afmtodit.pl: Reorganize scalar representation of
version information: new `groff_version`, which is populated at build
time, new `short_version` which is `groff_version` stripped of any Git
revision and partial hash information; new `version_stub` which holds
the prefixed information identifying the program and project; new
`output_version` which holds the stub and the short version; and
existing `afmtodit_version`, which holds the stub and the (full) groff
version. Write `output_version` instead of `afmtodit_version` to the
generated file.
commit 647856053a46e0e29b1ca8d0bb62a0021250b6a1
Author: G. Branden Robinson <g.branden.robin...@gmail.com>
Date: Wed Aug 21 08:15:26 2024 -0500
src/utils/afmtodit/afmtodit.pl: Refactor (4/4).
* src/utils/afmtodit/afmtodit.pl: Update call sites of `croak` and new
`whine` subroutines to use `&` sigil and omit trailing newline.
(croak): Assume responsibility for writing a newline at the end of the
message.
(whine): New subroutine throws a diagnostic marked "warning". Perl's
`warn` output is ugly and not structured like other groff diagnostics.
Give it responsibility for emitting the name of the program.
commit 65d5d2e6d4af0f58ad369788ac653aa2b9c492cf
Author: G. Branden Robinson <g.branden.robin...@gmail.com>
Date: Wed Aug 21 08:20:53 2024 -0500
[afmtodit]: Improve generated comments.
* src/utils/afmtodit/afmtodit.pl: Improve information written to
generated font description files in comments. Name the AFM and map
files used. Report any options specified on the command line. The
idea is to make it easier for future (and current) maintainers to
update such files because years pass between occurrences, and
institutional memory is, if not lost, laborious to dredge up. This
practice might also assist users in producing groff description files
for their own fonts. Also write out a glyph's corresponding Unicode
code point in the comment field only if one is defined. Otherwise we
get a comment marker followed by a tab and a newline, which Git marks
in radioactive red.
commit c4e48771fb53ba8f393bf63f3de7a6a7225642ad
Author: G. Branden Robinson <g.branden.robin...@gmail.com>
Date: Wed Aug 21 07:25:44 2024 -0500
font/devps/ZD: Regenerate using updated afmtodit.
No changes to font description data relative to Werner's commit
7a7ef828ef, 19 May 2010.
This reverts Deri's commit 98b0c1db4, 12 April, but only temporarily in
effect. The reason is to prove the foregoing equivalence.
See <https://savannah.gnu.org/bugs/?63018>.
commit e831086c82d7b17a0ec16efe99836e30f8473747
Author: Deri James <d...@chuzzlewit.myzen.co.uk>
Date: Mon Apr 29 17:00:15 2024 +0000
font/devps/generate/dingbats.map: Update.
...to map many more Unicode code points to Zapf Dingbats glyphs.
commit d5be30ad67f3d1d41e9cd2976919f2bb4666d642
Author: G. Branden Robinson <g.branden.robin...@gmail.com>
Date: Wed Aug 21 08:30:41 2024 -0500
font/devps/generate/dingbats.map: Drop 2 mappings.
afmtodit complains.
afmtodit: warning: you are not allowed to map the PostScript character
'space'
afmtodit: warning: you are not allowed to map the PostScript character
'space'
(It'd be nice if afmtodit identified the file name and line number it
was complaining about...)
commit ca20c8375d3cc393041db141ab7deddd94d926ca (HEAD -> master)
Author: G. Branden Robinson <g.branden.robin...@gmail.com>
Date: Wed Aug 21 08:40:27 2024 -0500
font/devps/ZD: Regen from updated dingbats.map.
* font/devps/ZD: Regenerate using updated dingbats.map.
Fixes <https://savannah.gnu.org/bugs/?63018>. Thanks to Deri James and
Dave Kemper for (extensive) consultation.
Does this look okay to you?
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?63018>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
Description: PGP signature
