compile warnings when including avltree-list and gcc-warnings is enabled

2014-09-05 Thread Dylan Cali
Hello, After adding a couple gnulib modules to coreutils I get several warnings. As a result, make fails since -Werror is enabled by default. If I configure with --disable-gcc-warnings then the warnings go away. The culprit seems to be avltree-list: diff --git bootstrap.conf bootstrap.conf ind

Re: compile warnings when including avltree-list and gcc-warnings is enabled

2014-09-05 Thread Dylan Cali
Sure, I'll take a look when I have a moment. Thanks, Dylan On Fri, Sep 5, 2014 at 10:51 AM, Paul Eggert wrote: > Thanks, it looks like some declarations are missing in the corresponding .h > file, or are missing attributes that they should have. Is that something > you could write a patch for?

Re: compile warnings when including avltree-list and gcc-warnings is enabled

2014-09-06 Thread Dylan Cali
78c4c3c Mon Sep 17 00:00:00 2001 From: Dylan Cali Date: Sat, 6 Sep 2014 01:52:31 -0500 Subject: [PATCH] build: fix attribute and declaration warnings * tests/test-avltree_list.c: Remove gl_avltree_list_check_invariants declaration * lib/gl_avltree_list.h: Add gl_avltree_list_check_invar

Re: compile warnings when including avltree-list and gcc-warnings is enabled

2014-09-06 Thread Dylan Cali
gt; I suppose a pragma is the way to silence the unwanted diagnostics, yes. Updated patch attached. I moved the declaration to the .c file and added the warning suppression for just that function. Everything builds without issue now. From d8f6449d69401a820c4b3f5d45cee8c87063618c Mon Sep 17 00:00

Re: compile warnings when including avltree-list and gcc-warnings is enabled

2014-09-08 Thread Dylan Cali
On Sep 8, 2014 9:27 AM, "Eric Blake" wrote: > Does this work for all supported versions of gcc? Or do you need to make > it conditional on new enough gcc (it's okay if warnings have to be > disabled to compile with older gcc, but not okay if the way to disable > warnings for newer gcc causes compi

Re: compile warnings when including avltree-list and gcc-warnings is enabled

2014-09-08 Thread Dylan Cali
On Mon, Sep 8, 2014 at 10:04 AM, Dylan Cali wrote: > On Sep 8, 2014 9:27 AM, "Eric Blake" wrote: >> Does this work for all supported versions of gcc? Or do you need to make >> it conditional on new enough gcc (it's okay if warnings have to be >> disabled to