On Sep 8, 2014 9:27 AM, "Eric Blake" <ebl...@redhat.com> wrote: > Does this work for all supported versions of gcc? Or do you need to make > it conditional on new enough gcc (it's okay if warnings have to be > disabled to compile with older gcc, but not okay if the way to disable > warnings for newer gcc causes compilation failure in older gcc).
Yep you're right, looking at some other code of mine I have a conditional checking for gcc > 3.7 before doing the push/pop, so it looks like that is the min version for this pragma. So wrap the pragma in a conditional, and add a conditional in the Makefile turning off warnings altogether for gcc <= 3.7?
