Hi Paul,
> * modules/regex (Depends-on): Remove gettext-h and lock,
> since the regex code should work OK without these modules,
> and Emacs uses it that way.
The removal of the gettext-h dependency is fine; regex_internal.h
tests ENABLE_NLS and includes .
But I object against the removal of the
Thanks for the detailed review, and you're right on all counts. I installed the
attached to do the fixes you suggest.
I'm still having trouble with the regex code under Emacs, and will try to follow
up shortly.
>From e09e64c7e0d3c9d0cca82cb80713f8aea195d493 Mon Sep 17 00:00:00 2001
From: Paul E
Jim Meyering wrote:
Subject: [PATCH] bootstrap: s/--option val/--option=val/
Thanks, that looks good to me. (I had run into the same problem but was hoping
someone else would have time to look into it)
Reuben Thomas wrote:
I find them useful and switch them on, but given that others disagree, I
like your suggestion as it makes things consistent, and less likely to
confuse those who share my taste.
OK, thanks, no further comment so I installed the attached.
From f24fbe9d9297f57b632fbefd87770
On Sun, Jul 1, 2018 at 6:42 AM, Paul Eggert wrote:
> Jim Meyering wrote:
>
>> Subject: [PATCH] bootstrap: s/--option val/--option=val/
>
> Thanks, that looks good to me. (I had run into the same problem but was
> hoping someone else would have time to look into it)
Thanks. Pushed.
* lib/getloadavg.c: Only define WINDOWS32 if it's not already defined.
---
lib/getloadavg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/getloadavg.c b/lib/getloadavg.c
index 435d10a..578316e 100644
--- a/lib/getloadavg.c
+++ b/lib/getloadavg.c
@@ -97,7 +97,7 @@
# inc
Thanks. I installed that.
I discovered this when looking into using the regex module
with Emacs.
* m4/wchar_h.m4 (gl_WCHAR_H_INLINE_OK): Fix bug introduced in
2016-08-17T23:09:38Z!sk...@iskunk.org; the code compiled
conftest1.c and conftest2.c but these files were not created.
As far as I can see, this check never worked an
