Re: [PATCH] regex: trim module dependencies

[Paul Eggert]

Thanks for the detailed review, and you're right on all counts. I installed the 
attached to do the fixes you suggest.

I'm still having trouble with the regex code under Emacs, and will try to follow 
up shortly.
>From e09e64c7e0d3c9d0cca82cb80713f8aea195d493 Mon Sep 17 00:00:00 2001
From: Paul Eggert <egg...@cs.ucla.edu>
Date: Sun, 1 Jul 2018 06:37:38 -0700
Subject: [PATCH] regex: revert most trimming
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Problems reported by Bruno Haible in:
https://lists.gnu.org/r/bug-gnulib/2018-07/msg00001.html
* modules/regex (Depends-on): Add lock, memcmp, memmove,
and wctype back in.  lock because regex users shouldn’t
need to know that regex needs locking, and the rest because
gnulib-tool should ordinarily ignore them anyway.
---
 ChangeLog     | 10 ++++++++++
 modules/regex |  4 ++++
 2 files changed, 14 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index e25f5a7..4e9f441 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2018-07-01  Paul Eggert  <egg...@cs.ucla.edu>
+
+	regex: revert most trimming
+	Problems reported by Bruno Haible in:
+	https://lists.gnu.org/r/bug-gnulib/2018-07/msg00001.html
+	* modules/regex (Depends-on): Add lock, memcmp, memmove,
+	and wctype back in.  lock because regex users shouldn’t
+	need to know that regex needs locking, and the rest because
+	gnulib-tool should ordinarily ignore them anyway.
+
 2018-06-30  Paul Eggert  <egg...@cs.ucla.edu>
 
 	regex: trim module dependencies
diff --git a/modules/regex b/modules/regex
index 8a6afcb..8863a8e 100644
--- a/modules/regex
+++ b/modules/regex
@@ -20,6 +20,9 @@ alloca-opt      [test $ac_use_included_regex = yes]
 btowc           [test $ac_use_included_regex = yes]
 builtin-expect  [test $ac_use_included_regex = yes]
 intprops        [test $ac_use_included_regex = yes]
+lock      [test "$ac_cv_gnu_library_2_1:$ac_use_included_regex" = no:yes]
+memcmp          [test $ac_use_included_regex = yes]
+memmove         [test $ac_use_included_regex = yes]
 mbrtowc         [test $ac_use_included_regex = yes]
 mbsinit         [test $ac_use_included_regex = yes]
 nl_langinfo     [test $ac_use_included_regex = yes]
@@ -28,6 +31,7 @@ stdint          [test $ac_use_included_regex = yes]
 wchar           [test $ac_use_included_regex = yes]
 wcrtomb         [test $ac_use_included_regex = yes]
 wctype-h        [test $ac_use_included_regex = yes]
+wctype          [test $ac_use_included_regex = yes]
 
 configure.ac:
 gl_REGEX
-- 
2.7.4