Re: bugs in dirname module

2005-11-09 Thread Bruno Haible
Eric Blake wrote: > > Why not use this instead? > > > > #define c_isalpha(c) (((unsigned int) (c) | ('a' - 'A')) - 'a' <= 'z' - > > 'a') > > This is a slick definition, but it is different than what c-ctype.h > provided, and that definition was not guarded. Bruno, would you accept > the following

Re: xstrtoimax compilation warning on Solaris 7

2005-11-09 Thread Larry Jones
Eric Blake writes: > > But C89 does not have long long - what does the standard say about > literals that exceed long? They have type unsigned long. (Similarly, C99 says that unsuffixed decimal literals that are too big to fit in long long have type unsigned long long.) -Larry Jones I don't wa

Re: namespace conflict for des

2005-11-09 Thread Paul Eggert
Simon Josefsson <[EMAIL PROTECTED]> writes: > The interface seem somewhat inefficient, because you can't do a > "setkey" operation and then use the scheduled key for several > operations. It has a strange license: > > * Sun RPC is a product of Sun Microsystems, Inc. and is provided for > * unre

Re: bugs in dirname module

2005-11-09 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: >> An alternative to editing c-ctype is naming the dirname.h version >> IS_DRIVE_LETTER instead of c_isalpha. > > Yes, this is much better. Also it reflects more closely what the macro is > used for. I also agree; sorry, I should have said it that way orig

Re: xstrtoimax compilation warning on Solaris 7

2005-11-09 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > But C89 does not have long long - what does the standard say about > literals that exceed long? They're of type unsigned long if they fit, and they're an error otherwise. GCC has long long as an extension, so it handles them as long long if they fit, unsi

readline fix

2005-11-09 Thread Simon Josefsson
Is this right? I'm not sure what a portable way to remove EOL is. Anyway, I installed this because it work on known platforms. 2005-11-10 Simon Josefsson <[EMAIL PROTECTED]> * readline.c: Remove EOL. --- readline.c 20 Sep 2005 11:12:16 +0200 1.2 +++ readline.c 10 Nov 2005 03

Re: bugs in dirname module

2005-11-09 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paul Eggert on 11/9/2005 2:19 PM: > > However: what happens in DOS if you use a file name like "@:/a/b/c"? In DOS, : is an invalid character, so the file name is outright rejected when passed to a function that actually visits the disk.

Re: readline fix

2005-11-09 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Simon Josefsson on 11/9/2005 7:17 PM: > Is this right? I'm not sure what a portable way to remove EOL is. > Anyway, I installed this because it work on known platforms. The concept is correct (the full-blown readline library does indeed