-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 1/15/2009 3:26 AM:
>> # _AC_LANG_OPENMP(C)
>> # --
>> -m4_define([_AC_LANG_OPENMP([C])],
>> +m4_define([_AC_LANG_OPENMP(C)],
>
> Is this change really necessary?
Yes. The _AC_LANG macros are _non-litera
Bruno Haible wrote:
> Simon Josefsson wrote:
>> > If "C" must not be quoted, then shouldn't the quotes
>> > around "C++" be dropped, too?
>>
>> I suppose, but I cannot trigger a problem.
>
> So, everyone is modifying this file based on guesswork? Stop, please.
>
> I wrote openmp.m4, incorporating
Simon Josefsson wrote:
> Jim Meyering writes:
>
>>> AC_DEFUN([_AC_LANG_OPENMP],
>>> -[_AC_LANG_DISPATCH([$0], [_AC_LANG], [...@])])
>>> +[_AC_LANG_DISPATCH([$0], _AC_LANG, [...@])])
>>
>> This one makes sense.
>> It fails on etch because it has autoconf < 2.62,
>> so the otherwise if'd out defin
Bruno Haible writes:
> Simon Josefsson wrote:
>> > If "C" must not be quoted, then shouldn't the quotes
>> > around "C++" be dropped, too?
>>
>> I suppose, but I cannot trigger a problem.
>
> So, everyone is modifying this file based on guesswork? Stop, please.
>
> I wrote openmp.m4, incorporati
Simon Josefsson wrote:
> > If "C" must not be quoted, then shouldn't the quotes
> > around "C++" be dropped, too?
>
> I suppose, but I cannot trigger a problem.
So, everyone is modifying this file based on guesswork? Stop, please.
I wrote openmp.m4, incorporating magic from autoconf that I don't
Jim Meyering writes:
>> AC_DEFUN([_AC_LANG_OPENMP],
>> -[_AC_LANG_DISPATCH([$0], [_AC_LANG], [...@])])
>> +[_AC_LANG_DISPATCH([$0], _AC_LANG, [...@])])
>
> This one makes sense.
> It fails on etch because it has autoconf < 2.62,
> so the otherwise if'd out definition in openmp.m4 is used.
> The
Simon Josefsson wrote:
> Hi Jim. The patch breaks openmp on debian etch. The patch below fixes
> it, but maybe the remaining quoting also cause problems if you use
> fortran (I don't know how to test that).
Hi Simon,
Nice catch.
> gnu...@mejsel:~$ gnulib-tool --test --with-tests openmp
...
>
Hi Jim. The patch breaks openmp on debian etch. The patch below fixes
it, but maybe the remaining quoting also cause problems if you use
fortran (I don't know how to test that).
gnu...@mejsel:~$ gnulib-tool --test --with-tests openmp
Module list with included dependencies:
openmp
File list:
Eric Blake wrote:
> > What's the rationale of quoting purely numeric m4 arguments, like in
> >AC_DEFINE([FOO], [1], ...) ?
> > It looks a bit like clutter to me, since quoting does not matter here. But
> > if you and Eric and Simon are willing to do this purely for consistency,
> > I'm going w
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 1/13/2009 2:26 PM:
> What's the rationale of quoting purely numeric m4 arguments, like in
>AC_DEFINE([FOO], [1], ...) ?
> It looks a bit like clutter to me, since quoting does not matter here. But
> if you and Eric and
Bruno Haible writes:
> Hi Jim,
>
>> I'm about to apply the changes induced by the above commands.
>
> What's the rationale of quoting purely numeric m4 arguments, like in
>AC_DEFINE([FOO], [1], ...) ?
> It looks a bit like clutter to me, since quoting does not matter here. But
> if you and E
Bruno Haible wrote:
>> I'm about to apply the changes induced by the above commands.
>
> What's the rationale of quoting purely numeric m4 arguments, like in
>AC_DEFINE([FOO], [1], ...) ?
> It looks a bit like clutter to me,
Initially I didn't do it, for just that reason,
but once Eric sugge
Hi Jim,
> I'm about to apply the changes induced by the above commands.
What's the rationale of quoting purely numeric m4 arguments, like in
AC_DEFINE([FOO], [1], ...) ?
It looks a bit like clutter to me, since quoting does not matter here. But
if you and Eric and Simon are willing to do this
Jim Meyering wrote:
> Jim Meyering wrote:
>> FYI, now I'm looking at the changes induced by the following:
>>
>> git ls-files | grep '\.m4$' | xargs perl -pi \
>> -e 's/(AC_[A-Z_]+\()([^[()]+?)([,)])/$1\[$2]$3/g;' \
>> -e 's/(AC_[A-Z_]+\((?:\[[^,]+?\], ){1})([^,[()]+?)([,)])/$1\[$2]$3/g
FYI, now I'm looking at the changes induced by the following:
git ls-files | grep '\.m4$' | xargs perl -pi \
-e 's/(AC_[A-Z_]+\()([^[()]+?)([,)])/$1\[$2]$3/g;' \
-e 's/(AC_[A-Z_]+\((?:\[[^,]+?\], ){1})([^,[()]+?)([,)])/$1\[$2]$3/g;' \
-e 's/(AC_[A-Z_]+\((?:\[[^,]+?\], ){2})([^,[()]+?
15 matches
Mail list logo
