Re: m4 quoting improvements

2008-12-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 12/29/2008 10:59 AM: > - AC_DEFINE(AFS, 1, [Define if you have the Andrew File System.]) > + AC_DEFINE([AFS], 1, [Define if you have the Andrew File System.]) Do you want to also quote [1]? It cannot be confused

Re: m4 quoting improvements

2008-12-29 Thread Bruno Haible
Hi Jim, > Barring objections (yes, I know I'll have to filter out > files that are imported from other projects, like gettext) Looks reasonable (except that the ChangeLog entry indicates that no one except Ralf has actually looked at the diffs). I'm committing a bit more aggressive quoting patche

Re: m4 quoting improvements

2008-12-29 Thread Ralf Wildenhues
Hi Jim, * Jim Meyering wrote on Mon, Dec 29, 2008 at 06:59:59PM CET: > > This is just a first coarse/automated pass; I'm sure there > are many more places where it's appropriate to add quotes. FWIW, the diffs all look good at first glance. (Of course I am not to approve them.) Cheers, and than