Eli Zaretskii writes:
>> The attached patch tries to suppress it. Perhaps
>> gnulib/tests/test-iconv.c also needs a fix.
>>
>> I've tested it on MSYS after manually adding 'const' to the iconv
>> declaration in /usr/local/include/iconv.h, and it seems to be detected.
>>
>> Here is a new test p
> I've tested it on MSYS after manually adding 'const' to the iconv
> declaration in /usr/local/include/iconv.h, and it seems to be
> detected.
>
> Here is a new test package:
> http://du-a.org/~ueno/junk/test-iconv-2.tar.gz
Thanks for your quick response; I've updated your patch in the groff
re
> From: Daiki Ueno
> Cc: ebl...@redhat.com, w...@gnu.org, bug-gnulib@gnu.org
> Date: Thu, 23 Oct 2014 13:09:11 +0900
>
> > Next, it looks to me that the test program in iconv.m4 is
> > inappropriate for a C++ compiler, because (AFAIK) C++ does not allow
> > type-casting of the kind that the ori
Eli Zaretskii writes:
> The prototype of 'iconv' in GNU libiconv's iconv.h is this:
>
> size_t iconv (iconv_t cd, const char** inbuf, size_t *inbytesleft,
> char** outbuf, size_t *outbytesleft);
>
> The 'const' qualifier of the 2nd argument is decided at libiconv
> configuration
> From: Daiki Ueno
> Cc: Werner LEMBERG , e...@gnu.org, bug-gnulib@gnu.org
> Date: Wed, 22 Oct 2014 12:58:29 +0900
>
> > m4_foreach causes the loop to be expanded at m4 time (a larger configure
> > file). In this case, you could probably easily get by with a shell loop
> > instead, for a small
> Date: Wed, 22 Oct 2014 07:25:25 +0200 (CEST)
> Cc: u...@gnu.org, bug-gnulib@gnu.org
> From: Werner LEMBERG
>
>
> >> Looks good, thanks! Eli, do you have time to test it?
> >
> > If you commit the proceeds into the Groff repo, I could try testing
> > tomorrow.
>
> I've just committed Daiki-s
>> Looks good, thanks! Eli, do you have time to test it?
>
> If you commit the proceeds into the Groff repo, I could try testing
> tomorrow.
I've just committed Daiki-san's patch to the groff repository.
Thanks!
Werner
Eric Blake writes:
> m4_foreach causes the loop to be expanded at m4 time (a larger configure
> file). In this case, you could probably easily get by with a shell loop
> instead, for a smaller configure file (untested):
>
>for type in 'char **' 'const char **'; do
> AC_RUN_IFELS
On 10/21/2014 03:30 AM, Daiki Ueno wrote:
> Werner LEMBERG writes:
>
Given that the intention of the above test is to check if the iconv
function works properly, maybe a workaround would be to use the
fixed prototype of iconv (as attached)?
>>>
>>> Sorry, that was obviously wrong.
> Date: Tue, 21 Oct 2014 14:34:17 +0200 (CEST)
> Cc: e...@gnu.org, bug-gnulib@gnu.org
> From: Werner LEMBERG
>
>
> > The attached patch seems to work with both cases.
>
> Looks good, thanks! Eli, do you have time to test it?
If you commit the proceeds into the Groff repo, I could try testing
> The attached patch seems to work with both cases.
Looks good, thanks! Eli, do you have time to test it?
Werner
Werner LEMBERG writes:
>>> Given that the intention of the above test is to check if the iconv
>>> function works properly, maybe a workaround would be to use the
>>> fixed prototype of iconv (as attached)?
>>
>> Sorry, that was obviously wrong. The other idea is to suppress the
>> error with a
>> Given that the intention of the above test is to check if the iconv
>> function works properly, maybe a workaround would be to use the
>> fixed prototype of iconv (as attached)?
>
> Sorry, that was obviously wrong. The other idea is to suppress the
> error with a pragma, but I guess it would
Daiki Ueno writes:
> Given that the intention of the above test is to check if the iconv
> function works properly, maybe a workaround would be to use the fixed
> prototype of iconv (as attached)?
Sorry, that was obviously wrong. The other idea is to suppress the
error with a pragma, but I gues
Hello,
Werner LEMBERG writes:
> Eli reported a failure in the detection code of iconv on MinGW while
> building groff:
>
> conftest.cpp:62:51: error: invalid conversion from 'char**' to 'const
> char**' [-fpermissive]
> In file included from conftest.cpp:43:0:
> d:\usr\bin\../lib/gcc/ming
Eli reported a failure in the detection code of iconv on MinGW while
building groff:
configure:9176: checking for working iconv
configure:9296: g++ -o conftest.exe -O0 -g3 -Id:/usr/include conftest.cpp
d:/usr/lib/libiconv.dll.a -Ld:/usr/lib >&5
conftest.cpp: In function 'int main()':
co
16 matches
Mail list logo
