- avoid breaking the announcement-generating code:
Once you move the "$(MAKE) -s announcement release_typ...@..."
command into another rule, "$@" is no longer valid.
Instead, rely on RELEASE_TYPE being set in the environment.
Ah, yeah, I had fixed that in a different c
> +# Override this in cfg.mk if you have different post-release procedures.
> +post-release-hook ?= default-post-release-administrivia
> +
> # Prevent programs like 'sort' from considering distinct strings to be equal.
> # Doing it here saves us from having to set LC_ALL elsewhere in this file.
>
Ping?
>From 00c33e8b07ae06d2c09394c3cf2892063f0c2fc6 Mon Sep 17 00:00:00 2001
From: Alfred M. Szmidt
Date: Sat, 5 Dec 2009 20:44:20 +0100
Subject: [PATCH] Allow for per-project post-release administrative tasks.
---
ChangeLog|8
top/maint.mk | 10 +-
2 files changed,
I.e., initialize "require_news=true" or to false, then run the
"command":
if $require_news; then
...
fi
By reversing the sense of the name, you make it so the three added
tests are not all negated. That's more readable.
Good idea; but there is a better way to
* Alfred M. Szmidt wrote on Sat, Dec 05, 2009 at 06:26:23PM CET:
> +if [ $opt_skip_news == "false" ]; then
FWIW, test aka [ with `==' is a bashism, please use `=' instead.
Cheers,
Ralf
Alfred M. Szmidt wrote:
>You said you would not be changing announce-gen, so isn't it moot?
>
> I said that I did not have enough knowledge to hack announce-gen since
> it is written in perl; I cannot do something when I don't know how to
> do it.
>
>I pointed out that yet another script pa
You said you would not be changing announce-gen, so isn't it moot?
I said that I did not have enough knowledge to hack announce-gen since
it is written in perl; I cannot do something when I don't know how to
do it.
I pointed out that yet another script parses (and rewrites) NEWS
and woul
Alfred M. Szmidt wrote:
>Alfred M. Szmidt wrote:
>> announce-gen is lovley, but it is very inflexible if you use a
>> different format for NEWS.
>>
>> In inetutils, we use something like:
>>
>> | December 27, 2008
>> | Version 1.6:
>> |
>> | * Fixed FOO in B
Alfred M. Szmidt wrote:
> announce-gen is lovley, but it is very inflexible if you use a
> different format for NEWS.
>
> In inetutils, we use something like:
>
> | December 27, 2008
> | Version 1.6:
> |
> | * Fixed FOO in BAR.
> |
> | * Added BAZ.
> |
>
Alfred M. Szmidt wrote:
> announce-gen is lovley, but it is very inflexible if you use a
> different format for NEWS.
>
> In inetutils, we use something like:
>
> | December 27, 2008
> | Version 1.6:
> |
> | * Fixed FOO in BAR.
> |
> | * Added BAZ.
> |
> | October 21, 2006
> | Version 1.5:
> |
>
announce-gen is lovley, but it is very inflexible if you use a
different format for NEWS.
In inetutils, we use something like:
| December 27, 2008
| Version 1.6:
|
| * Fixed FOO in BAR.
|
| * Added BAZ.
|
| October 21, 2006
| Version 1.5:
|
| ...
I am not sure what a way one should fix announ
11 matches
Mail list logo