Re: [PATCH] strerror_r-posix: Fix override of AC_FUNC_STRERROR_R

2016-11-14 Thread Eric Blake
On 11/12/2016 02:50 PM, Eric Blake wrote: > On 11/04/2016 05:50 PM, Bruno Haible wrote: >> Hi Eric, >> >> Thanks for noticing and fixing this faster than I could. >> >>> A better approach is to replace the autoconf macro with a version >>> of our own that doesn't probe anything, so that the AC_DEFI

Re: [PATCH] strerror_r-posix: Fix override of AC_FUNC_STRERROR_R

2016-11-12 Thread Eric Blake
On 11/04/2016 05:50 PM, Bruno Haible wrote: > Hi Eric, > > Thanks for noticing and fixing this faster than I could. > >> A better approach is to replace the autoconf macro with a version >> of our own that doesn't probe anything, so that the AC_DEFINE is >> reached exactly once. > > Yes, agreed.

Re: [PATCH] strerror_r-posix: Fix override of AC_FUNC_STRERROR_R

2016-11-04 Thread Bruno Haible
Hi Eric, Thanks for noticing and fixing this faster than I could. > A better approach is to replace the autoconf macro with a version > of our own that doesn't probe anything, so that the AC_DEFINE is > reached exactly once. Yes, agreed. > +AC_DEFUN([AC_FUNC_STRERROR_R], [ > + AC_DEFINE([HAVE_