On 11/04/2016 05:50 PM, Bruno Haible wrote: > Hi Eric, > > Thanks for noticing and fixing this faster than I could. > >> A better approach is to replace the autoconf macro with a version >> of our own that doesn't probe anything, so that the AC_DEFINE is >> reached exactly once. > > Yes, agreed. > >> +AC_DEFUN([AC_FUNC_STRERROR_R], [ >> + AC_DEFINE([HAVE_DECL_STRERROR_R], [1], >> + [Define to 1, since you should have the declaration of strerror_r.]) >> + AC_DEFINE([STRERROR_R_CHAR_P], [0], >> + [Define to 0, since strerror_r should not return char *.]) >> ]) > > In this definition I would also add > > AC_DEFINE([HAVE_STRERROR_R], [1], > [Define to 1, since you should have the function strerror_r.])
Okay, I made that change and pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
