Re: C++ patch for m4/mktime.m4

2009-01-15 Thread Jim Meyering
Albert Chin wrote: >> That patch looks fine. >> Would you please write a ChangeLog entry and then send git format-patch >> output to the list? Then, I can easily/reliably apply it in your name >> using "git am". coreutils has similar contribution guidelines, with >> set-up instructions: >> >>

Re: C++ patch for m4/mktime.m4

2009-01-14 Thread Albert Chin
On Wed, Jan 14, 2009 at 07:42:50PM +0100, Jim Meyering wrote: > Albert Chin wrote: > > The Sun C++ compiler fails to compile the test case in m4/mktime.m4 > > correctly because of the K&R style function prototypes. Patch attached. > > Hi Albert, > > That patch looks fine. > Would you please writ

Re: C++ patch for m4/mktime.m4

2009-01-14 Thread Jim Meyering
Albert Chin wrote: > The Sun C++ compiler fails to compile the test case in m4/mktime.m4 > correctly because of the K&R style function prototypes. Patch attached. Hi Albert, That patch looks fine. Would you please write a ChangeLog entry and then send git format-patch output to the list? Then,

C++ patch for m4/mktime.m4

2009-01-14 Thread Albert Chin
The Sun C++ compiler fails to compile the test case in m4/mktime.m4 correctly because of the K&R style function prototypes. Patch attached. -- albert chin (ch...@thewrittenword.com) diff --git a/m4/mktime.m4 b/m4/mktime.m4 index 5faf393..75e55c5 100644 --- a/m4/mktime.m4 +++ b/m4/mktime.m4 @@ -68