On Wed, Jan 14, 2009 at 07:42:50PM +0100, Jim Meyering wrote:
> Albert Chin <bug-gnu...@mlists.thewrittenword.com> wrote:
> > The Sun C++ compiler fails to compile the test case in m4/mktime.m4
> > correctly because of the K&R style function prototypes. Patch attached.
>
> Hi Albert,
>
> That patch looks fine.
> Would you please write a ChangeLog entry and then send git format-patch
> output to the list? Then, I can easily/reliably apply it in your name
> using "git am". coreutils has similar contribution guidelines, with
> set-up instructions:
>
> http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=blob;f=HACKING;hb=HEAD
>
> except that gnulib does version-control its ChangeLog file.
Attached.
--
albert chin (ch...@thewrittenword.com)
>From fd28f8d19ae0deda711d7dfe2d1f856fc77c9b5c Mon Sep 17 00:00:00 2001
From: Albert Chin-A-Young <ch...@thewrittenword.com>
Date: Wed, 14 Jan 2009 12:56:51 -0600
Subject: [PATCH] Remove K&R-style function prototypes.
* m4/mktime.m4 (AC_FUNC_MKTIME): Remove K&R-style function prototypes
for the Sun C++ compiler.
---
m4/mktime.m4 | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/m4/mktime.m4 b/m4/mktime.m4
index 5faf393..75e55c5 100644
--- a/m4/mktime.m4
+++ b/m4/mktime.m4
@@ -68,16 +68,14 @@ spring_forward_gap ()
}
static int
-mktime_test1 (now)
- time_t now;
+mktime_test1 (time_t now)
{
struct tm *lt;
return ! (lt = localtime (&now)) || mktime (lt) == now;
}
static int
-mktime_test (now)
- time_t now;
+mktime_test (time_t now)
{
return (mktime_test1 (now)
&& mktime_test1 ((time_t) (time_t_max - now))
@@ -101,8 +99,7 @@ irix_6_4_bug ()
}
static int
-bigtime_test (j)
- int j;
+bigtime_test (int j)
{
struct tm tm;
time_t now;
--
1.5.4.3
