Re: Bug in base64, new module base32

On 09/26/2011 11:58 AM, Gijs van Tulder wrote: Hi Simon, Thanks for accepting the patch. Simon Josefsson writes: There seems to be some memory leaks in the self-tests, although maybe they are inherited from the base64 self-test? The memory leaks seem to be related to the tests. The exact sam

Re: Bug in base64, new module base32

Hi Simon, Thanks for accepting the patch. Simon Josefsson writes: There seems to be some memory leaks in the self-tests, although maybe they are inherited from the base64 self-test? The memory leaks seem to be related to the tests. The exact same memory leaks appear in the base64 tests as we

Re: Bug in base64, new module base32

Gijs van Tulder writes: > Simon Josefsson wrote: >> Once the copyright papers are resolved, I can commit it >> unless someone else beats me to it. > > Hi. The copyright should be solved now. I've attached the patch for > the base32 module again. (I've changed the RFC reference to point to > the n

Re: Bug in base64, new module base32

Simon Josefsson wrote: Once the copyright papers are resolved, I can commit it > unless someone else beats me to it. Hi. The copyright should be solved now. I've attached the patch for the base32 module again. (I've changed the RFC reference to point to the newest version.) Thanks, Gijs >Fr

Re: Bug in base64, new module base32

Gijs van Tulder writes: > Bruno Haible wrote: >>> + * See also RFC 3548. >> >> Would is not be better to refer to RFC 4648 >> ? It obsoletes the older RFC >> 3548. > > Yes, that would be better. (This is one of the things I

Re: Bug in base64, new module base32

Bruno Haible wrote: >> + * See also RFC 3548. > > Would is not be better to refer to RFC 4648 > ? It obsoletes the older RFC > 3548. Yes, that would be better. (This is one of the things I copied from the base64 module.)

Re: Bug in base64, new module base32

Hi Gijs, > I need a base32 encoding/decoding module, but Gnulib doesn't have one. In > patch 2, I included a new module based on the base64 code that is > already in Gnulib. Your code is in line with gnulib coding style and conventions. Just one question: > + * See also RFC 3548

Re: Bug in base64, new module base32

Gijs van Tulder wrote: > Paul Eggert wrote: >> Thanks for the base64 bug report and patch; I applied it, > > Thanks. (That's quick!) > >> As for the base32 part, would you be willing to assign the >> copyright to the Free Software Foundation, so that we could >> install it in gnulib? > > Certainly

Re: Bug in base64, new module base32

Paul Eggert wrote: Thanks for the base64 bug report and patch; I applied it, Thanks. (That's quick!) As for the base32 part, would you be willing to assign the copyright to the Free Software Foundation, so that we could install it in gnulib? Certainly. How do I do that? Gijs

Re: Bug in base64, new module base32

Thanks for the base64 bug report and patch; I applied it, adding a bit to the comment; see: http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=08c11765d4fe790403229496a8a3ec625a3ca5af As for the base32 part, would you be willing to assign the copyright to the Free Software Foundation, so that

Bug in base64, new module base32

Hi, I'd like to send you two patches that are related to the base64 module. I hope you find them useful. -- The first patch fixes a bug (or at least, I think it is a bug) in the base64_decode_alloc_ctx function. This method sometimes does not decode the final byte in the input. Strange enou