Bruno Haible <[EMAIL PROTECTED]> writes:
> Simon Josefsson wrote:
>> I'd like to see getndelim2 solve this problem:
>>
>> 1) LGPL license compatibility
>
> Done.
Thanks.
>> 2) Portability: getndelim2 uses freadptr and freedseek which appears
>>non-portable by design (or?) -- having a getlin
Simon Josefsson wrote:
> I'd like to see getndelim2 solve this problem:
>
> 1) LGPL license compatibility
Done.
> 2) Portability: getndelim2 uses freadptr and freedseek which appears
>non-portable by design (or?) -- having a getline that can be compiled
>on any C89/POSIX system can be us
Eric Blake wrote:
> > Except that getndelim2 and memchr2 are GPL, while freadptr and freadseek
> > are LGPL (I assume v3+). Would it be okay to change all four to LGPLv2+?
>
> I'm okay with memchr2 being LGPLv2+; it does little more than memchr,
> which is a basic libc function. Since freadptr a
Bruno Haible <[EMAIL PROTECTED]> writes:
> Simon Josefsson wrote:
>> I'd prefer to solve it by having m4 code check whether
>> the non-portable code works or not, and then AC_SUBST in the proper
>> replacement function, either getline-fast.c or getline-slow.c. This
>> allows a gnulib module 'getl
Simon Josefsson wrote:
> I'd prefer to solve it by having m4 code check whether
> the non-portable code works or not, and then AC_SUBST in the proper
> replacement function, either getline-fast.c or getline-slow.c. This
> allows a gnulib module 'getline-slow' for when people prefer a small and
> s
Bruno Haible <[EMAIL PROTECTED]> writes:
>> 2) Portability: getndelim2 uses freadptr and freedseek which appears
>>non-portable by design (or?) -- having a getline that can be compiled
>>on any C89/POSIX system can be useful
>> ...
>> It could be moved to a 'getline-portable' module.
>
> I
Paolo Bonzini <[EMAIL PROTECTED]> wrote:
> Eric Blake wrote:
>> According to Paolo Bonzini on 8/27/2008 6:54 AM:
>>> Except that getndelim2 and memchr2 are GPL, while freadptr and freadseek
>>> are LGPL (I assume v3+). Would it be okay to change all four to LGPLv2+?
>>
>> I'm okay with memchr2 bei
Simon Josefsson wrote:
> I'd like to see getndelim2 solve this problem:
>
> 1) LGPL license compatibility
getndelim2 is currently GPL, because it inherits from a file getline.c that
was written by Jan Brittenson for gcc. To make it LGPL, you would have to
either rewrite getndelim2 from scratch (b
Paolo Bonzini <[EMAIL PROTECTED]> writes:
>> I do feel that the entire unlocked IO feature is poorly implemented in
>> the way that it requires changes to all code that wants to use it, but I
>> don't have a solution for that. Can't you set some global flag that
>> makes all getc calls unlocked?
> I do feel that the entire unlocked IO feature is poorly implemented in
> the way that it requires changes to all code that wants to use it, but I
> don't have a solution for that. Can't you set some global flag that
> makes all getc calls unlocked? Instead of modifying all code to call
> getc_u
Paolo Bonzini <[EMAIL PROTECTED]> writes:
>> However, to deal with 2) and 3) I would prefer if the current code stays
>> around. It could be moved to a 'getline-portable' module.
>
> For now, what do you think about the other patch? It does already
> provide an interesting performance increase.
> However, to deal with 2) and 3) I would prefer if the current code stays
> around. It could be moved to a 'getline-portable' module.
For now, what do you think about the other patch? It does already
provide an interesting performance increase.
Paolo
Paolo Bonzini <[EMAIL PROTECTED]> writes:
> The number of deletions makes it yummy...
I like it, although in order to deprecate the current implementation,
I'd like to see getndelim2 solve this problem:
1) LGPL license compatibility
2) Portability: getndelim2 uses freadptr and freedseek which a
Eric Blake wrote:
> According to Paolo Bonzini on 8/27/2008 6:54 AM:
>> Except that getndelim2 and memchr2 are GPL, while freadptr and freadseek
>> are LGPL (I assume v3+). Would it be okay to change all four to LGPLv2+?
>
> I'm okay with memchr2 being LGPLv2+; it does little more than memchr,
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Paolo Bonzini on 8/27/2008 6:54 AM:
>
> Except that getndelim2 and memchr2 are GPL, while freadptr and freadseek
> are LGPL (I assume v3+). Would it be okay to change all four to LGPLv2+?
I'm okay with memchr2 being LGPLv2+; it does lit
>> Sounds interesting. How does this compare with the current approach used
>> by getndelim2, which uses freadptr to avoid getc?
>
> I guess there's also this other possibility.
>
> lib/getdelim.c | 107 ++-
> m4/getdelim.m4 | 10 -
> modu
Eric Blake wrote:
> According to Paolo Bonzini on 8/27/2008 5:48 AM:
>> Under MacOS, getc is not a macro, only getc_unlocked is. This patch
>> does two things: 1) it makes getdelim use getc_unlocked if it can wrap
>> the calls with flockfile/funlockfile; 2) it makes getdelim omit the
>> locking al
Eric Blake wrote:
> According to Paolo Bonzini on 8/27/2008 5:48 AM:
>> Under MacOS, getc is not a macro, only getc_unlocked is. This patch
>> does two things: 1) it makes getdelim use getc_unlocked if it can wrap
>> the calls with flockfile/funlockfile; 2) it makes getdelim omit the
>> locking al
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Paolo Bonzini on 8/27/2008 5:48 AM:
> Under MacOS, getc is not a macro, only getc_unlocked is. This patch
> does two things: 1) it makes getdelim use getc_unlocked if it can wrap
> the calls with flockfile/funlockfile; 2) it makes getdeli
Under MacOS, getc is not a macro, only getc_unlocked is. This patch
does two things: 1) it makes getdelim use getc_unlocked if it can wrap
the calls with flockfile/funlockfile; 2) it makes getdelim omit the
locking altogether if unlocked-io is in effect. It speeds up sed by
almost 2x in very simp
20 matches
Mail list logo
