Paolo Bonzini <[EMAIL PROTECTED]> writes:

>> I do feel that the entire unlocked IO feature is poorly implemented in
>> the way that it requires changes to all code that wants to use it, but I
>> don't have a solution for that.  Can't you set some global flag that
>> makes all getc calls unlocked?  Instead of modifying all code to call
>> getc_unlocked instead of getc.
>
> You can add #include "unlocked-io.h" to your config.h using AH_VERBATIM.

It still requires changes to code like this to make use of it, doesn't
it?  That feels like an unclean design to me, but it is not important.

>  However, notice that the patch provides the performance increase even
> if *not* using unlocked-io.h.

I hadn't realized that.  Thanks for pushing it.

Thanks,
/Simon


Reply via email to