Re: [PATCH] stdint, read-file: fix missing SIZE_MAX on Android

2014-03-05 Thread Paul Eggert
Kevin Cernekee wrote: How important is it to maintain compatibility with the older NDK releases? I don't know. But this convinces me that your patch is better. I rewrote the ChangeLog entry to avoid worries about copyright and installed the attached. If you plan to contribute more we shoul

Re: [PATCH] stdint, read-file: fix missing SIZE_MAX on Android

2014-03-05 Thread Kevin Cernekee
On Wed, Mar 5, 2014 at 2:42 PM, Paul Eggert wrote: > Thanks for the bug report and patch. A couple of things. First, the > commentary is big enough so that we'd need a copyright assignment for this > -- if you and your employer are OK with that please let me know and I'll > start the ball rollin

Re: [PATCH] stdint, read-file: fix missing SIZE_MAX on Android

2014-03-05 Thread Paul Eggert
Thanks for the bug report and patch. A couple of things. First, the commentary is big enough so that we'd need a copyright assignment for this -- if you and your employer are OK with that please let me know and I'll start the ball rolling on the paperwork. If this is an issue we can rederive

Re: [PATCH] stdint, read-file: fix missing SIZE_MAX on Android

2014-03-05 Thread Kevin Cernekee
On Wed, Mar 5, 2014 at 12:10 PM, Kevin Cernekee wrote: > Building read-file.c currently fails on Android (ARM): > > arm-linux-androideabi-gcc -DHAVE_CONFIG_H -I. -I.. > -DGNULIB_STRICT_CHECKING=1 -g -O2 -MT read-file.o -MD -MP -MF > .deps/read-file.Tpo -c -o read-file.o read-file.c >

[PATCH] stdint, read-file: fix missing SIZE_MAX on Android

2014-03-05 Thread Kevin Cernekee
Building read-file.c currently fails on Android (ARM): arm-linux-androideabi-gcc -DHAVE_CONFIG_H -I. -I.. -DGNULIB_STRICT_CHECKING=1 -g -O2 -MT read-file.o -MD -MP -MF .deps/read-file.Tpo -c -o read-file.o read-file.c read-file.c: In function 'fread_file': read-file.c:62:17: error