On Wed, Mar 5, 2014 at 2:42 PM, Paul Eggert <egg...@cs.ucla.edu> wrote:
> Thanks for the bug report and patch. A couple of things. First, the
> commentary is big enough so that we'd need a copyright assignment for this
> -- if you and your employer are OK with that please let me know and I'll
> start the ball rolling on the paperwork.
That's fine
> Second, I'd like to avoid having stdint depend on sys_types. Does the
> attached smaller change work for you? If so, I can push it along with
> commentary that I can write up.
So basically this reverts 1e3c93f9f (stdint: fix build with Android's
Bionic fox [sic] x86)
I do see the duplicate _SSIZE_T_DEFINED_ definition in NDK r8's
platforms/android-{9,14}/arch-x86/usr/include/machine/_types.h. It
was removed from AOSP about 1.5 years ago:
commit 3975cec694a0c9b42e3f7e671fcd678da92836c3
Author: Elliott Hughes <e...@google.com>
Date: Thu Nov 29 17:25:23 2012 -0800
Remove (near-)duplicate definitions of size_t and ssize_t.
The near duplicates upset fussier compilers that insist that
typedefs be exactly the same, but the fix isn't to make all
copies identical...
Change-Id: Icfdace41726f36ec33c9ae919dbb5a54d3529cc9
libc/arch-arm/include/machine/_types.h | 11 -----------
libc/arch-mips/include/machine/_types.h | 2 --
libc/arch-x86/include/machine/_types.h | 23 -----------------------
libc/include/search.h | 7 -------
libc/include/stdint.h | 6 ------
libc/include/stdio.h | 21 +--------------------
libc/include/sys/types.h | 5 -----
7 files changed, 1 insertion(+), 74 deletions(-)
I do not see the duplicated definition in NDK versions r8e, r9, r9b,
r9c, or r9d.
How important is it to maintain compatibility with the older NDK releases?
(Note: I have not tried building gnulib against NDK r8, so there may
be other surprises lurking.)
