Re: [PATCH] maint: adjust cpp indentation for my modules, as well

2011-03-13 Thread Jim Meyering
Bruno Haible wrote: > Eric Blake wrote: >> > This Makefile is so specialized that I think it can assume GNU make. >> > Does anyone prefer not to do that? >> >> No complaint by me, although we might want to 'git mv {,GNU}Makefile' to >> make the change obvious. > > When a newbie looks whether there

Re: [PATCH] maint: adjust cpp indentation for my modules, as well

2011-02-22 Thread Jim Meyering
Paul Eggert wrote: > On 02/22/2011 07:57 AM, Jim Meyering wrote: >> I omitted getloadavg.c since it had so many violations >> and is s crufty, and since Paul just got it into emacs. >> However, considering the number of cpp conditionals, it might >> benefit from the conversion. Paul, what do y

Re: [PATCH] maint: adjust cpp indentation for my modules, as well

2011-02-22 Thread Bruno Haible
Eric Blake wrote: > > This Makefile is so specialized that I think it can assume GNU make. > > Does anyone prefer not to do that? > > No complaint by me, although we might want to 'git mv {,GNU}Makefile' to > make the change obvious. When a newbie looks whether there is a Makefile, he looks for '

Re: [PATCH] maint: adjust cpp indentation for my modules, as well

2011-02-22 Thread Paul Eggert
On 02/22/2011 07:57 AM, Jim Meyering wrote: I omitted getloadavg.c since it had so many violations and is s crufty, and since Paul just got it into emacs. However, considering the number of cpp conditionals, it might benefit from the conversion. Paul, what do you think? I have no objection

Re: [PATCH] maint: adjust cpp indentation for my modules, as well

2011-02-22 Thread Eric Blake
On 02/22/2011 08:57 AM, Jim Meyering wrote: > Eric Blake wrote: > ... >> Not too many of mine, either. By the way, did you intend >> that sc_cpp_indent_check was not run by 'make check'? > > No. I forgot that just adding an sc_ name here does not > automatically do what I want (like it does in m

Re: [PATCH] maint: adjust cpp indentation for my modules, as well

2011-02-22 Thread Jim Meyering
Eric Blake wrote: ... > Not too many of mine, either. By the way, did you intend > that sc_cpp_indent_check was not run by 'make check'? No. I forgot that just adding an sc_ name here does not automatically do what I want (like it does in maint.mk). This Makefile is so specialized that I think i

[PATCH] maint: adjust cpp indentation for my modules, as well

2011-02-22 Thread Eric Blake
* Makefile (sc_cpp_indent_check): Add my name. * lib/fbufmode.c: Filter through cppi. * lib/fpurge.c: Likewise. * lib/freadable.c: Likewise. * lib/freading.c: Likewise. * lib/fwritable.c: Likewise. * lib/fwriting.c: Likewise. * lib/sigaction.c: Likewise. Signed-off-by: Eric Blake --- > I underst