Re: relicensing libunistring to "dual LGPLv3+ or GPLv2"

2016-11-21 Thread Kevin Cernekee
On Mon, Nov 21, 2016 at 10:46 AM, Bruno Haible wrote: > I would be willing to put my contributions to these files under LGPLv2+. [...] > === Kevin === > > Would you be willing to do the same for lib/fseterr.c ? Yes, approved.

Re: [PATCH 2/3] getdtablesize: Extend RLIMIT_NOFILE fallback case to Android

2015-02-22 Thread Kevin Cernekee
On Fri, Feb 20, 2015 at 11:00 AM, Paul Eggert wrote: > Kevin Cernekee wrote: > >> However, I don't see how any of the m4 changes address the problem >> that is causing the test cases to fail: lib/getdtablesize.c still >> wants to rely on sysconf(_SC_OPEN_MAX) o

Re: [PATCH 2/3] getdtablesize: Extend RLIMIT_NOFILE fallback case to Android

2015-02-19 Thread Kevin Cernekee
On Wed, Feb 18, 2015 at 11:30 PM, Paul Eggert wrote: > Kevin Cernekee wrote: >> >> The changes to the AC_RUN_IFELSE test programs do not have an effect >> on Android since we are cross-compiling: >> >> checking whether dup2 works... guessing no >>

Re: [PATCH 2/3] getdtablesize: Extend RLIMIT_NOFILE fallback case to Android

2015-02-18 Thread Kevin Cernekee
On Tue, Feb 17, 2015 at 6:37 PM, Paul Eggert wrote: > Kevin Cernekee wrote: > >> On Android, sysconf (_SC_OPEN_MAX) always returns the constant >> OPEN_MAX (256) > > > Ouch, that sounds like a POSIX conformance bug. I see enh posted an Android > patch but we shou

Re: [PATCH 00/11] Android compatibility

2015-02-17 Thread Kevin Cernekee
On Tue, Feb 17, 2015 at 10:07 PM, Paul Eggert wrote: > Kevin Cernekee wrote: >>>> >>>> test-localename is calling strdup() on a NULL pointer returned by >>>> >>gl_locale_name_thread(), and crashing. From reading >>>> >>gl_lo

Re: [PATCH 2/3] getdtablesize: Extend RLIMIT_NOFILE fallback case to Android

2015-02-17 Thread Kevin Cernekee
On Mon, Feb 16, 2015 at 9:46 PM, Paul Eggert wrote: > The other patches (after your revisions) look good and I installed them, but > this one didn't look right. That part of the code really is intended to be > used only on Cygwin and it's not portable to other platforms (e.g., it > mishandles RLI

[PATCH V2] localename: Implement gl_locale_name_thread_unsafe() for Android

2015-02-16 Thread Kevin Cernekee
* lib/localename.c: Android API level >= 21 supports two hardcoded locales: C (POSIX) and C.UTF-8. Distinguish them by checking the internal __locale_t struct. --- ChangeLog| 5 + lib/localename.c | 2 ++ 2 files changed, 7 insertions(+) diff --git a/ChangeLog b/ChangeLog index 9b84d

Re: [PATCH 3/3] localename: Implement gl_locale_name_thread_unsafe() for Android

2015-02-16 Thread Kevin Cernekee
On Sun, Feb 15, 2015 at 11:20 PM, enh wrote: > there's portable public API for that: MB_CUR_MAX in . Thanks for the feedback. I'm sending V2 of this patch (just this patch) with your suggested fix. test-localename passes on both android-19 (where it's a no-op) and android-21.

[PATCH 2/3] getdtablesize: Extend RLIMIT_NOFILE fallback case to Android

2015-02-15 Thread Kevin Cernekee
* lib/getdtablesize.c: Use rlim_cur instead of rlim_max, to match glibc behavior. test-getdtablesize and test-dup2 both assume they will be able to create a file descriptor numbered (getdtablesize()-1), and will fail if rlim_max > rlim_cur. --- ChangeLog | 6 ++ lib/getdtablesize.c

[PATCH 3/3] localename: Implement gl_locale_name_thread_unsafe() for Android

2015-02-15 Thread Kevin Cernekee
* lib/localename.c: Android API level >= 21 supports two hardcoded locales: C (POSIX) and C.UTF-8. Distinguish them by checking the internal __locale_t struct. --- ChangeLog| 5 + lib/localename.c | 6 ++ 2 files changed, 11 insertions(+) diff --git a/ChangeLog b/ChangeLog index

[PATCH 1/3] More changelog fixes

2015-02-15 Thread Kevin Cernekee
--- ChangeLog | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 0ac651c..5fbd970 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,4 +1,4 @@ -2015-02-11 Paul Eggert +2015-02-11 Kevin Cernekee Fix FILE struct compatibility with

[PATCH 0/3] More Android updates for gnulib

2015-02-15 Thread Kevin Cernekee
This includes V2 of the getdtablesize() change, which was changed to use uses the special rlim_max implementation for Cygwin only. On Linux based platforms like Android, it will use rlim_cur. Kevin Cernekee (3): More changelog fixes getdtablesize: Extend RLIMIT_NOFILE fallback case to

Re: [PATCH 00/11] Android compatibility

2015-02-11 Thread Kevin Cernekee
On Wed, Feb 11, 2015 at 4:12 PM, Paul Eggert wrote: > Thanks for doing all that work! I pushed the first 10 patches and have > a couple of comments. I'll send a separate email about the 11th patch. > > Kevin Cernekee wrote: > >> FAIL: test-verify.sh >> ==

[PATCH 09/11] signal_h: Fix Android build

2015-02-11 Thread Kevin Cernekee
* lib/signal.in.h: Add Android to the list of platforms that declare pthread_sigmask() in instead of . --- ChangeLog | 4 lib/signal.in.h | 8 +--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index d17b2220125b..6ed3de23809f 100644 --- a/Cha

[PATCH 08/11] net_if: Handle content-free system headers

2015-02-11 Thread Kevin Cernekee
* m4/net_if_h.m4: Check to make sure actually defines struct if_nameindex. If not, enable the replacement header. --- ChangeLog | 4 m4/net_if_h.m4 | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 8cd014b3cf58..d17b2220125b 100644 --- a

[PATCH 07/11] linkat_nofollow: Add fallback case for cross compiling

2015-02-11 Thread Kevin Cernekee
* m4/linkat.m4: Guess no for Darwin, yes otherwise. --- ChangeLog| 3 +++ m4/linkat.m4 | 18 -- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7e1fb9191b6d..8cd014b3cf58 100644 --- a/ChangeLog +++ b/ChangeLog @@ -39,6 +39,9 @@

[PATCH 11/11] getdtablesize: Fix RLIMIT_NOFILE fallback case

2015-02-11 Thread Kevin Cernekee
* lib/getdtablesize.c: Use rlim_cur instead of rlim_max, to match glibc behavior. test-getdtablesize and test-dup2 both assume they will be able to create a file descriptor numbered (getdtablesize()-1), and will fail if rlim_max > rlim_cur. --- ChangeLog | 6 ++ lib/getdtablesize.c

[PATCH 02/11] Assume unbroken ungetc() on Android

2015-02-11 Thread Kevin Cernekee
* m4/ungetc.m4: Add Android case to host OS check. The ungetc() test case passed when running on an Android host, and the code hasn't really changed since 2009. --- ChangeLog| 5 + m4/ungetc.m4 | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog

[PATCH 03/11] getdtablesize: Fix Android build

2015-02-11 Thread Kevin Cernekee
* m4/getdtablesize.m4: Add Android case to host OS check. Recent NDK versions have this symbol in the .so library (at least 32-bit platforms) but are missing the declaration in the header file, causing the m4 logic to guess incorrectly. --- ChangeLog | 6 ++ m4/getdtablesize.m4 | 4

[PATCH 06/11] euidaccess: Fix Android build

2015-02-11 Thread Kevin Cernekee
* modules/euidaccess (Depends-on): Add fcntl-h to ensure that AT_EACCESS gets declared. --- ChangeLog | 4 modules/euidaccess | 1 + 2 files changed, 5 insertions(+) diff --git a/ChangeLog b/ChangeLog index bbcc513261eb..7e1fb9191b6d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -35,6 +

[PATCH 04/11] localename: Fix Android build

2015-02-11 Thread Kevin Cernekee
* modules/localename (Depends-on): Add langinfo. --- ChangeLog | 3 +++ modules/localename | 1 + 2 files changed, 4 insertions(+) diff --git a/ChangeLog b/ChangeLog index c1a37f5f1504..6d8bffa4160f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -28,6 +28,9 @@ platforms) but are missi

[PATCH 05/11] getugroups: Fix Android build

2015-02-11 Thread Kevin Cernekee
* lib/getugroups.c: Don't reference unsupported {get,set,end}grent functions. --- ChangeLog| 4 lib/getugroups.c | 7 +-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6d8bffa4160f..bbcc513261eb 100644 --- a/ChangeLog +++ b/ChangeLog @@

[PATCH 10/11] duplocale: Fix Android build of duplocale-tests

2015-02-11 Thread Kevin Cernekee
* modules/duplocale-tests (Depends-on): Add langinfo, as the header is included by test-duplocale.c (but not by duplocale.c). * modules/duplocale-tests (configure.ac): Check for monetary.h. * tests/test-duplocale.c: Skip test if monetary.h is absent. * doc/posix-headers/monetary.texi: Add Android t

[PATCH 01/11] Fix FILE struct compatibility with Android API level >= 21

2015-02-11 Thread Kevin Cernekee
- 14 files changed, 58 insertions(+), 20 deletions(-) diff --git a/ChangeLog b/ChangeLog index 4b5092dd0e47..a6f26301f28d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,22 @@ +2015-02-09 Kevin Cernekee + + Fix FILE struct compatibility with Android API level >= 21 + * lib/stdi

[PATCH 00/11] Android compatibility

2015-02-11 Thread Kevin Cernekee
to change the test case to "return 77" on systems that are unaware of locales? All 107 tests passed when running the latest gnulib code on an x86_64 Linux PC. Kevin Cernekee (11): Fix FILE struct compatibility with Android API level >= 21 Assume unbroken ungetc() on Android g

Re: [PATCH] stdint, read-file: fix missing SIZE_MAX on Android

2014-03-05 Thread Kevin Cernekee
On Wed, Mar 5, 2014 at 2:42 PM, Paul Eggert wrote: > Thanks for the bug report and patch. A couple of things. First, the > commentary is big enough so that we'd need a copyright assignment for this > -- if you and your employer are OK with that please let me know and I'll > start the ball rollin

Re: [PATCH] stdint, read-file: fix missing SIZE_MAX on Android

2014-03-05 Thread Kevin Cernekee
On Wed, Mar 5, 2014 at 12:10 PM, Kevin Cernekee wrote: > Building read-file.c currently fails on Android (ARM): > > arm-linux-androideabi-gcc -DHAVE_CONFIG_H -I. -I.. > -DGNULIB_STRICT_CHECKING=1 -g -O2 -MT read-file.o -MD -MP -MF > .deps/read-file.Tpo -c -o read-fil

[PATCH] stdint, read-file: fix missing SIZE_MAX on Android

2014-03-05 Thread Kevin Cernekee
| 12 lib/stdint.in.h|3 +-- lib/sys_types.in.h |2 ++ modules/stdint |1 + 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 4e1984c..17b9b88 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,15 @@ +2014-03-04 Ke

[PATCH] fflush, freadahead, fseeko: Fix for Android

2013-09-06 Thread Kevin Cernekee
/ChangeLog index 5ef6557..ba6ac32 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2013-09-06 Kevin Cernekee + + fflush, freadahead, fseeko: Fix for Android + Suggested by Bruno Haible in: + <http://lists.gnu.org/archive/html/bug-gnulib/2012-01/msg00306.html> + *