> End sentences with '.'
done
> Same here.
done
> That filename comment is now wrong.
fixed
> Is that true? If this new original code, shouldn't it say 2024? If
> this isn't new original code (does it come from coreutils), it make
> sense to add a comment saying where it is coming from, lik
Sam Russell writes:
> Thanks for the quick reply Bruno, updated patch attached
I really like what you did here! It is clean and easy to review,
separated from the core crc.c code. In retrospect the slice-by-8
variant should have followed this pattern instead, but I won't pester
you with that r
Thanks for the quick reply Bruno, updated patch attached
On Mon, 16 Dec 2024 at 17:25, Bruno Haible wrote:
> Sam Russell wrote:
> > crc-x86_64 is added as its own package with minimal bindings in crc.c to
> > support, flagged off by the GL_CRC_PCLMUL flag which is only set if the
> > crc-x86_64
Sam Russell wrote:
> crc-x86_64 is added as its own package with minimal bindings in crc.c to
> support, flagged off by the GL_CRC_PCLMUL flag which is only set if the
> crc-x86_64 package is selected.
Thanks. Some final nitpicking from my side:
In crc-x86_64-pclmul.c:
> +#include
> +
> +#includ
crc-x86_64 is added as its own package with minimal bindings in crc.c to
support, flagged off by the GL_CRC_PCLMUL flag which is only set if the
crc-x86_64 package is selected.
Tested against gzip with the package included and omitted and gzip builds
fine in both case.
On Fri, 13 Dec 2024 at 20:4
Hi Paul,
Today, coverity reports that in lib/time_rz.c line 303
"Field tm_1.tm_gmtoff is uninitialized."
Is it really uninitialized after the mktime() call in line 298?
Is it a problem if it is uninitialized?
Bruno
