Paul Eggert writes:
> On 2024-06-04 02:10, Collin Funk wrote:
>> Good point. Probably yes since they are public functions. '__gl' is used
>> for private functions (see stdbit.in.h and binary-io.h).
>
> Yes, that makes sense. I installed the first attached patch into Gnulib.
>
> Po, could you plea
On 2024-06-04 02:10, Collin Funk wrote:
Good point. Probably yes since they are public functions. '__gl' is used
for private functions (see stdbit.in.h and binary-io.h).
Yes, that makes sense. I installed the first attached patch into Gnulib.
Po, could you please try the second (obvious) attac
> From: Collin Funk
> Cc: Paul Eggert , Bruno Haible ,
> emacs-de...@gnu.org, bug-gnulib@gnu.org
> Date: Tue, 04 Jun 2024 11:39:12 -0700
>
> Eli Zaretskii writes:
>
> > However, that header is not really needed here because the
> > signature of the GetTickCount64 function, which boot-time-a
Hi Eli,
Eli Zaretskii writes:
> However, that header is not really needed here because the
> signature of the GetTickCount64 function, which boot-time-aux.h now
> calls, is completely defined in boot-time-aux.h:
>
> typedef ULONGLONG (WINAPI * GetTickCount64FuncType) (void);
[...]
> So I think
Paul imported today the latest changes from Gnulib, and that broke the
Emacs MinGW build on the master branch when mingw.org's MinGW is used:
boot-time.c:49:11: fatal error: sysinfoapi.h: No such file or directory
49 | # include
| ^~
compilation terminated.
Po Lu writes:
> Let's hear from Paul first.
Sure.
>> +# define htole32 __gl_endian_htole32
[...]
> Isn't it more in line with Gnulib convention to prefix replacement
> functions with `rpl_'?
Good point. Probably yes since they are public functions. '__gl' is used
for private functions (see stdb
Collin Funk writes:
> Can you test it for me?
Let's hear from Paul first.
> +/* Define our own. */
> +# define be16toh __gl_endian_be16toh
> +# define be32toh __gl_endian_be32toh
> +# define be64toh __gl_endian_be64toh
> +# define htobe16 __gl_endian_htobe16
> +# define htobe32 __gl_endian_hto
Hi Po,
Po Lu writes:
> but because Gnulib's definitions are `inline', the functions provided in
> the system endian.h acquire external linkage, and are duplicated across
> every unit by which the redefinitions are included:
>
> CCLD libemacs.so
> /home/.../.../android-ndk-r10b/toolchains/a
Paul Eggert writes:
> Thanks for reporting that. I installed this patch into Gnulib:
>
> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=6457d2c190f47e2288c08f6a5e0dba412ff62855
>
> and propagated it into Emacs master:
>
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=799f78a92c6
Paul Eggert writes:
> Thanks for reporting that. I installed this patch into Gnulib:
>
> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=6457d2c190f47e2288c08f6a5e0dba412ff62855
>
> and propagated it into Emacs master:
>
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=799f78a92c6
10 matches
Mail list logo
