Re: x-to-1

2023-02-10 Thread Reuben Thomas
On Thu, 9 Feb 2023 at 02:49, Bruno Haible wrote: > > > > In general, then, it would be good if x-to-1 ignored unknown options and > > passed them to help2man; would that be possible? > > Passing down additional options to help2man is a very good idea; > implemented > below. Ignoring unknown optio

Re: mkfifoat: Fix crash on macOS 12

2023-02-10 Thread Bruno Haible
And this patch fixes the code duplication in the last patch. 2023-02-10 Bruno Haible Fix code duplication in last commit. * m4/gnulib-common.m4 (gl_CHECK_FUNCS_DEFAULT_CASE, gl_CHECK_FUNCS_CASE_FOR_ANDROID, gl_CHECK_FUNCS_CASE_FOR_MACOS, gl_CHECK_FUNCS_SET_RESU

macOS 12 status

2023-02-10 Thread Bruno Haible
On the macOS 12 machine, a Gnulib testdir now compiles fine, and usually all tests pass. Usually, because sometimes the test-system-quote.sh test fails, reporting that a system() invocation failed with status 768 (= 0x0300). Sounds weird... Log is attached. Bruno for input = |a z |: system() com

mkfifoat: Fix crash on macOS 12

2023-02-10 Thread Bruno Haible
Building a testdir on macOS 12.5, I see this test failure: FAIL: test-mkfifoat === FAIL test-mkfifoat (exit status: 139) What's going on, is that the function mkfifoat (and likewise mknodat) is only available in macOS ≥ 13.0, and in older macOS versions the function call just c

Re: [PATCH] fix typos like "the the" and "a a" in comment

2023-02-10 Thread Bruno Haible
ChuanGang Jiang wrote: > *lib/c32is-impl.h: s/the the/the/ > *lib/getopt-pfx-core.h: s/a a/a/ > *lib/term-style-control.h: s/the the/the/ > *lib/textstyle.in.h: s/the the/the/ Thanks. Applied. Bruno

[PATCH] fix typos like "the the" and "a a" in comment

2023-02-10 Thread ChuanGang Jiang
*lib/c32is-impl.h: s/the the/the/ *lib/getopt-pfx-core.h: s/a a/a/ *lib/term-style-control.h: s/the the/the/ *lib/textstyle.in.h: s/the the/the/ --- lib/c32is-impl.h | 2 +- lib/getopt-pfx-core.h| 2 +- lib/term-style-control.h | 2 +- lib/textstyle.in.h | 2 +- 4 files changed,

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-10 Thread Bruno Haible
Corinna Vinschen wrote: > > In Cygwin projects using libtool, we always have to add -no-undefined > > in LDFLAGS. Likewise for AIX, IIRC. Reuben Thomas wrote: > > Patch is attached. It would be nice if that's ok for inclusion. > > > I did apply this patch, but just noticed that it broke the Mi

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-10 Thread Reuben Thomas
On Tue, 7 Feb 2023 at 15:22, Corinna Vinschen wrote: > In Cygwin projects using libtool, we always have to add -no-undefined > iLDFLAGS. This is some old safe-guard in libtool to remind developers > that when creating Windows DLLs, all external symbols must be resolved. > > Fortunately, libtool

chown, lchown, fchownat tests: Avoid test failure on macOS 12

2023-02-10 Thread Bruno Haible
On macOS 12.5, I see these 3 test failures: FAIL: test-chown ../../gltests/test-chown.h:75: assertion 'st1.st_gid == getegid ()' failed FAIL test-chown (exit status: 134) FAIL: test-fchownat === ../../gltests/test-chown.h:75: assertion 'st1.st_gid == getegid ()

Re: nullptr in C++ mode on macOS

2023-02-10 Thread Bruno Haible
Jeffrey Walton wrote: > Then you have Apple's version of Clang. They are probably C++03 for > compatibility reasons for Xcode developers. So even if LLVM moved to > C++11, Apple's Clang may stay at C++03. Ah, that explains the nullptr issue with this compiler, and also why we have to test __apple_

Re: nullptr in C++ mode on macOS

2023-02-10 Thread Bruno Haible
Paul Eggert wrote: > Let's treat C++ overloading like we already treat C _Generic, that is, > as a documented limitation of the substitute nullptr macro. This should > be good enough for Gnulib itself. I installed the attached to document > that, and to work around the Apple clang 14 incompatibi