Re: [PATCH] binary-io: do not treat set_binary_mode() on stdin/out/err as an error on OS/2

2019-05-24 Thread KO Myung-Hun
Hi/2. Paul Eggert wrote: > On 5/24/19 4:31 AM, KO Myung-Hun wrote: >> Setting stdin/out/err to binary mode is allowed on OS/2. But it's not >> useful, because it generates stair-output hard to read. >> >> Instead, let's set them to text mode all the time. > > First, that patch doesn't set them to

Re: Why does close_stdout close stdout and stderr?

2019-05-24 Thread Paul Eggert
On 5/13/19 12:00 AM, Florian Weimer wrote: I don't see any way around this problem in general with the closeout module's current API, because when it discovers an I/O error it calls _exit, and _exit also clashes with that kind of cleanup handling. This isn't the problem. fflush may also realist

Re: [PATCH] flexmember: update comment

2019-05-24 Thread Paul Eggert
On 5/24/19 4:33 PM, Bruno Haible wrote: You found the right words now :) - I would expect to see such explanations in the .h file, not in the .m4 file. I gave that a shot by installing the attached. >From eb7977e908bd3b2a1367ab2871647e76055b4ba0 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date:

Re: [PATCH] flexmember: update comment

2019-05-24 Thread Bruno Haible
Hi Paul, > > 1) What is the alignment problem if the array element type is 'char'? > > Suppose we have a platform where the alignment of each basic type is > equal to its size, where sizeof (int) == 4 and sizeof (char) == 1, and > where we have 'struct s { int n; char d[]; };' and suppose we wa

Re: [PATCH] flexmember: update comment

2019-05-24 Thread Paul Eggert
On 5/24/19 3:17 PM, Bruno Haible wrote: 1) What is the alignment problem if the array element type is 'char'? Suppose we have a platform where the alignment of each basic type is equal to its size, where sizeof (int) == 4 and sizeof (char) == 1, and where we have 'struct s { int n; char d[];

Re: [PATCH] flexmember: update comment

2019-05-24 Thread Bruno Haible
Hi Paul, > + Use 'FLEXSIZEOF (struct s, d, N)' to calculate the size in bytes > + of such a struct containing an N-element array, as both > + 'sizeof (struct s) + N * sizeof (char)' and > + 'offsetof (struct s, d) + N * sizeof (char)' > + might compute a size that can

[PATCH] flexmember: update comment

2019-05-24 Thread Paul Eggert
* m4/flexmember.m4 (AC_C_FLEXIBLE_ARRAY_MEMBER): Improve comment. --- ChangeLog| 5 + m4/flexmember.m4 | 10 +++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 0c4c515a0..efa81e2ae 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8

Re: [PATCH] binary-io: do not treat set_binary_mode() on stdin/out/err as an error on OS/2

2019-05-24 Thread Paul Eggert
On 5/24/19 4:31 AM, KO Myung-Hun wrote: Setting stdin/out/err to binary mode is allowed on OS/2. But it's not useful, because it generates stair-output hard to read. Instead, let's set them to text mode all the time. First, that patch doesn't set them to text mode all the time; it does so onl

[PATCH] binary-io: do not treat set_binary_mode() on stdin/out/err as an error on OS/2

2019-05-24 Thread KO Myung-Hun
Setting stdin/out/err to binary mode is allowed on OS/2. But it's not useful, because it generates stair-output hard to read. Instead, let's set them to text mode all the time. This fixes that tee always crashes at startup if stdin or stdout are not piped. * lib/binary-io.c (__gl_setmode_check)