Hi/2. Paul Eggert wrote: > On 5/24/19 4:31 AM, KO Myung-Hun wrote: >> Setting stdin/out/err to binary mode is allowed on OS/2. But it's not >> useful, because it generates stair-output hard to read. >> >> Instead, let's set them to text mode all the time. > > First, that patch doesn't set them to text mode all the time; it does so > only if isatty returns nonzero. >
them = stdin/out/err = tty Therefore, they are always set to text mode whenever set_binary_mode() is called. > Second, __gl_setmode_check already has the isatty test, so why do it twice? > First setmode() on tty on OS/2 is not error. However, __gl_setmode_check() always return -1 if tty. Second, I'm not sure it's guaranteed that __gl_setmode_check() is equivalent to isatty(). -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.os2.kr/
