Re: __builtin_expect used in regex

Thanks for reporting the problem. Please try the attached patch against Gawk master. The ChangeLog entry is a bit optimistic, as it is assuming that the patch works (and if it works, I would like to install the relevant changes into Gnulib and into glibc, so that at that point the ChangeLog entr

Re: [PATCH 2/2] hmac-*: refactor to remove repetitive code

On 30/09/18 11:22, Bruno Haible wrote: > Hi Pádraig, > > With this patch, I see a small regression: > >> #include >> - >> -#include "hmac.h" > There is no verification any more that hmac.h is self-contained. > > As mentioned just yesterday, the best practice is to #include the > specification

Re: [PATCH] lib/vasnprintf.c: Add information to make integer comparison logical

Hi Bjarni, Haven't heard back from you in a week. So I'm applying this patch. 2018-09-30 Bruno Haible vasnprintf: Avoid warnings from GCC's -Wsign-compare. Reported by Bjarni Ingi Gislason in .

Re: __builtin_expect used in regex

Bruno Haible wrote: In gnulib, the module 'regex' depends on the module 'builtin-expect' (with the appropriate condition), and this latter module guarantees that __builtin_expect is defined also on non-GCC compilers. All true. However, __builtin_expect is being phased out in glibc and I'd like

Re: [PATCH 2/2] hmac-*: refactor to remove repetitive code

Hi Pádraig, With this patch, I see a small regression: > #include > - > -#include "hmac.h" and > --- a/tests/test-hmac-sha1.c > +++ b/tests/test-hmac-sha1.c > @@ -17,43 +17,51 @@ > /* Written by Simon Josefsson. */ > > #include > +#include > +#include > +#include > > #include "hma

grantpt: Remove unnecessary dependency

2018-09-30 Bruno Haible grantpt: Remove unnecessary dependency. * modules/grantpt (Depends-on): Remove 'builtin-expect'. diff --git a/modules/grantpt b/modules/grantpt index 486bb85..38675b6 100644 --- a/modules/grantpt +++ b/modules/grantpt @@ -9,7 +9,6 @@ m4/grantpt.m4 Depen

Re: timevar: small tweaks

Hi Akim, Thanks for the review. > > - It is pointless to omit the parameter names from the function > > declarations > >if the comments talk about TIMEVAR, ELAPSED, FP, etc. > > Here, I don’t understand why you commented the argument names. > It would be clearer with them uncommented. Thi

Re: timevar: documentation

Akim Demaille wrote: > Your patch is fine, of course. OK, pushed. Bruno

Re: __builtin_expect used in regex

Hi Arnold, > Nelson, please chime in with a list of the system + compiler combinations > where gawk needs this patch. Basically, all platforms with a non-GCC compiler will need this patch. Think of Solaris cc, HP-UX cc, native Windows with MSVC... > As I mentioned, this is really a gnulib > issu

__builtin_expect used in regex

Hello GNULIB guys. Pleae see the patch below which Nelson needs in order to compile gawk on several of his systems. This comes from the use of the BE macro in regex. Nelson, please chime in with a list of the system + compiler combinations where gawk needs this patch. As I mentioned, this is re

Re: timevar: small tweaks

Hi Bruno, > Le 30 sept. 2018 à 01:09, Bruno Haible a écrit : > > Hi Akim, > > How about the following patches: > > * In timevar.c: Include timevar.h first. This is a Gnulib best practice, which > has the benefit of verifying that the header file is self-contained. > > * In timevar.def: > -

Re: timevar: documentation

Hi Bruno! Thanks a lot for you help! > Le 30 sept. 2018 à 01:01, Bruno Haible a écrit : > > Hi Akim, > > How about the following patch to: > - include timevar.texi in the Gnulib documentation, Bummer. I had convinced myself this was automated. > - mention '#include ', needed for stderr, > -

Re: Would timevar be accepted in gnulib?

Hi Bruno! > Le 29 sept. 2018 à 19:54, Bruno Haible a écrit : > > Hi Akim, > >> Here is my initial proposal for timevar in gnulib. > > Thanks! The code looks well-commented now. > > I pushed it for you, Thanks! > after completing the ChangeLog entry. 8-)=) Sorry, I completely forgot that…

Re: [bug #33724] Find command is changing the access time of directory

On 9/30/18 2:01 AM, Paul Eggert wrote: > Bernhard Voelker wrote: >> a) rename FTS_NOATIME to FTS_NOATIME, and add a retry to open/openat >> in each place when that was using O_NOATIME and we got EPERM. > > I didn't quite get the point of the rename; those two identifiers look > identical > to me