Re: [PATCH] lib/vasnprintf.c: Add information to make integer comparison logical

[Bruno Haible]

Hi Bjarni,

Haven't heard back from you in a week. So I'm applying this patch.


2018-09-30  Bruno Haible  <br...@clisp.org>

        vasnprintf: Avoid warnings from GCC's -Wsign-compare.
        Reported by Bjarni Ingi Gislason <bjarn...@rhi.hi.is> in
        <https://lists.gnu.org/archive/html/bug-gnulib/2018-09/msg00105.html>.
        * lib/vasnprintf.c (VASNPRINTF): Cast 'count' from 'int' to
        'unsigned int' before comparison with an unsigned value.

diff --git a/lib/vasnprintf.c b/lib/vasnprintf.c
index 30d021b..af3fcd1 100644
--- a/lib/vasnprintf.c
+++ b/lib/vasnprintf.c
@@ -2696,7 +2696,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp,
                               errno = EILSEQ;
                               return NULL;
                             }
-                          if (precision < count)
+                          if (precision < (unsigned int) count)
                             break;
                           arg_end++;
                           characters += count;
@@ -5127,7 +5127,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp,
                       {
                         /* Verify that snprintf() has NUL-terminated its
                            result.  */
-                        if (count < maxlen
+                        if ((unsigned int) count < maxlen
                             && ((TCHAR_T *) (result + length)) [count] != '\0')
                           abort ();
                         /* Portability hack.  */