Re: [PING] [PATCH 00/17] Regex: Make libc regex more usable outside GLIBC

2017-12-19 Thread Paul Eggert
On 12/19/2017 07:42 PM, Carlos O'Donell wrote: I just committed the obvious comment fixes into glibc. I expect Paul to commit something similar to gnulib Already done, way back in 2012 when I wrote and installed spelling-check fixes for Gnulib, here: http://git.savannah.gnu.org/cgit/gnulib.

Re: [PING] [PATCH 00/17] Regex: Make libc regex more usable outside GLIBC

2017-12-19 Thread Carlos O'Donell
On 12/19/2017 11:42 AM, arn...@skeeve.com wrote: > I do appreciate that the trend is to merge with gnulib; that will > ultimately be a good thing so I am encouraged by it. I just committed the obvious comment fixes into glibc. I expect Paul to commit something similar to gnulib and that way we wo

Re: [PATCH 01/17] Regex: Fix spelling errors / typos.

2017-12-19 Thread Carlos O'Donell
On 12/19/2017 02:03 PM, Paul Eggert wrote: > These typo changes are all in Gnulib, and would be fine to install in glibc. > > Adding bug-gnulib to the CC list. For reference, the original email is here: > https://sourceware.org/ml/libc-alpha/2017-12/msg00243.html Done. I've pushed these for Arnol

Re: [PATCH 07/17] Regex: Additional memory management checks.

2017-12-19 Thread Paul Eggert
On 12/08/2017 01:16 AM in Arnold Robbins wrote: + /* some malloc()-checkers don't like zero allocations */ + if (preg->re_nsub > 0) dfa->subexp_map = re_malloc (int, preg->re_nsub); + else +dfa->subexp_map = NULL; Which ch

Re: [PATCH 06/17] Regex: Use re_malloc / re_free consistently.

2017-12-19 Thread Paul Eggert
On 12/08/2017 01:16 AM, Arnold Robbins wrote: This patch changes several calls to malloc/free into re_malloc/re_free, bringing consistency to the code. Thanks, that patch makes sense, but it misses three opportunities to bring consistency. regcomp.c has one call each to malloc and free, which

Re: [PATCH 01/17] Regex: Fix spelling errors / typos.

2017-12-19 Thread Zack Weinberg
On Tue, Dec 19, 2017 at 2:03 PM Paul Eggert wrote: > These typo changes are all in Gnulib, and would be fine to install in > glibc. > > Adding bug-gnulib to the CC list. For reference, the original email is > here: > https://sourceware.org/ml/libc-alpha/2017-12/msg00243.html I don’t think Arnol

Re: [PATCH 01/17] Regex: Fix spelling errors / typos.

2017-12-19 Thread Paul Eggert
These typo changes are all in Gnulib, and would be fine to install in glibc. Adding bug-gnulib to the CC list. For reference, the original email is here: https://sourceware.org/ml/libc-alpha/2017-12/msg00243.html

Re: [PING] [PATCH 00/17] Regex: Make libc regex more usable outside GLIBC

2017-12-19 Thread arnold
Hello. Thanks for cluing me into the discussion. > As I understand it, Arnold's patches are against glibc. Arnold, would it > be too much trouble to rebase them against gnulib instead? Absolutely too much trouble. Sorry. I think that most or all of the changes are in gnulib's regex, but the gnu

Re: [PING] [PATCH 00/17] Regex: Make libc regex more usable outside GLIBC

2017-12-19 Thread Zack Weinberg
On Tue, Dec 19, 2017 at 9:56 AM, Adhemerval Zanella wrote: > On 19/12/2017 15:43, Paul Eggert wrote: >> On 12/19/2017 04:52 AM, Adhemerval Zanella wrote: >>> Again, my understanding is we still aim to keep it in sync with gnulib, >>> so I think we should first integrate with current gnulib code on

Re: [PING] [PATCH 00/17] Regex: Make libc regex more usable outside GLIBC

2017-12-19 Thread Adhemerval Zanella
On 19/12/2017 15:43, Paul Eggert wrote: > On 12/19/2017 04:52 AM, Adhemerval Zanella wrote: >> Again, my understanding is we still aim to keep it in sync with gnulib, >> so I think we should first integrate with current gnulib code on glibc >> side (in same approach as we did for current glob cha

Re: [PING] [PATCH 00/17] Regex: Make libc regex more usable outside GLIBC

2017-12-19 Thread Paul Eggert
On 12/19/2017 04:52 AM, Adhemerval Zanella wrote: Again, my understanding is we still aim to keep it in sync with gnulib, so I think we should first integrate with current gnulib code on glibc side (in same approach as we did for current glob changes). As I understand it, Arnold's patches are a

Re: Unneeded compiler warning in glob.c

2017-12-19 Thread Adhemerval Zanella
On 15/12/2017 23:30, Paul Eggert wrote: > On 12/13/2017 01:38 AM, Tim Rühsen wrote: >> Here is a patch to silence this warning: >> >> glob.c: In function 'rpl_glob': >> glob.c:618:64: warning: pointer of type 'void *' used in arithmetic >> [-Wpointer-arith] >>     err = getpwn