Re: Is Gnulib still targeting C89?

2017-04-26 Thread Paul Eggert
Tim Rice wrote: Sad to hear gnulib doesn't care about C89. UnixWare (a currently shipping product) has a C89 compiler. That should be OK as UnixWare's supplier also supports GCC, and recommends GCC for compiling Gnu-style applications. http://osr507doc.xinuos.com/en/DevSysoview/Ccompil.html#

Re: what shall we do with the drunken time_t ?

2017-04-26 Thread Paul Eggert
Bruno Haible wrote: if we want a sane behaviour, we have no choice than to override stat() and fstat() What a pain. Would it be limited to just those two? For example, is there a system call like utimensat that lets you set a file's timestamps?

[PATCH] nap.h: Fix compilation on non windows platforms

2017-04-26 Thread Pádraig Brady
* tests/nap.h: Move misplaced endif. --- ChangeLog | 5 + tests/nap.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 314f7d9..12ccfc1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,4 +1,9 @@ 2017-04-26 Pádraig Brady + + nap.h: Fix co

[PATCH] time_rz: fix heap buffer overflow vulnerability

2017-04-26 Thread Pádraig Brady
This issue has been assigned CVE-2017-7476 and was detected with American Fuzzy Lop 2.41b run on the coreutils date(1) program with ASAN enabled. ERROR: AddressSanitizer: heap-buffer-overflow on address 0x... WRITE of size 8 at 0x60d0cff8 thread T0 #1 0x443020 in extend_abbrs lib/time_rz

Re: Is Gnulib still targeting C89?

2017-04-26 Thread Tim Rice
On Sun, 23 Apr 2017, Paul Eggert wrote: > Pádraig Brady wrote: > > In general gnulib is still targeting c89 right? > > BTW, when should we update that requirement? > > Now is a good time. As far as I know, no Gnulib-using application still > requires porting to C89-only platforms. Although we sti

new module 'noreturn'

2017-04-26 Thread Bruno Haible
Here's a proposed module 'noreturn' (attached). The most interesting file is this one: lib/noreturn.h /* Macros for declaring functions as non-returning. Copyright (C) 2017 Free Software Foundation, Inc. This program is free

Re: clang and _Noreturn

2017-04-26 Thread Bruno Haible
Hi Paul, > > it's better ignore which > > parts of the API will be used frequently or rarely. Better think only at > > how easy it is to remember each item. > > Even if that's the criterion, I find it easier to remember "use _GL_NORETURN > for > most noreturn cases, and use _GL_ATTRIBUTE_NORETU

Re: clang and _Noreturn

2017-04-26 Thread Bruno Haible
I wrote: > I guess I need to test things with some older versions of gcc and g++ as well, > and with MSVC, before we can jump to conclusions. Here are the results. Let 1, 2, 3, 4, 5 denote the respective positions: XX extern void foo1 (void); extern XX void foo2 (void); extern void XX foo3 (void);

Re: what shall we do with the drunken time_t ?

2017-04-26 Thread Bruno Haible
Hi Paul, > Your latest message prompted me to search microsoft.com further, and I > found this: > > https://support.microsoft.com/en-us/help/190315 Excellent finding! Thank you. > I wonder whether Cygwin deals with this problem? Cygwin's stat() implementation converts the times (from FILETIME