On 07/16/2015 04:19 PM, Jim Meyering wrote:
echo "$final_modules" | LC_ALL=C grep '^extensions$' >/dev/null \
why would we need LC_ALL here at all? IMO this is sufficient:
echo "$final_modules" | grep '^extensions$' >/dev/null \
btw: one could even completely avoid the "| grep" by let
On Thursday 16 of July 2015 07:19:37 Jim Meyering wrote:
> Please change that to use LC_ALL=C rather than LANG=C.
> LC_ALL supercedes all other LC_* variables. LANG=... used to be
> relevant with old glibc, but even then, that was contrary to POSIX.
>
> Also, prefer single quotes around the regexp
On Thu, Jul 16, 2015 at 6:58 AM, Pavel Raiskup wrote:
> On Tuesday 14 of July 2015 06:29:15 Eric Blake wrote:
>> Overall, seems like it is correct, once you fix the typos.
>
> Thanks for your review, fixed patch attached.
Thanks for the patch.
Haven't reviewed thoroughly, but did see this:
+
On Tuesday 14 of July 2015 06:29:15 Eric Blake wrote:
> Overall, seems like it is correct, once you fix the typos.
Thanks for your review, fixed patch attached.
Pavel
>From cc0cd1c751d54af0d7211e321f40ce99b0f68b62 Mon Sep 17 00:00:00 2001
From: Pavel Raiskup
Date: Thu, 2 Jul 2015 13:58:22 +0200
On 07/16/2015 05:56 AM, Normand wrote:
> Hi there,
> I am looking at the test-lock failure reported by (1) while findutils
> building in opensuse for ppc64le architecture.
> Helgrind is reporting data race for the three *_checker_done volatiles
> as summarized in (2)
>
> Is is a false positive or
Hi there,
I am looking at the test-lock failure reported by (1) while findutils building
in opensuse for ppc64le architecture.
Helgrind is reporting data race for the three *_checker_done volatiles as
summarized in (2)
Is is a false positive or a real problem ?
(1) https://bugzilla.suse.com/sh
