On Thu, Jul 16, 2015 at 6:58 AM, Pavel Raiskup <prais...@redhat.com> wrote: > On Tuesday 14 of July 2015 06:29:15 Eric Blake wrote: >> Overall, seems like it is correct, once you fix the typos. > > Thanks for your review, fixed patch attached.
Thanks for the patch. Haven't reviewed thoroughly, but did see this: + # We need to call gl_USE_SYSTEM_EXTENSIONS before gl_PROG_AR_RANLIB. Doing + # AC_REQUIRE in configure-ac.early is not early enough. + echo "$final_modules" | LANG=C grep "^extensions$" >/dev/null \ + && echo " AC_REQUIRE([gl_USE_SYSTEM_EXTENSIONS])" Please change that to use LC_ALL=C rather than LANG=C. LC_ALL supercedes all other LC_* variables. LANG=... used to be relevant with old glibc, but even then, that was contrary to POSIX. Also, prefer single quotes around the regexp, when possible: echo "$final_modules" | LC_ALL=C grep '^extensions$' >/dev/null \
