Re: [PATCH] Added a module stringops that provides STREQ and STRNEQ

2014-05-23 Thread Jim Meyering
On Thu, May 22, 2014 at 12:04 AM, Paul Eggert wrote: > Jim Meyering wrote: >> >> What about the conflict with modules/streq? >> There are over 300 uses of STREQ in gnulib and coreutils. >> Are you suggesting to change all of those? > > > Yes. But if this is too much all at once, let's just call t

[PATCH][BZ #16907] Sync argp.h __attribute__ with gnulib.

2014-05-23 Thread Ondřej Bílka
On Fri, May 23, 2014 at 07:53:11AM -0700, Paul Eggert wrote: > Ondřej Bílka wrote: > >CCing gnulib. Could this be backported also there or do you have > >different solution? > > We solved this problem in a different way years ago, using something > like this: > > #if __GNUC__ > 2 || (__GNUC__ ==

Re: [PATCH][BZ #16907] Do not disable __attribute__ when you include argp.h

2014-05-23 Thread Paul Eggert
Ondřej Bílka wrote: CCing gnulib. Could this be backported also there or do you have different solution? We solved this problem in a different way years ago, using something like this: #if __GNUC__ > 2 || (__GNUC__ == 2 && __GNUC_MINOR >= 7) # define _GL_ATTRIBUTE_FORMAT(s) __attribute__ ((_

Re: [PATCH][BZ #16907] Do not disable __attribute__ when you include argp.h

2014-05-23 Thread Ondřej Bílka
On Mon, May 19, 2014 at 08:37:27AM +0100, Will Newton wrote: > On 18 May 2014 13:57, Ondřej Bílka wrote: > > Hi, > > > > As written in bug report: > > > > " > > When is included first and thus __attribute__ is not defined, > > with -std=c90, c99 or c11, the __attribute__ is redefined as empty due