Re: Improve Gnulib's ability to compile on FreeBSD

2011-12-23 Thread Bruno Haible
Hello Tom, Thanks for the proposed patch. However, it is probably incomplete: need_charset_alias=false is only possible if the libc has nl_langinfo(CODESET) *and* it always returns the codesets normalized in the GNU way. It is possible that some newer version of FreeBSD has nl_langinfo(CODESET).

Re: [PATCH] standards: rewrite section on quoting

2011-12-23 Thread Karl Berry
use "X" when X should be translated, and 'X' when X should not be translated. I don't see that clearly stated in the patch. I can try to add it if you wish (if I'm not just missing it, quite possible). -(Fexecute_extended_command): Deal with `keymap' property. +(Fexecute_extended

Re: [PATCH] standards: rewrite section on quoting

2011-12-23 Thread Paul Eggert
On 12/23/11 04:09, Bruno Haible wrote: > Personally I use single-quoting (apostrophes) when quoting identifiers That sounds reasonable, and is less intrusive than that what I proposed. As I understand it, the idea is to use "X" when X should be translated, and 'X' when X should not be translated.

Re: Improve Gnulib's ability to compile on FreeBSD

2011-12-23 Thread Paul Eggert
For what it's worth, I found a similar patch for another FreeBSD package. Alas, it's equally terse: ftp://ftp2.pl.freebsd.org/pub/FreeBSD/current/ports/misc/gnuit/files/patch-lib-Makefile

Re: Improve Gnulib's ability to compile on FreeBSD

2011-12-23 Thread Eric Blake
On 12/23/2011 02:38 PM, Tom Limoncelli wrote: > On Fri, Dec 23, 2011 at 9:28 AM, Eric Blake wrote: >> That doesn't help much - gnulib/lib/Makefile.am is either a generated >> file, or a wrapper around a generated gnulib.mk include snippet, and you >> didn't even tell us which project this was on,

Re: Improve Gnulib's ability to compile on FreeBSD

2011-12-23 Thread Tom Limoncelli
On Fri, Dec 23, 2011 at 9:28 AM, Eric Blake wrote: > That doesn't help much - gnulib/lib/Makefile.am is either a generated > file, or a wrapper around a generated gnulib.mk include snippet, and you > didn't even tell us which project this was on, so we don't know which > gnulib modules were in use

Re: Improve Gnulib's ability to compile on FreeBSD

2011-12-23 Thread Paul Eggert
On 12/23/11 06:28, Eric Blake wrote: > Can you post the actual compile failure you are seeing, and provide more > details why adding freebsd to the list avoids the failures? I agree that more info is needed. Undoubtedly he's suggesting a change to Gnulib's modules/localcharset file. Possibly fr

Re: [Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same "date line"

2011-12-23 Thread Stefano Lattarini
On 12/23/2011 05:19 PM, Jim Meyering wrote: >>> However, I would prefer an adaptive/hybrid solution: if a commit log >>> is composed of two or more paragraphs, keep it in a separate block. >>> Otherwise, merge entries that would otherwise have a date--name--email >>> header identical to the precedi

Re: [Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same "date line"

2011-12-23 Thread Jim Meyering
Stefano Lattarini wrote: > On 12/23/2011 04:11 PM, Jim Meyering wrote: >> >> Stefano Lattarini wrote: >> >>> I hope the above argument will make you reconsider this position; >>> ... >> >> Position? I had not taken a position. Any feature request should be >> accompanied by justification. The q

Re: [Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same "date line"

2011-12-23 Thread Stefano Lattarini
On 12/23/2011 04:11 PM, Jim Meyering wrote: > > Stefano Lattarini wrote: > >> I hope the above argument will make you reconsider this position; >> ... > > Position? I had not taken a position. Any feature request should be > accompanied by justification. The questions above were simply my attem

[PATCH] test-framework-sh: distribute init.sh

2011-12-23 Thread Jim Meyering
Without the patch below, I found out right away (thanks to the Nixos/Hydra autobuilder) that grep's make distcheck would fail every init.sh-using test: http://hydra.nixos.org/build/1653876/log/raw E.g., FAIL: test-exclude2.sh (exit: 1) ./test-excl

Re: [Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same "date line"

2011-12-23 Thread Jim Meyering
Stefano Lattarini wrote: > On 12/23/2011 03:38 PM, Jim Meyering wrote: >> Stefano Lattarini wrote: >>> Hello Gnulibers. >>> >>> Currently, the `gitlog-to-changelog' script clusters ChangeLog entries with >>> the same date together, placing them under a single "date line" in the >>> generated output

Re: [Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same "date line"

2011-12-23 Thread Stefano Lattarini
On 12/23/2011 03:38 PM, Jim Meyering wrote: > Stefano Lattarini wrote: >> Hello Gnulibers. >> >> Currently, the `gitlog-to-changelog' script clusters ChangeLog entries with >> the same date together, placing them under a single "date line" in the >> generated output. >> >> So we have something like

Re: [Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same "date line"

2011-12-23 Thread Jim Meyering
Stefano Lattarini wrote: > Hello Gnulibers. > > Currently, the `gitlog-to-changelog' script clusters ChangeLog entries with > the same date together, placing them under a single "date line" in the > generated output. > > So we have something like this: > > > $ ./build-aux/gitlog-to-changelog -- -

Re: Improve Gnulib's ability to compile on FreeBSD

2011-12-23 Thread Eric Blake
On 12/23/2011 04:22 AM, Tom Limoncelli wrote: > I can't take credit for this... it comes from: > https://svn.csub.edu/p/freebsd/browser/freebsd/ports/trunk/textproc/augeas/files/patch-gnulib%3A%3Alib%3A%3AMakefile.am?rev=73 > > --- gnulib/lib/Makefile.am.orig 2010-04-28 14:46:00.0 -0700 >

Improve Gnulib's ability to compile on FreeBSD

2011-12-23 Thread Tom Limoncelli
I can't take credit for this... it comes from: https://svn.csub.edu/p/freebsd/browser/freebsd/ports/trunk/textproc/augeas/files/patch-gnulib%3A%3Alib%3A%3AMakefile.am?rev=73 --- gnulib/lib/Makefile.am.orig 2010-04-28 14:46:00.0 -0700 +++ gnulib/lib/Makefile.am      2010-04-28 14:47:00.

Re: [PATCH] init.sh: new module, and add minimal tests of its compare function

2011-12-23 Thread Jim Meyering
Bruno Haible wrote: > Jim Meyering wrote: >> +License: >> +GPLed build tool > > Hmm, for me, init.sh is not a "build tool" but rather a simple piece of tests > code. I would mark it as 'GPL'. This would be consistent with what the Makes sense. I've adjusted. > documentation [1] states about the

[Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same "date line"

2011-12-23 Thread Stefano Lattarini
Hello Gnulibers. Currently, the `gitlog-to-changelog' script clusters ChangeLog entries with the same date together, placing them under a single "date line" in the generated output. So we have something like this: $ ./build-aux/gitlog-to-changelog -- -n 2 76d222b 2011-12-22 Jim Meyering

Re: [PATCH] init.sh: new module, and add minimal tests of its compare function

2011-12-23 Thread Bruno Haible
Jim Meyering wrote: > +License: > +GPLed build tool Hmm, for me, init.sh is not a "build tool" but rather a simple piece of tests code. I would mark it as 'GPL'. This would be consistent with what the documentation [1] states about the license of test code. If this requires some change in gnulib-

Re: [PATCH] standards: rewrite section on quoting

2011-12-23 Thread Bruno Haible
Paul Eggert wrote: > I grew up with "I'm hungry" rather than 'I'm hungry' Me too (in English). Personally I use single-quoting (apostrophes) when quoting identifiers, like @code{} in TeXinfo: 'struct tm' The 'sentinel' attribute was added in gcc 4.0. and double-quoting when quoting parts of E

Re: [PATCH] init.sh: new module, and add minimal tests of its compare function

2011-12-23 Thread Jim Meyering
Bruno Haible wrote: >> * modules/init.sh: New file. > > The module name 'init.sh' is not self-explanatory. How about one of these: > test-framework > test-frame > test-framework-sh > The latter name is because it is not impossible that someday we get also > a test framework as a C program, li

Re: [PATCH] standards: rewrite section on quoting

2011-12-23 Thread Paolo Bonzini
On 12/23/2011 10:07 AM, Paul Eggert wrote: [Adding bug-gnulib since I'm attaching a gnulib patch.] On 12/23/11 00:22, Paolo Bonzini wrote: This permits GNU gettext to replace the string @code{"Processing file ! \"%s\"..."} with a translated version. This is ugly... How about if we chang