On 12/23/2011 02:38 PM, Tom Limoncelli wrote: > On Fri, Dec 23, 2011 at 9:28 AM, Eric Blake <ebl...@redhat.com> wrote: >> That doesn't help much - gnulib/lib/Makefile.am is either a generated >> file, or a wrapper around a generated gnulib.mk include snippet, and you >> didn't even tell us which project this was on, so we don't know which >> gnulib modules were in use. > > Sorry for the terseness. I'm just learning the protocol for > submitting patches here. I should have included this diff instead: > > diff --git a/modules/localcharset b/modules/localcharset > index 8d01706..f2c20b4 100644 > --- a/modules/localcharset > +++ b/modules/localcharset > @@ -47,7 +47,7 @@ install-exec-localcharset: all-local > case '$(host_os)' in \ > darwin[56]*) \ > need_charset_alias=true ;; \ > - darwin* | cygwin* | mingw* | pw32* | cegcc*) \ > + darwin* | cygwin* | mingw* | pw32* | cegcc* | freebsd*) \ > need_charset_alias=false ;; \ > *) \ > need_charset_alias=true ;; \ > > As Paul said, yes, it is in modules/localcharset. > >> Can you post the actual compile failure you are seeing, and provide more >> details why adding freebsd to the list avoids the failures? > > Sadly I can't reproduce the failure myself. (It may be a lack of > understanding on my part). This patch appeared in the list of patches > packaged with the FreeBSD port of Augeas (which depends on gnulib).
Can you please forward this on to the person that made this patch in the FreeBSD port, and ask them about it? If it matters to them enough to patch generated files in multiple projects, they would be better served by directly telling us about the problem so that we can get it fixed for all packages at once. Meanwhile, there's nothing you need to do in Augeas, other than to continue to track up-to-date gnulib - if someone from the FreeBSD camp can explain why the patch is useful, then we can probably include it, and it will filter down into Augeas the next time you update gnulib. You don't need to maintain the patch locally in Augeas - either it's useful for FreeBSD porting (and the FreeBSD folks can be in charge of it, and continue to reapply it as part of their porting efforts), or it's useful globally (and gnulib can be in charge of it), but you shouldn't have to worry about the one-off consequences of carrying or dropping the patch (because then every other gnulib client that uses localcharset would have to carry the same one-off patch). -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
