Re: [PATCH] include_next: silence autoconf 2.68 warning

On 08/26/2010 06:29 PM, Bruno Haible wrote: Eric Blake wrote: +m4_define_default([AC_LANG_DEFINES_PROVIDED]) m4_define_default is not documented. Actually, it is (but merely minutes before this patch): http://lists.gnu.org/archive/html/autoconf-patches/2010-08/msg00081.html -- Eric Blake

Re: [PATCH] include_next: silence autoconf 2.68 warning

Eric Blake wrote: > +m4_define_default([AC_LANG_DEFINES_PROVIDED]) m4_define_default is not documented. But since it is present since at least autoconf-2.54, I think the risk of using it is low. Bruno

[PATCH 2/2] lib-symbol-versions: fix m4 quoting

* m4/ld-version-script.m4 (gl_LD_VERSION_SCRIPT): Use correct format for AC_LINK_IFELSE. Signed-off-by: Eric Blake --- Last one, at least according to an autoconf run on: gnulib-tool --create-testdir --dir=t $(gnulib-tool --list) as that was faster than waiting for --create-megatestdir to comp

[PATCH 1/2] glob: fix compile test

* m4/glob.m4 (gl_GLOB): Use correct format for AC_COMPILE_IFELSE. Signed-off-by: Eric Blake --- More of the same fixes. ChangeLog |3 +++ m4/glob.m4 | 10 +- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index 97f40d8..d526df2 100644 --- a/

[PATCH] btowc: fix missing file

Detected by: AUTOCONF="autoconf -Werror" ./gnulib-tool --test btowc configure.ac:111: warning: gt_LOCALE_FR is m4_require'd but not m4_defun'd glm4/btowc.m4:7: gl_FUNC_BTOWC is expanded from... configure.ac:27: gl_INIT is expanded from... configure.ac:111: the top level * modules/btowc (Files): A

[PATCH] lseek: fix link test

Another bug spotted by autoconf. * m4/lseek.m4 (gl_FUNC_LSEEK): Use correct format for AC_LINK_IFELSE. Signed-off-by: Eric Blake --- This is the last buggy use spotted among coreutils' choice of modules; but there are probably others lurking in gnulib. I haven't yet tried if gnulib-tool --crea

[PATCH] include_next: silence autoconf 2.68 warning

Next warning spotted by Autoconf; this time it is spurious (when checking for a working include_next, we could care less what other defines have already been provided by AC_DEFINE). Which makes this the first real-world use case outside of autoconf guts that can reasonably use the new autoconf mac

[PATCH] acl: fix compilation test

* m4/acl.m4 (gl_FUNC_ALL): Use correct format for AC_COMPILE_IFELSE. Signed-off-by: Eric Blake --- Thanks again, Bruno, for insisting that I make AC_COMPILE_IFELSE do some sanity checking. It caught this bug. ChangeLog |6 ++ m4/acl.m4 |6 +++--- 2 files changed, 9 insertions(+),

Re: stat-time -> LGPLv3+

Hi Jim, Jim Meyering writes: > * modules/stat-time (License): Change from GPL to LGPL, > with consent from all contributors, for use in libguile. Thanks! Ludo’.

Re: avoiding obsolete macros like AC_TRY_RUN

On 2010-07-20 I wrote: > > > - Pitfall: It's easy to forget the invocation of AC_LANG_SOURCE, and > > > then > > >autoconf generates code which will fail on many but not all > > > platforms. > > > > We should think about what we can do to address this, thanks for the > > suggestion.

Re: stat-time -> LGPLv3+

Ludovic Courtès wrote: > James Youngman writes: > >> On Tue, Jul 27, 2010 at 12:32 AM, Bruno Haible wrote: >>> [Adding James to the CC] >>> > We’d like to use ‘stat-time’ in libguile, but libguile is LGPLv3+. > Could you make the license change? Or LGPL v2.1+ too. An

Re: [bug #30868] Take advantage of dirent.d_type to save a stat()

Eric Blake wrote: > > > > > > In lib/savedir.c, in isdir1() (or the code that calls it), the d_type member > > of the dirent struct can be checked instead of doing a comparatively > > expensive > > isdir() (which calls stat()). > > Thanks for the suggestio

Re: lib/poll.c win32 deadlock

On 08/25/2010 06:51 PM, Erik Faye-Lund wrote: On Wed, Aug 25, 2010 at 11:50 AM, Paolo Bonzini wrote: On 08/25/2010 11:48 AM, Erik Faye-Lund wrote: Actually, when I think of it - if any pipe got POLLHUP already, shouldn't poll just return right away? I mean, we already have an event, waiting i