Eric Blake wrote: > > <http://savannah.gnu.org/bugs/?30868> > > > > In lib/savedir.c, in isdir1() (or the code that calls it), the d_type member > > of the dirent struct can be checked instead of doing a comparatively > > expensive > > isdir() (which calls stat()). > > Thanks for the suggestion; adding bug-gnulib, since this code is > maintained there and shared by several projects.
gnulib/lib/savedir.c and grep/lib/savedir.c have diverged long ago. The one in gnulib does not call isdir at all. The one in grep takes include / exclude arguments for filtering the result, which users of gnulib's savedir don't need. So, IMO, this report is best handled on grep's side alone. Bruno
