John W. Eaton wrote:
> Would the following patch be OK for recognizing Mercurial in the
> build-aux/bootstrap script? It seems to work for me. Maybe there is
> a better way of recognizing that a file is tracked, but I'm not sure
> what it is.
Can you investigate that?
It'd be good to have a defi
On 14-Nov-2009, Jim Meyering wrote:
| John W. Eaton wrote:
| > Is there any reason that the strftime.h header in gnulib does not use
| > extern "C"? If not, then would the following patch be OK?
|
| No one asked for it.
| I've pushed this:
Thanks!
jwe
Would the following patch be OK for recognizing Mercurial in the
build-aux/bootstrap script? It seems to work for me. Maybe there is
a better way of recognizing that a file is tracked, but I'm not sure
what it is. Unfortunately, "hg status FILE" exits with a status of 0
even when FILE does not e
John W. Eaton wrote:
> Is there any reason that the strftime.h header in gnulib does not use
> extern "C"? If not, then would the following patch be OK?
No one asked for it.
I've pushed this:
>From ee8909a98bbfffc6317e1e9273e1cb8d6341ea25 Mon Sep 17 00:00:00 2001
From: John W. Eaton
Date: Sat,
Eric Blake wrote:
> According to Eric Blake on 11/13/2009 11:35 AM:
>>> Are you approaching a good cut-off point?
>>
>> I've almost got chown working; expect patches later today.
>
> Here's my candidate under testing. It passed FreeBSD 7.2, but I still
> need to check it on Solaris 9.
...
> Subje
Pádraig Brady wrote:
>> Subject: [PATCH] bootstrap: sync from coreutils
>>
>> * build-aux/bootstrap (bootstrap_epilogue): New function.
>> Use git_modules_config in one more place. This make bootstrap's
>> --gnulib-srcdir option more useful for testing.
>
> Why does it make it more useful?
> With
Pádraig Brady wrote:
> I think the last check in timeout-parameters needs
> the same treatment?
>
> tests: avoid a spurious failure on a loaded system
>
> * tests/misc/timeout-parameters: This test would fail due to
> the 1-second timeout expiring before a command of "no_such"
> cou
Eric Blake wrote:
> According to Eric Blake on 11/12/2009 11:41 AM:
>> getgroups replaces a library function, so it should not exit(). On the other
>> hand, the mgetgroups interface from coreutils is much nicer to use (one call,
>> instead of 2); that would be a reasonable place to add an xalloc-d
Is there any reason that the strftime.h header in gnulib does not use
extern "C"? If not, then would the following patch be OK?
Thanks,
jwe
commit bf7fb16a0253f59bb1ec31e61bc92b1574e78633
Author: John W. Eaton
Date: Sat Nov 14 00:02:23 2009 -0500
strftime.h: wrap funtion declaration in
I think the last check in timeout-parameters needs
the same treatment?
cheers,
Pádraig.
commit 05327326c6f66650c685e26b777140782d300233
Author: Pádraig Brady
Date: Fri Nov 13 22:52:14 2009 +
tests: avoid a spurious failure on a loaded system
* tests/misc/timeout-parameters: This
Jim Meyering wrote:
> FYI,
>
>>From 9efa515cee4d1a40a41bdcd20e29932f8e2e5102 Mon Sep 17 00:00:00 2001
> From: Jim Meyering
> Date: Thu, 12 Nov 2009 09:49:39 +0100
> Subject: [PATCH] bootstrap: sync from coreutils
>
> * build-aux/bootstrap (bootstrap_epilogue): New function.
> Use git_modules_con
Eric Blake wrote:
> According to Eric Blake on 11/13/2009 11:35 AM:
>>> Are you approaching a good cut-off point?
>> I've almost got chown working; expect patches later today.
>
> Here's my candidate under testing. It passed FreeBSD 7.2, but I still
> need to check it on Solaris 9.
>
Wow the te
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 11/13/2009 11:35 AM:
>> Are you approaching a good cut-off point?
>
> I've almost got chown working; expect patches later today.
Here's my candidate under testing. It passed FreeBSD 7.2, but I still
need to check it on Sol
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 11/12/2009 11:41 AM:
> getgroups replaces a library function, so it should not exit(). On the other
> hand, the mgetgroups interface from coreutils is much nicer to use (one call,
> instead of 2); that would be a reasonabl
Eric Blake wrote:
> According to Eric Blake on 11/13/2009 11:35 AM:
>> I also discovered that
>> FreeBSD getgroups(-1,NULL) fails with EFAULT instead of EINVAL, which
>> means that it mistakenly populates a valid pointer rather than rejecting a
>> negative argument; should be easy to fix today.
>
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 11/13/2009 11:35 AM:
> I also discovered that
> FreeBSD getgroups(-1,NULL) fails with EFAULT instead of EINVAL, which
> means that it mistakenly populates a valid pointer rather than rejecting a
> negative argument; should be
Eric Blake wrote:
> According to Jim Meyering on 11/13/2009 8:41 AM:
>> - the second to avoid compilation failure on rawhide, presumably
>> due to its newer header files.
>
> More likely, due to a cygwin bug for exposing SIZE_MAX without requiring
> . Newer Linux is better about keeping he
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 11/13/2009 8:41 AM:
> - the second to avoid compilation failure on rawhide, presumably
> due to its newer header files.
More likely, due to a cygwin bug for exposing SIZE_MAX without requiring
. Newer Linux is bet
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 11/13/2009 2:14 AM:
>> Any problems with committing this series?
>>
>> Eric Blake (5):
>> getgroups: fix logic error
>> getgroups: avoid calling exit
>> getgroups: provide stub for mingw
>> getgroups
Eric Blake writes:
> According to Simon Josefsson on 11/13/2009 6:27 AM:
>> +++ b/tests/test-base64.c
>> @@ -20,10 +20,25 @@
>> #include
>> #include
>> #include
>> +#include
>> #include
>> +#include
>
> That looks redundant.
Thanks, fixed.
/Simon
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Simon Josefsson on 11/13/2009 6:27 AM:
> +++ b/tests/test-base64.c
> @@ -20,10 +20,25 @@
> #include
> #include
> #include
> +#include
> #include
> +#include
That looks redundant.
- --
Don't work too hard, make some time for fun
Inspired by
http://www.gnu.org/software/gnulib/coverage/gllib/base64.c.gcov.frameset.html
I improved the self-tests for the base64 module. Pushed.
/Simon
>From d1d75d5540bf75df8bc41c85b5a9fd111ca1f2dd Mon Sep 17 00:00:00 2001
From: Simon Josefsson
Date: Fri, 13 Nov 2009 14:25:50 +0100
Subject
Eric Blake writes:
> According to Simon Josefsson on 11/13/2009 2:53 AM:
>> +
>> + result = my_xasprintf ("");
>> + ASSERT (result != NULL);
>> + ASSERT (strcmp (result, "") == 0);
>> +
>
> Don't forget to free() result between each test, so that we don't keep
> leaking memory.
Thanks, fixed
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Simon Josefsson on 11/13/2009 2:53 AM:
> +
> + result = my_xasprintf ("");
> + ASSERT (result != NULL);
> + ASSERT (strcmp (result, "") == 0);
> +
Don't forget to free() result between each test, so that we don't keep
leaking memory.
Inspired by
http://www.gnu.org/software/gnulib/coverage/gllib/xvasprintf.c.gcov.frameset.html
I improved the xvasprintf self-check below.
/Simon
>From e718463703e9f7a3d60eeb360fca7efb2562c6b2 Mon Sep 17 00:00:00 2001
From: Simon Josefsson
Date: Fri, 13 Nov 2009 10:53:06 +0100
Subject: [PATCH]
All,
I prepared a code coverage report for gnulib:
http://www.gnu.org/software/gnulib/coverage/
There is a bug in the tool that results in duplicated */foo/foo
directories, but hopefully that will be debugged later on. The output
above should be useful to indicate where more self tests are need
Eric Blake wrote:
> These days, I'm not sure how many systems still need the getgroups replacement
> because the system getgroups is buggy. However, there is the issue of mingw,
> which lacks getgroups, and for that matter, any notion of group management
> (well, windows does have groups, as evide
27 matches
Mail list logo
