-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Jim Meyering on 11/13/2009 2:14 AM: >> Any problems with committing this series? >> >> Eric Blake (5): >> getgroups: fix logic error >> getgroups: avoid calling exit >> getgroups: provide stub for mingw >> getgroups: don't expose GETGROUPS_T to user >> mgetgroups: new module, taken from coreutils > > Good catch on that bug fix. > And hiding GETGROUPS_T is definitely the way to go. > These changes look fine. I'll test via coreutils, after you push.
Now pushed, with a bit more tweaking (getugroups also needed a stub for mingw). For that matter, I'm thinking of implementing grp.in.h and a setgroups wrapper to completely kill GETGROUPS_T in coreutils, but haven't done that for now. > I guess no one who used the replacement and who had users with 20 or > more groups ever noticed. How many users do you know in 20 or more groups? :) That, and the replacement doesn't kick in very much these days; none of the machines that I have access to needed it, as they all handled getgroups(0,ptr) correctly. - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkr9cocACgkQ84KuGfSFAYC/GwCfcYyVHzY5Dlmq1QkJSnUOUOg1 I9YAoL8htw2+a+Loawowhgk0FrJxSLdE =cEHt -----END PGP SIGNATURE-----
