Re: [PATCH] md5: accepts a new --threads option

2009-10-22 Thread Paolo Bonzini
On 10/22/2009 01:09 PM, Pádraig Brady wrote: Jim Meyering wrote: Pádraig Brady wrote: p.s. I'll look at bypassing stdio on input to see if I can get at least the 2% back IMHO, even if it did, it would not be worth it. Right, a quick test here shows only a 0.8% gain from bypassing stdio. Ho

Re: FTS not ready for a remount during traversal

2009-10-22 Thread Jim Meyering
Kamil Dudka wrote: ... >> > Any idea how to solve the problem? Thanks in advance! >> >> I don't see how we can justify any such change. >> Being able to detect whether the traversal returns to a previously >> visited directory is required for security and reliability. Weakening >> that device/inod

Re: [PATCH] md5: accepts a new --threads option

2009-10-22 Thread Jim Meyering
Pádraig Brady wrote: > Jim Meyering wrote: >> Pádraig Brady wrote: >> >>> p.s. I'll look at bypassing stdio on input to see >>> if I can get at least the 2% back >> >> IMHO, even if it did, it would not be worth it. > > Right, a quick test here shows only a 0.8% gain from > bypassing stdio. However

Re: [PATCH] md5: accepts a new --threads option

2009-10-22 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Pádraig Brady on 10/22/2009 5:09 AM: > digest routines in gnulib do fread(4096). > Bumping that up to 32KiB gives a 3% boost. Well spotted. > Does anyone have any objections to increasing > the stack requirement by 28672 bytes? None her

Re: [PATCH] md5: accepts a new --threads option

2009-10-22 Thread Pádraig Brady
Jim Meyering wrote: > Pádraig Brady wrote: > >> p.s. I'll look at bypassing stdio on input to see >> if I can get at least the 2% back > > IMHO, even if it did, it would not be worth it. Right, a quick test here shows only a 0.8% gain from bypassing stdio. However I also noticed that the digest