Re: [PATCH] poll: remove declarations of unused variables

Jim Meyering wrote: > Hi Paolo, > > Ok to apply this? Sure. > /* Tell gcc not to warn about the (nfd < 0) tests, below. */ > #if (__GNUC__ == 4 && 3 <= __GNUC_MINOR__) || 4 < __GNUC__ > # pragma GCC diagnostic ignored "-Wtype-limits" > #endif Ok too for this particular case, of course

Re: gnulib update broke clisp

> so you are saying that I cannot call AC_CONFIG_AUX_DIR($1) in > CL_MODULE_COMMON_CHECKS because other things required there must run > after it. Yes. > why can't I do > AC_REQUIRE([AC_CONFIG_AUX_DIR($1)]) > ?? > I get this: > warning: AC_CONFIG_AUX_DIR(../../../src/build-aux) is m4_require'd b

Re: Austin group ruling on ungetc vs. fflush

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 1/15/2009 6:09 PM: > "The value of the file-position indicator for the stream after > reading or discarding all pushed-back bytes shall be the same > as it was before the bytes were pus

Re: Build fail - Intrepid

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Pablo Diego on 1/15/2009 7:44 AM: > I can not build using Intrepid. > gcc -g -O2 -o m4 m4.o builtin.o debug.o eval.o format.o freeze.o input.o > macro.o output.o path.o symtab.o stackovf.o ../lib/libm4.a > m4.o: In function `usage': >

Re: Austin group ruling on ungetc vs. fflush

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 1/15/2009 4:24 PM: > The fflush-after-ungetc test fails on glibc, *BSD, mingw platforms. > This makes it work for glibc systems - at the cost of introducing a > slim override of fflush(). > > Eric, comments or objections?

Problems with gl_VSNPRINTF_ZEROSIZE_C99 under Sun C++ compiler

When gl_VSNPRINTF_ZEROSIZE_C99 is run under the Sun C++ compiler on a recent Solaris release, it fails because of: static char buf[8] = "DEADBEEF"; The compiler complains with: Error: Cannot use const char[9] to initialize char[8]. So, just replace `8' with `9'? gl_SNPRINTF_SIZE1 will have t

Re: gnulib update broke clisp

Sam Steingold wrote: > so you are saying that I cannot call AC_CONFIG_AUX_DIR($1) in > CL_MODULE_COMMON_CHECKS because other things required there must run > after it. Yes. > why can't I do > AC_REQUIRE([AC_CONFIG_AUX_DIR($1)]) > ?? Because of the way AC_REQUIRE is documented:

Re: gnulib update broke clisp

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Sam Steingold on 1/15/2009 2:40 PM: > so you are saying that I cannot call AC_CONFIG_AUX_DIR($1) in > CL_MODULE_COMMON_CHECKS because other things required there must run > after it. You cannot call it directly in CL_MODULE_COMMON_CHECKS,

Re: Austin group ruling on ungetc vs. fflush

This makes fflush after ungetc work on BSD systems. 2009-01-15 Bruno Haible Make fflush-after-ungetc POSIX compliant on BSD systems. * lib/fflush.c (clear_ungetc_buffer_preserving_position): New function. (clear_ungetc_buffer): Implement also for other systems.

Re: Austin group ruling on ungetc vs. fflush

Eric Blake wrote: > For more details, browse to > http://www.opengroup.org/austin/aardvark/latest/xshbug3.txt > and search for Enhancement Request Number 17 > > in particular, the new wording states that after fflush, "the file offset > of the underlying open file description shall be set to the f

Re: Austin group ruling on ungetc vs. fflush

The fflush-after-ungetc test fails on glibc, *BSD, mingw platforms. This makes it work for glibc systems - at the cost of introducing a slim override of fflush(). Eric, comments or objections? 2009-01-15 Bruno Haible Make fflush-after-ungetc POSIX compliant on glibc systems.

poll: avoiding more warnings

Hi Paolo, After the used-uninitialized bug Dan Berrange found in the windows-only part of poll.c, we've been motivated to enable more warnings when building libvirt's subset of gnulib, even (or rather especially) when cross-compiling for mingw. To that end, there are a few more warnings in poll.c

[PATCH] poll: remove declarations of unused variables

Hi Paolo, Ok to apply this? >From f446bd3210c4c9e708fb91677f9855c80eb90353 Mon Sep 17 00:00:00 2001 From: Daniel P. Berrange Date: Thu, 15 Jan 2009 22:29:34 +0100 Subject: [PATCH] poll: remove declarations of unused variables * lib/poll.c (poll) [WIN32_NATIVE]: Remove declarations of unused soc

Re: gnulib update broke clisp

On Thu, Jan 15, 2009 at 3:49 PM, Paolo Bonzini wrote: > Sam Steingold wrote: >> are you saying that AC_CONFIG_HEADERS calls AC_CANONICAL_BUILD?! > > No, that CL_MODULE_COMMON_CHECKS calls something that *requires* > AC_CANONICAL_BUILD. Required stuff is always expand before the > outermost call

Re: #ifndef _GL_WCHAR_H in lib/wchar.in.h

Albert Chin wrote: > I missed another > platform where this is a problem, IRIX. Using the same gnulib-tool > invocation as on HP-UX: > $ ./gnulib-tool --create-testdir --dir=t arpa_inet crypto/md5 \ > environ filemode fnmatch fnmatch-gnu getdate gettext glob human \ > iconv_open inet_pton lst

Re: gnulib update broke clisp

Sam Steingold wrote: > On Thu, Jan 15, 2009 at 2:51 PM, Paolo Bonzini wrote: >>> I decided to move AC_CONFIG_AUX_DIR($1) up: >> Move it reelll up. Just after AC_CONFIG_SRCDIR or if you don't >> have it, after AC_INIT. > > My configure.in is: > == configure.in

Re: MINT

Hello, Alan Hourihane wrote: > On platforms that don't have them yet, and because gnulib doesn't > support them (or use them currently) we need to change line 53 in > gai_strerror.c from > > #ifdef __USE_GNU > > to just... > > #if 0 > > Which allows gllib to build on platforms that don't have

Re: gnulib update broke clisp

On Thu, Jan 15, 2009 at 2:51 PM, Paolo Bonzini wrote: > >> I decided to move AC_CONFIG_AUX_DIR($1) up: > > Move it reelll up. Just after AC_CONFIG_SRCDIR or if you don't > have it, after AC_INIT. My configure.in is: == configure.in AC_PREREQ(2.57) AC_INIT(i18n

Re: #ifndef _GL_WCHAR_H in lib/wchar.in.h

On Thu, Jan 15, 2009 at 12:27:36AM +0100, Bruno Haible wrote: > > This causes a problem on HP-UX 11.00 because is included more > > than once. > > $ ./gnulib-tool --create-testdir --dir=t arpa_inet crypto/md5 \ > > environ filemode fnmatch fnmatch-gnu getdate gettext glob human \ > > iconv_o

Re: gnulib update broke clisp

> I decided to move AC_CONFIG_AUX_DIR($1) up: Move it reelll up. Just after AC_CONFIG_SRCDIR or if you don't have it, after AC_INIT. > AC_DEFUN([CL_MODULE_COMMON_CHECKS],[dnl > AC_CONFIG_AUX_DIR($1)dnl > AC_REQUIRE([AC_PROG_CC])dnl > AC_REQUIRE([AC_PROG_CPP])dnl > AC_REQUIRE([AC_GNU_SOU

Re: Problem with gl_REGEX and C++

Albert Chin wrote: > gl_REGEX from m4/regex.m4 cannot be reliably tested under C++. The > problem is: > static struct re_pattern_buffer regex; > unsigned char folded_chars[UCHAR_MAX + 1]; > ... > regex.translate = folded_chars; > > If the `translate'

lib/arpa_inet.in.h under C++

lib/arpa_inet.in.h needs the usual: #ifdef __cplusplus extern "C" { #endif ... #ifdef __cplusplus } #endif to work under C++. Patch attached. -- albert chin (ch...@thewrittenword.com) >From 36f93105aace962d70703887bfa633ca0c0f0638 Mon Sep 17 00:00:00 2001 From: Albert Chin-A-Youn

Problem with gl_REGEX and C++

gl_REGEX from m4/regex.m4 cannot be reliably tested under C++. The problem is: static struct re_pattern_buffer regex; unsigned char folded_chars[UCHAR_MAX + 1]; ... regex.translate = folded_chars; If the `translate' member is char * on some platforms

gnulib update broke clisp

Hi, I updated gnulib files in clisp (last time I did it was in late October), and now clisp configure scripts break. this can be tracked down to AC_CONFIG_AUX_DIR_DEFAULT being expanded _before_ my AC_CONFIG_AUX_DIR(../../src/build-aux), thus I have both == AC_CONFI

Re: MINT

Bruno, On platforms that don't have them yet, and because gnulib doesn't support them (or use them currently) we need to change line 53 in gai_strerror.c from #ifdef __USE_GNU to just... #if 0 Which allows gllib to build on platforms that don't have the extra definitions. Alan.

Re: more m4 quoting

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 1/15/2009 3:26 AM: >> # _AC_LANG_OPENMP(C) >> # -- >> -m4_define([_AC_LANG_OPENMP([C])], >> +m4_define([_AC_LANG_OPENMP(C)], > > Is this change really necessary? Yes. The _AC_LANG macros are _non-litera

Re: more m4 quoting

Bruno Haible wrote: > Simon Josefsson wrote: >> > If "C" must not be quoted, then shouldn't the quotes >> > around "C++" be dropped, too? >> >> I suppose, but I cannot trigger a problem. > > So, everyone is modifying this file based on guesswork? Stop, please. > > I wrote openmp.m4, incorporating

Re: more m4 quoting

Simon Josefsson wrote: > Jim Meyering writes: > >>> AC_DEFUN([_AC_LANG_OPENMP], >>> -[_AC_LANG_DISPATCH([$0], [_AC_LANG], [...@])]) >>> +[_AC_LANG_DISPATCH([$0], _AC_LANG, [...@])]) >> >> This one makes sense. >> It fails on etch because it has autoconf < 2.62, >> so the otherwise if'd out defin

Re: more m4 quoting

Bruno Haible writes: > Simon Josefsson wrote: >> > If "C" must not be quoted, then shouldn't the quotes >> > around "C++" be dropped, too? >> >> I suppose, but I cannot trigger a problem. > > So, everyone is modifying this file based on guesswork? Stop, please. > > I wrote openmp.m4, incorporati

Re: more m4 quoting

Simon Josefsson wrote: > > If "C" must not be quoted, then shouldn't the quotes > > around "C++" be dropped, too? > > I suppose, but I cannot trigger a problem. So, everyone is modifying this file based on guesswork? Stop, please. I wrote openmp.m4, incorporating magic from autoconf that I don't

Re: Austin group ruling on ungetc vs. fflush

Hi Eric, > A while ago, we wrote some unit tests that failed on a number of systems > with different behaviors of fflush after ungetc (particularly if you used > ungetc to push back a different byte than what was originally read). At > the time, Bruno ended up commenting the tests out until we ha

Re: more m4 quoting

Jim Meyering writes: >> AC_DEFUN([_AC_LANG_OPENMP], >> -[_AC_LANG_DISPATCH([$0], [_AC_LANG], [...@])]) >> +[_AC_LANG_DISPATCH([$0], _AC_LANG, [...@])]) > > This one makes sense. > It fails on etch because it has autoconf < 2.62, > so the otherwise if'd out definition in openmp.m4 is used. > The

Re: more m4 quoting

Simon Josefsson wrote: > Hi Jim. The patch breaks openmp on debian etch. The patch below fixes > it, but maybe the remaining quoting also cause problems if you use > fortran (I don't know how to test that). Hi Simon, Nice catch. > gnu...@mejsel:~$ gnulib-tool --test --with-tests openmp ... >

Re: more m4 quoting

Hi Jim. The patch breaks openmp on debian etch. The patch below fixes it, but maybe the remaining quoting also cause problems if you use fortran (I don't know how to test that). gnu...@mejsel:~$ gnulib-tool --test --with-tests openmp Module list with included dependencies: openmp File list:

Re: C++ patch for m4/mktime.m4

Albert Chin wrote: >> That patch looks fine. >> Would you please write a ChangeLog entry and then send git format-patch >> output to the list? Then, I can easily/reliably apply it in your name >> using "git am". coreutils has similar contribution guidelines, with >> set-up instructions: >> >>