Re: tests cleanup

2008-09-29 Thread Simon Josefsson
I ported Eric Blake's test-memchr.c fix to test-memrchr.c, and fixed another minor bug in test-getdate.c. This fixed the two warnings that are easy to fix on: http://autobuild.josefsson.org/gnulib/log-200809290932420171000.txt The rest are warnings about possibly uninitialized variables, but all

Re: final snapshot in preparation for m4 1.4.12

2008-09-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Tom G. Christensen on 9/29/2008 1:00 PM: >> Can you post the relevent section of config.log related to signbit tests? >> > I wasn't sure what parts would be considered relevant so I've dumped > full config.log files and buildlogs at: > ht

Re: execute, pipe: pass environment variables

2008-09-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Ralf Wildenhues on 9/29/2008 1:32 PM: >> Propagate effects of putenv/setenv/unsetenv to child processes. >> * lib/execute.c (execute): Use spawnvpe instead of spawnvp. >> * lib/pipe.c (create_pipe): Likewise. > > Nice! Do

printf("%.0f", 0.5) and round-to-even

2008-09-29 Thread Eric Blake
An interesting question popped up on the bug-gnu-utils list: http://lists.gnu.org/archive/html/bug-gnu-utils/2008-09/msg00055.html POSIX states that with %f, the low-order digit is rounded in an implementation- defined manner. However, since 0.5 is exactly half-way between 0 and 1, and most mach

Re: [PATCH]: Do not allow countable dayshifts in getdate.y

2008-09-29 Thread Jim Meyering
Ondřej Vašík <[EMAIL PROTECTED]> wrote: > this patch for getdate.y module restricts usage of countable dayshifts > e.g. +40 tommorow ago, next yesterday etc. > Tests to gnulib getdate testsuite were added. > As this usage of dayshifts is quite insane, I guess no documentation for > it is required.

Re: willing to contribute verrevcmp to gnulib?

2008-09-29 Thread Jim Meyering
Ian Jackson <[EMAIL PROTECTED]> wrote: > Jim Meyering writes ("Re: willing to contribute verrevcmp to gnulib?"): >> Depending on the code: GPL, LGPL, LGPLv2+. >> For this function, LGPL or LGPLv2+ would be appropriate, >> since it's intended to replace glibc's strverscmp. > > Right. I hereby permi

Re: git warning about whitespace?

2008-09-29 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > Hi, > > Just saw this while performing a git operation: > > $ git rebase origin/master > First, rewinding head to replay your work on top of it... > Applying Propagate effects of putenv/setenv/unsetenv to child processes. > Applying A new test for

Re: git warning about whitespace?

2008-09-29 Thread Ralf Wildenhues
Hi Bruno, * Bruno Haible wrote on Mon, Sep 29, 2008 at 09:53:42PM CEST: > Just saw this while performing a git operation: > > $ git rebase origin/master > First, rewinding head to replay your work on top of it... > Applying Propagate effects of putenv/setenv/unsetenv to child processes. >

git warning about whitespace?

2008-09-29 Thread Bruno Haible
Hi, Just saw this while performing a git operation: $ git rebase origin/master First, rewinding head to replay your work on top of it... Applying Propagate effects of putenv/setenv/unsetenv to child processes. Applying A new test for posix_spawn. .dotest/patch:309: trailing whitespace.

Re: [PATCH v2] implement full-blown select(2) for winsock

2008-09-29 Thread Paolo Bonzini
> How about adding an assertion like this? > > + if (!timeout && rc == 0) > + abort (); But wouldn't this trigger in your case, thus aborting select() and poll()? > But I am afraid to propose this as a fix, because this is busy-looping, and > the purpose of select() is to avoid busy-looping

Re: execute, pipe: pass environment variables

2008-09-29 Thread Ralf Wildenhues
Hi Bruno, * Bruno Haible wrote on Mon, Sep 29, 2008 at 03:26:42PM CEST: > This changes execute() and create_pipe_*() so that they pass the environment > 'environ' to child processes, like on Unix. > > 2008-09-29 Bruno Haible <[EMAIL PROTECTED]> > > Propagate effects of putenv/setenv/unse

Re: [PATCH v2] implement full-blown select(2) for winsock

2008-09-29 Thread Paolo Bonzini
Bruno Haible wrote: > Hi Paolo, > > Thank you for providing this select() implementation! With it, I can now make > 'msgfilter' work on mingw. > > Here's a patch for a possible optimization: select() on a regular file > should return "ready" always, no? There's no need to even call > WaitForSingl

Re: final snapshot in preparation for m4 1.4.12

2008-09-29 Thread Tom G. Christensen
On Mon, Sep 29, 2008 at 06:05:07AM -0600, Eric Blake wrote: > According to Tom G. Christensen on 9/28/2008 4:16 AM: > > > > On Irix 6.x gnulib test-signbit still fails: > > test-signbit.c:149: assertion failed > > /bin/ksh[10]: 18432 Abort(coredump) > > FAIL: test-signbit > > That line is "ASSERT

Re: [PATCH v2] implement full-blown select(2) for winsock

2008-09-29 Thread Bruno Haible
> handle console handles (e.g. stdin) For reference, here is the code that is in use in clisp to detect whether reading from a handle would hang or return immediately. The deal with ENABLE_LINE_INPUT is that PeekConsoleInput will say "yes there is something is available" as soon as the user has st

Re: [PATCH v2] implement full-blown select(2) for winsock

2008-09-29 Thread Bruno Haible
Hi Paolo, In some cases, the select() emulation returns 0 even when no timeout was specified. I use it in msgfilter for communication with a subprocess. - Initially I call select() on 2 file descriptors: an fd for parent<-child and another for child->parent writing. select() reports that writin

Re: [PATCH v2] implement full-blown select(2) for winsock

2008-09-29 Thread Bruno Haible
Hi Paolo, Thank you for providing this select() implementation! With it, I can now make 'msgfilter' work on mingw. Here's a patch for a possible optimization: select() on a regular file should return "ready" always, no? There's no need to even call WaitForSingleObject on this one, IMO. Proposed p

Re: snapshot in preparation for m4-1.4.11.51-5116

2008-09-29 Thread Elbert Pol
Hoi, Bruno Haible wrote: Elbert Pol wrote: $ gdb test-open.exe break rpl_open run break 116 continue nexti print statbuf nexti print statbuf nexti print statbuf nexti print statbuf nexti print statbuf nexti print statbuf ne

Re: willing to contribute verrevcmp to gnulib?

2008-09-29 Thread Kamil Dudka
On Monday 29 September 2008 16:12:18 Ian Jackson wrote: > And which files are we talking about ? lib/vercmp.c > NB that the dpkg comparison algorithm was recently extended to support > a new character ~ which sorts before the empty string. This work > wasn't done by me - but I approve of it and i

Re: willing to contribute verrevcmp to gnulib?

2008-09-29 Thread Ian Jackson
Also, ... > > > Is there a chance that you would be willing to contribute to the > > > FSF the actual code from dpkg for this? (Otherwise, we will > > > probably have one person write a formal specification for the > > > version comparison algorithm, and then another person implement > > > somethi

Re: willing to contribute verrevcmp to gnulib?

2008-09-29 Thread Ian Jackson
Jim Meyering writes ("Re: willing to contribute verrevcmp to gnulib?"): > Depending on the code: GPL, LGPL, LGPLv2+. > For this function, LGPL or LGPLv2+ would be appropriate, > since it's intended to replace glibc's strverscmp. Right. I hereby permit, insofar as I am able, the relicensing of dpk

Re: willing to contribute verrevcmp to gnulib?

2008-09-29 Thread Ian Jackson
Ian Jackson writes ("Re: willing to contribute verrevcmp to gnulib?"): > What precisely is the problem ? Is it just that the version in dpkg > is GPLv2+ and you want something more liberal ? And which files are we talking about ? NB that the dpkg comparison algorithm was recently extended to sup

Re: willing to contribute verrevcmp to gnulib?

2008-09-29 Thread Ian Jackson
Ian Jackson writes ("Re: willing to contribute verrevcmp to gnulib?"): > What is the licence on gnulib ? I'm very probably be happy to > relicence. I see that there is a mixture of licenses in gnulib. What precisely is the problem ? Is it just that the version in dpkg is GPLv2+ and you want som

Re: willing to contribute verrevcmp to gnulib?

2008-09-29 Thread Ian Jackson
Jim Meyering writes ("Re: willing to contribute verrevcmp to gnulib?"): > Ben Pfaff <[EMAIL PROTECTED]> wrote: > > Hi Ian. The GNU gnulib project is considering adding a function > > that would compare strings in the same way that dpkg compares > > version numbers, as you can see in the thread her

Re: willing to contribute verrevcmp to gnulib?

2008-09-29 Thread Jim Meyering
Ian Jackson <[EMAIL PROTECTED]> wrote: > Jim Meyering writes ("Re: willing to contribute verrevcmp to gnulib?"): >> Ben Pfaff <[EMAIL PROTECTED]> wrote: >> > Hi Ian. The GNU gnulib project is considering adding a function >> > that would compare strings in the same way that dpkg compares >> > vers

Re: willing to contribute verrevcmp to gnulib?

2008-09-29 Thread Jim Meyering
Ben Pfaff <[EMAIL PROTECTED]> wrote: > Hi Ian. The GNU gnulib project is considering adding a function > that would compare strings in the same way that dpkg compares > version numbers, as you can see in the thread here: > http://permalink.gmane.org/gmane.comp.lib.gnulib.bugs/14693 > > Is

execute, pipe: pass environment variables

2008-09-29 Thread Bruno Haible
This changes execute() and create_pipe_*() so that they pass the environment 'environ' to child processes, like on Unix. 2008-09-29 Bruno Haible <[EMAIL PROTECTED]> Propagate effects of putenv/setenv/unsetenv to child processes. * lib/execute.c (execute): Use spawnvpe instead of

execute, pipe: allow shell scripts on mingw

2008-09-29 Thread Bruno Haible
This allows the use of shell scripts in place of executables on mingw. 2008-09-29 Bruno Haible <[EMAIL PROTECTED]> Enable use of shell scripts as executables in mingw. * lib/execute.c (execute): When spawnv fails with error ENOEXEC, run the program as a shell script.

Re: m4/*_h.m4: improve idioms

2008-09-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 9/27/2008 11:15 AM: > > +dnl Unconditionally enables the replacement of . > +AC_DEFUN([gl_REPLACE_ARPA_INET_H], > +[ > + AC_REQUIRE([gl_ARPA_INET_H_DEFAULTS]) > + ARPA_INET_H='arpa/inet.h' > +) I'm committing a fix for

[PATCH] Support renaming bootstrap

2008-09-29 Thread Paolo Bonzini
GNU sed calls the bootstrap script autoboot because "bootstrap.sh" is taken by the no-configure-script bootstrapping tool. This patch allows renaming the bootstrap script, so that the configuration file is named correspondingly. Are there packages calling the script bootstrap.sh? This would brea

Re: final snapshot in preparation for m4 1.4.12

2008-09-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Tom G. Christensen on 9/28/2008 4:16 AM: > I gave this a run on Irix 5.3, 6.2 & 6.5 using SGI compilers. > Things look good and the m4 testsuite passes on all 3 platforms. Good to hear! > On Irix 5.3 it skips test-cstack2.sh because it w

Re: tee logs no output if stdout is closed

2008-09-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 9/26/2008 8:10 AM: >> I know this condition arises only when ignoring or handling SIGPIPE, >> (which should be rather unusual) but even so, I really dislike the idea >> of ignoring a write error. Even if the write error wo

Re: [PATCH] enhance the bootstrap script to support gnulib as a submodule

2008-09-29 Thread Paolo Bonzini
> Is it still possible to save space by hardlinking gnulib's object > storage with that of other gnulib trees? It does so by default, apparently: ~/sed/gnulib/.git/objects/ff bonzinip$ ls -l total 12 -r--r--r-- 2 377 Sep 23 11:49 56cbaeb94df799287111d03f35a345e351704f -r--r--r-- 2 416 Sep 23 1

Re: [PATCH] enhance the bootstrap script to support gnulib as a submodule

2008-09-29 Thread Ralf Wildenhues
Hi Paolo, a couple of comments: * Paolo Bonzini wrote on Mon, Sep 29, 2008 at 11:45:39AM CEST: > > in GNU sed I want to attach each commit with an exact version of gnulib, > because otherwise the bootstrapping shell script (used to compile a > decent sed without using configure) most likely won'

Re: on OSF/1

2008-09-29 Thread Paolo Bonzini
Bruno Haible wrote: > Hi Paolo, > >> What about this patch? Bruno, can you give it a try on OSF/1? > > The patch is obviously correct. You can apply it, together with this > enhancement of the unit test. I'll test it in the next few days. Done. Paolo

Re: on OSF/1

2008-09-29 Thread Bruno Haible
Hi Paolo, > What about this patch? Bruno, can you give it a try on OSF/1? The patch is obviously correct. You can apply it, together with this enhancement of the unit test. I'll test it in the next few days. Bruno *** tests/test-sys_select.c.orig2008-09-29 12:42:28.0 +0200 ---

Re: [PATCH] Update doc for socket functions

2008-09-29 Thread Bruno Haible
Hi Paolo, Paolo Bonzini wrote: > The attached patch updates the documentation on socket functions after > the recent Winsock commits. All right. However, I would write "On Windows platforms (excluding Cygwin)" instead of "On mingw", since all the statements apply also to people who use MSVC and t

Re: sockets module and Solaris

2008-09-29 Thread Paolo Bonzini
> *** modules/poll-tests.orig 2008-09-29 11:32:59.0 +0200 > --- modules/poll-tests2008-09-29 11:32:45.0 +0200 > *** > *** 18,20 > --- 18,21 > Makefile.am: > TESTS += test-poll > check_PROGRAMS += test-poll > + test_poll_LDADD = $(LDADD) @LIBSOC

Re: sockets module and Solaris

2008-09-29 Thread Paolo Bonzini
> *** modules/sys_select-tests.orig 2008-09-28 20:36:59.0 +0200 > --- modules/sys_select-tests 2008-09-28 19:43:06.0 +0200 > *** > *** 16,21 > --- 16,22 > Makefile.am: > TESTS += test-sys_select > check_PROGRAMS += test-sys_select > + test_sys_selec

[PATCH] Update doc for socket functions

2008-09-29 Thread Paolo Bonzini
The attached patch updates the documentation on socket functions after the recent Winsock commits. Ok? Paolo 2008-08-24 Paolo Bonzini <[EMAIL PROTECTED]> * doc/posix-functions/accept.texi: Update mingw problems. * doc/posix-functions/bind.texi: Update mingw problems. *

Re: on OSF/1

2008-09-29 Thread Paolo Bonzini
Simon Josefsson wrote: > Bruno Haible <[EMAIL PROTECTED]> writes: > >> On OSF/1 4.0, exists but provides only a forward declaration >> of 'struct timeval', no definition of this type. > > Sigh. So it seems we need a sys_select header module and a separate > select function after all: someone mi

Re: fopen bug on Solaris, HP-UX

2008-09-29 Thread Bruno Haible
Hi, Michael Haubenwallner wrote: > How do gnulib's file-functions respect the different sets of > large-file-defines among several platforms in general? The autoconf macro AC_SYS_LARGEFILE does it all. It defines _FILE_OFFSET_BITS, _LARGE_FILES, or whatever system-dependent magic is needed to get

[PATCH] Install git-merge-changelog in bootstrap

2008-09-29 Thread Paolo Bonzini
This is another local patch I had for bootstrap in sed. It automatically adds to .git/config the required lines to use the git-merge-changelog driver. To use this feature, in addition, the project maintainer must add ChangeLog* merge=merge-changelog in the root .gitattributes file. Ok? Paolo

[PATCH] enhance the bootstrap script to support gnulib as a submodule

2008-09-29 Thread Paolo Bonzini
Hi all, in GNU sed I want to attach each commit with an exact version of gnulib, because otherwise the bootstrapping shell script (used to compile a decent sed without using configure) most likely won't work. This is a natural use case for git's submodule feature; the attached patch makes the boo

Re: sockets module and Solaris

2008-09-29 Thread Bruno Haible
Hi Simon, > Ah, yes, I remember this. The module was never tested on Solaris > before. Btw, possibly you'll need -lnsl too? I recall that the idiom > to get anything moderately complex to build on Solaris was to add -lnsl > -lsockets. No, -lnsl is not needed always, and in particular not for t

Re: fopen bug on Solaris, HP-UX

2008-09-29 Thread Michael Haubenwallner
On Mon, 2008-09-29 at 10:01 +0200, Michael Haubenwallner wrote: > On Sun, 2008-09-28 at 14:59 +0200, Bruno Haible wrote: > > A followup to this override of open() and fopen(): > > > > > > 2008-09-28 Bruno Haible <[EMAIL PROTECTED]> > > > * lib/stdio.in.h (fopen, freopen): Undefine before

Re: fopen bug on Solaris, HP-UX

2008-09-29 Thread Michael Haubenwallner
On Sun, 2008-09-28 at 14:59 +0200, Bruno Haible wrote: > A followup to this override of open() and fopen(): > > > 2008-09-28 Bruno Haible <[EMAIL PROTECTED]> > * lib/stdio.in.h (fopen, freopen): Undefine before redefining. Needed > with AIX xlc. Maybe I should just try more hard

Re: m4/*_h.m4: improve idioms

2008-09-29 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Simon, is the part for m4/arpa_inet_h.m4 fine with you? (Not yet committed.) I didn't test it, but I agree with the approach so please push it. /Simon

Re: on OSF/1

2008-09-29 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > On OSF/1 4.0, exists but provides only a forward declaration > of 'struct timeval', no definition of this type. Sigh. So it seems we need a sys_select header module and a separate select function after all: someone might want to get the 'struct timeval

Re: sockets module and Solaris

2008-09-29 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Hi Simon, > > Here are two change requests regarding the 'sockets' module: > > 1) Currently it adds the library option -lws2_32 to LIBS. But I don't want >to link all gettext tools against this libray, just because one program >(test-sys_select) n