Re: require texinfo 4.6?

2008-01-07 Thread Ralf Wildenhues
Hi Jim, * Jim Meyering wrote on Mon, Jan 07, 2008 at 11:34:19PM CET: > Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > > > > * DEPENDENCIES: Require Texinfo version 4.6 or newer. > > Considering some people (like me :) are using texinfo-4.11, > and 4.6 is over 4 years old, that is a shoe-in. Ap

Re: [patch] make acl support optional

2008-01-07 Thread Mike Frysinger
On Monday 07 January 2008, Jim Meyering wrote: > Mike Frysinger <[EMAIL PROTECTED]> wrote: > > On Saturday 29 December 2007, Mike Frysinger wrote: > >> On Wednesday 25 July 2007, Mike Frysinger wrote: > >> > posted this to the coreutils a list sometime ago ... idea is to be > >> > able to disable a

Re: strsignal module

2008-01-07 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > It's a moving target, but it can be defined roughly like this: > - All platforms with a Unix like API, that are not older than ca. 6 years. > This leads approximately to this list: > glibc >= 2.1, MacOS X >= 10.2, FreeBSD >= 4.8, NetBSD >= 3.0

Re: documentation structure

2008-01-07 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 1/7/2008 5:58 PM: | I'm therefore in favour of putting this description under "Particular Modules". | | If gnulib implements a significant number of functions specified by glibc | - strsignal was just mentioned - then I'm

Re: getloadavg on aix5

2008-01-07 Thread Peter O'Gorman
I seem to have lost Jim's reply, but here is a patch. Works on aix-4.3.3 and aix-5.3. The SBITS thing is the way the libperstat.h header recommends calculating the loadavg: /* To calculate the load average, divide the numbers by (1<. */ Of course, it is not defined on aix4.3.3 ... Peter diff --

Re: fseeko failure [was: wcwidth failure on RedHat Linux 7.3 (coreutils-6.9.91)]

2008-01-07 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Peter Fales on 1/7/2008 11:53 AM: |> | This change fixes the problem in in test-wcwidth. There is one other |> | failure in test-fseeko.sh when building on RedHat 7.3. |> |> More details, please? | | I'm guessing this due to an incompati

Re: memmem speedup

2008-01-07 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 1/7/2008 5:54 PM: | | Thanks for the comments; they are essential for understanding the code. | I also find your comments clearer than the text in .../~lecroq/... Thanks for your review. Also, is there any reason to have

Re: AC_FUNC_MEMMEM

2008-01-07 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [adding bug-gnulib] According to Peter Miller on 1/7/2008 5:15 PM: | On Sat, 2008-01-05 at 21:51 -0700, Eric Blake wrote: |> glibc 2.6.1 is quadratic, gnulib is linear. For worst-case scenarios, |> gnulib's implementation is hands-down better, altho

Re: strsignal module

2008-01-07 Thread Bruno Haible
Micah Cowan wrote: > Is there a general guideline for what constitutes "Gnulib's supported > platforms"? It's a moving target, but it can be defined roughly like this: - All platforms with a Unix like API, that are not older than ca. 6 years. This leads approximately to this list: glib

Re: autoupdate config.guess, config.sub

2008-01-07 Thread Bruno Haible
Ralf Wildenhues wrote: > Bruno, I suppose config.rpath and config.libpath would need adjustment > as well. Should I send a patch? Normally, I update these files after an official libtool release. Once a libtool-1.5.26 is released, I'll update these. But in this case, the diffs are probably small

Re: strsignal module

2008-01-07 Thread Micah Cowan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruno Haible wrote: > Colin Watson wrote: >> Do you happen to know whether I was overdoing it by adding in #ifdefs >> for SIGHUP, SIGINT, etc.? I decided better safe than sorry, but didn't >> know whether there was some basic set of signals that Gnulib

Re: test-localename failure

2008-01-07 Thread Bruno Haible
Simon Josefsson wrote: > +2008-01-06 Simon Josefsson <[EMAIL PROTECTED]> > + > + * tests/test-localename.c: Don't include obsolete "setenv.h". > + > + * modules/localename-tests (Depends-on): Need unsetenv. > + It's good. Thank you; it was my mistake. Please apply. Bruno

Re: Add man-db to users.txt

2008-01-07 Thread Bruno Haible
Colin Watson wrote: > --- a/users.txt > +++ b/users.txt > @@ -34,6 +34,7 @@ The following packages appear to be using gnulib and > gnulib-tool: >libvirt http://libvirt.org/ >http://git.et.redhat.com/?p=libvirt.git;a=summary >m4 http://git.sv.gnu.org

Re: strsignal module

2008-01-07 Thread Bruno Haible
Colin Watson wrote: > Do you happen to know whether I was overdoing it by adding in #ifdefs > for SIGHUP, SIGINT, etc.? I decided better safe than sorry, but didn't > know whether there was some basic set of signals that Gnulib's supported > platforms were guaranteed to have. You were right. The s

Re: string.h and NULL [was: memmem issues]

2008-01-07 Thread Bruno Haible
Eric Blake wrote: > According to Bruno Haible on 12/21/2007 6:42 AM: > | does not define NULL. Better write (void*)0 or "" instead of > NULL. > > Which platforms have a broken that fails to define NULL? Actually all platforms I have access to today define NULL in . Probably the latest platform

Re: commit to gnulib.texi

2008-01-07 Thread Bruno Haible
Karl Berry wrote: > 2007-12-30 Karl Berry <[EMAIL PROTECTED]> > * doc/gnulib.texi (Library vs. Reusable Code): remove period, to > work around defect in Texinfo and/or the standalone Info browser. > > Rationale: this is simply the most expedient way to work around the > present subop

Re: lib/progname.c

2008-01-07 Thread Bruno Haible
Ralf Wildenhues wrote: > I think that an lt-program* outside [._]libs/ would be a bug. Thanks for this statement. On platforms where gnulib is used, the directory name is '.libs', not '_libs'. I'm doing as Paul suggested, but with a simpler patch (less micro-optimizations -> easier to understand).

Re: documentation structure (was: Re: test-memmem takes waaay too long)

2008-01-07 Thread Bruno Haible
Eric Blake wrote: > I'm installing these two commits: > > * modules/memmem-tests (configure.ac): Check for alarm. > * tests/test-memmem.c (main): Avoid alarm on platforms that lack it. Thanks for these. > * doc/functions/memmem.texi: New file. > * doc/gnulib.texi (Function Substitutes): Add memm

Re: strsignal module

2008-01-07 Thread Bruno Haible
Colin Watson wrote: > I use strsignal in man-db, and would like a Gnulib module to cope with > its portability problems. Here's one which seems to be doing the right > thing for me so far. This is my first attempt at writing a Gnulib module > from scratch, so I'd appreciate any comments, style or o

Re: memmem speedup

2008-01-07 Thread Bruno Haible
Eric Blake wrote: > I've finished my implementation of a Two-Way plus Boyer-Moore hybrid > string search algorithm for the memmmem module. This patch has passed > everything I've thrown at it so far, and it has the nice properties of > avoiding alloca/malloc (hence it is async-safe), as well as al

Re: Gnulib needed in AC_CHECK_HEADERS

2008-01-07 Thread Bruno Haible
Paul Eggert wrote: > For example, one could build a program that uses gcc's libiberty along > with some gnulib code. The libiberty code won't use Gnulib's > substitute, but that's OK; it will still work just as well > as it does now. > > So I still don't see the downside of making that change.

Re: Some free()s in module 'relocatable'

2008-01-07 Thread Bruno Haible
Hi Sylvain, Sylvain Beucler wrote: > > > Attached is a small patch to fix a couple non-fred memory blocks. They > > > are not a big deal, but they do produce noise when analyzing programs > > > with memory checkers such as Valgrind. > I do attach the patch now :) Thanks for the patch. I can even

Re: require texinfo 4.6?

2008-01-07 Thread Jim Meyering
Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > The standards.texi document uses @/ for splitting of long lines > (in URLs), this syntax requires a newer Texinfo than 4.2. > OK to apply? > > * DEPENDENCIES: Require Texinfo version 4.6 or newer. Considering some people (like me :) are using texi

Re: wcwidth failure on RedHat Linux 7.3 (coreutils-6.9.91)

2008-01-07 Thread Bruno Haible
Peter Fales wrote: > This change fixes the problem in in test-wcwidth. Thanks for confirming this. I'm applying this change to the test. (One can hardly say "fix", since the behaviour of various Unicode characters in wcwidth is not clearly standardized.) 2008-01-01 Bruno Haible <[EMAIL PROTECTE

require texinfo 4.6?

2008-01-07 Thread Ralf Wildenhues
Hello, The standards.texi document uses @/ for splitting of long lines (in URLs), this syntax requires a newer Texinfo than 4.2. OK to apply? Cheers, Ralf * DEPENDENCIES: Require Texinfo version 4.6 or newer. diff --git a/DEPENDENCIES b/DEPENDENCIES index ed051be..a8f9a9d 100644 --- a/D

autoupdate config.guess, config.sub

2008-01-07 Thread Ralf Wildenhues
Hello, FYI, I updated gnulib's copies of the config files, to have AIX 6.1 support. Bruno, I suppose config.rpath and config.libpath would need adjustment as well. Should I send a patch? Cheers, Ralf

Re: strsignal module

2008-01-07 Thread Colin Watson
On Mon, Jan 07, 2008 at 01:06:38PM -0800, Paul Eggert wrote: > Thanks for tackling this. My kneejerk reaction: as a general rule, we > prefer the differences between gnulib and the GNU C library to be > localized to small sections of the code, and protected by #if !_LIBC, > the idea being that ide

Re: strsignal module

2008-01-07 Thread Paul Eggert
Thanks for tackling this. My kneejerk reaction: as a general rule, we prefer the differences between gnulib and the GNU C library to be localized to small sections of the code, and protected by #if !_LIBC, the idea being that ideally the gnulib and GNU C Library versions can be identical. Please

Re: memmem speedup

2008-01-07 Thread Ralf Wildenhues
Hi Eric, * Eric Blake wrote on Sun, Jan 06, 2008 at 02:23:33AM CET: > > I'd appreciate any reviews before checking it in. Here's a rough glance at it. FWIW, the diff is not very readable (there was a patch to diffutils out there for --more-readable). > +/* We use the Two-Way string matching al

Re: fseeko failure [was: wcwidth failure on RedHat Linux 7.3 (coreutils-6.9.91)]

2008-01-07 Thread Peter Fales
On Sun, Jan 06, 2008 at 06:26:16AM -0700, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to Peter Fales on 12/30/2007 11:46 PM: > | This change fixes the problem in in test-wcwidth. There is one other > | failure in test-fseeko.sh when building on RedHat 7.3. >

Re: getloadavg on aix5

2008-01-07 Thread Jim Meyering
"Peter O'Gorman" <[EMAIL PROTECTED]> wrote: > While getloadavg works ok on aix4, it returns incorrect results on > aix5. > > Why do we not use libperfstat on aix? > http://publib.boulder.ibm.com/infocenter/pseries/v5r3/topic/com.ibm.aix.basetechref/doc/basetrf1/perfstat_cputot.htm > It has the adva

getloadavg on aix5

2008-01-07 Thread Peter O'Gorman
Hi, While getloadavg works ok on aix4, it returns incorrect results on aix5. Why do we not use libperfstat on aix? http://publib.boulder.ibm.com/infocenter/pseries/v5r3/topic/com.ibm.aix.basetechref/doc/basetrf1/perfstat_cputot.htm It has the advantage of not requiring root privs to get the load

Re: strstr, async-safety, and worst-case performance

2008-01-07 Thread Clive D.W. Feather
Eric Blake said: > Should POSIX require linear (rather than quadratic) worst-case performance > in strstr? Or maybe we just leave this improvement as a > quality-of-implementation issue, but perhaps document in the application > notes document that many implementations use less-than-stellar algori

Re: [patch] make acl support optional

2008-01-07 Thread Jim Meyering
Mike Frysinger <[EMAIL PROTECTED]> wrote: > On Saturday 29 December 2007, Mike Frysinger wrote: >> On Wednesday 25 July 2007, Mike Frysinger wrote: >> > posted this to the coreutils a list sometime ago ... idea is to be able >> > to disable automatic ACL detection via --disable-acl since this can o