Re: fseeko bug

2007-12-13 Thread Jay Levitt
On 12/13/2007 9:40 PM, Eric Blake wrote: off_t == long is not a problem. Only off_t > long. Great. - -- Don't work too hard, make some time for fun as well! Every time I see your SIG, I feel like it's an accurate assessment of my time management skills, so I resolve to work half as hard as

Re: m4-1.4.10 segfault with x86_64 during ./configure when checking whether printf supports infinite 'long double' arguments

2007-12-13 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Gilles Espinasse on 12/12/2007 3:29 PM: Hi Gilles, > -- System Information: > Debian Release: 4.0 > APT prefers stable > APT policy: (500, 'stable') > Architecture: amd64 (x86_64) > Shell: /bin/sh linked to /bin/bash > Kernel: Linux

Re: fseeko bug

2007-12-13 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jay Levitt on 12/13/2007 5:05 PM: > > Stratus! We have off_t (= long) but no fseeko. But I'm the only user > there and I haven't actually been using it yet, so that's not very > convincing. It's more of a part-time/hobby port than anyt

Re: fseeko bug

2007-12-13 Thread Jay Levitt
On 12/13/2007 5:06 PM, Eric Blake wrote: Larry Jones siemens.com> writes: Looks good. You might want to consider adding tests to make sure that any pending ungetc() data is cleared like it's supposed to be. I don't see any code that obviously does that, so I suspect it's not. Does this loo

Re: fseeko bug

2007-12-13 Thread Eric Blake
Larry Jones siemens.com> writes: > Looks good. You might want to consider adding tests to make sure that > any pending ungetc() data is cleared like it's supposed to be. I don't > see any code that obviously does that, so I suspect it's not. Does this look correct? I'm checking it in. > > O

Re: fseeko bug

2007-12-13 Thread Larry Jones
Eric Blake writes: > > Just to make sure other platforms aren't affected, I'm installing this. Looks good. You might want to consider adding tests to make sure that any pending ungetc() data is cleared like it's supposed to be. I don't see any code that obviously does that, so I suspect it's no

Re: fseeko bug

2007-12-13 Thread Eric Blake
Eric Blake byu.net> writes: > > Larry Jones siemens.com> writes: > > > > > CVS nightly testing has been failing on BSD/OS and I've finally tracked > > the problem down to a bug in fseeko -- it doesn't clear the EOF flag > > after doing its magic: > > Just to make sure other platforms aren't

Re: fseeko bug

2007-12-13 Thread Eric Blake
Larry Jones siemens.com> writes: > > CVS nightly testing has been failing on BSD/OS and I've finally tracked > the problem down to a bug in fseeko -- it doesn't clear the EOF flag > after doing its magic: Just to make sure other platforms aren't affected, I'm installing this. From: Eric Blake

Re: fseeko bug

2007-12-13 Thread Eric Blake
Larry Jones siemens.com> writes: > > CVS nightly testing has been failing on BSD/OS and I've finally tracked > the problem down to a bug in fseeko -- it doesn't clear the EOF flag > after doing its magic: Thanks. Since the gnulib tests-fseeko doesn't test that, we should probably beef it up a

fseeko bug

2007-12-13 Thread Larry Jones
CVS nightly testing has been failing on BSD/OS and I've finally tracked the problem down to a bug in fseeko -- it doesn't clear the EOF flag after doing its magic: Index: fseeko.c === RCS file: /cvsroot/cvs/ccvs/lib/fseeko.c,v retriev