On 12/13/2007 5:06 PM, Eric Blake wrote:
Larry Jones <lawrence.jones <at> siemens.com> writes:
Looks good. You might want to consider adding tests to make sure that
any pending ungetc() data is cleared like it's supposed to be. I don't
see any code that obviously does that, so I suspect it's not.
Does this look correct? I'm checking it in.
On a more general note, it looks like fseeko and ftello both need more
work to be generally useful on platforms that have a wide off_t but
don't have native fseeko/ftello.
Name such a platform, then we'll worry about it. In general, since fseeko and
off_t were invented at the same time as two parts of the solution to the same
problem, pretty much every system out there either has both or neither. But
maybe it's at least worth adding a compile-time assertion that sizeof(off_t)
==sizeof(long) when !HAVE_FSEEKO.
Stratus! We have off_t (= long) but no fseeko. But I'm the only user
there and I haven't actually been using it yet, so that's not very
convincing. It's more of a part-time/hobby port than anything.
So don't do any coding just for me, but if you could give a hint as to
what I could/should do if/when I get around to working on Stratus
porting again, it'd be helpful.
Jay
